opendev/gerrit
Code Issues Proposed changes

Rename TestAccount#getIdent to newIdent

Browse Source 
Each time this method is called, it returns a new PersonIdent with a new
timestamp.

The other get* methods in this class also happen to return new
instances, but this is essentially an implementation detail: all
instances returned by those methods are equal and may be used
interchangeably.

Change-Id: Iff9b476bd7d2ac67160d3f54c36bd5b22b95c89b
This commit is contained in:
Dave Borowitz
2018-09-14 10:31:35 -07:00
parent 2665c256f3
commit e35947b587
57 changed files with 330 additions and 330 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/acceptance/AbstractNotificationTest.java
View File

@@ -468,7 +468,7 @@ public abstract class AbstractNotificationTest extends AbstractDaemonTest {
}
requestScopeOperations.setApiUser(owner.id());
repo = cloneProject(project, owner);
PushOneCommit push = pushFactory.create(owner.getIdent(), repo);
PushOneCommit push = pushFactory.create(owner.newIdent(), repo);
result = push.to(ref);
result.assertOkStatus();
changeId = result.getChangeId();