opendev/gerrit
Code Issues Proposed changes

Merge "RevertSubmission: Use Comparator.comparing to sort results"

Browse Source
This commit is contained in:
Edwin Kempin
2019-12-18 09:20:33 +00:00
committed by Gerrit Code Review
parent 03a77c48be 3dd9573bdb
commit e39fc49fe3
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/com/google/gerrit/server/restapi/change/RevertSubmission.java
View File

@@ -78,7 +78,7 @@ import java.util.ArrayDeque;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collection; import java.util.Collection;
import java.util.Collections; import java.util.Comparator;
import java.util.Iterator; import java.util.Iterator;
import java.util.List; import java.util.List;
import java.util.Queue; import java.util.Queue;
@@ -301,11 +301,7 @@ public class RevertSubmission
} }
cherryPickInput.base = null; cherryPickInput.base = null;
} }
Collections.sort( results.sort(Comparator.comparing(c -> c.updated));
results,
(change1, change2) -> {
return change1.updated.compareTo(change2.updated);
});
RevertSubmissionInfo revertSubmissionInfo = new RevertSubmissionInfo(); RevertSubmissionInfo revertSubmissionInfo = new RevertSubmissionInfo();
revertSubmissionInfo.revertChanges = results; revertSubmissionInfo.revertChanges = results;
return revertSubmissionInfo; return revertSubmissionInfo;