opendev/gerrit
Code Issues Proposed changes

Tweak wording for GC command status messages

Browse Source 
Make the status messages returned by running a garbage collection
full sentences.  This makes them a little easier to read.

Change-Id: I55beffd85f95e2abfcc56acf39ff044813ce20f8
This commit is contained in:
Brad Larson
2013-12-23 14:21:45 -06:00
parent cfd54d6e20
commit e3a04a6c70
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gerrit-server/src/main/java/com/google/gerrit/server/project/GarbageCollect.java
View File

@@ -67,24 +67,24 @@ public class GarbageCollect implements RestModifyView<ProjectResource, Input>,
try {
GarbageCollectionResult result = garbageCollectionFactory.create().run(
Collections.singletonList(rsrc.getNameKey()), input.showProgress ? writer : null);
String msg = "garbage collection was successfully done";
String msg = "Garbage collection completed successfully.";
if (result.hasErrors()) {
for (GarbageCollectionResult.Error e : result.getErrors()) {
switch (e.getType()) {
case REPOSITORY_NOT_FOUND:
msg = "error: project \"" + e.getProjectName() + "\" not found";
msg = "Error: project \"" + e.getProjectName() + "\" not found.";
break;
case GC_ALREADY_SCHEDULED:
msg = "error: garbage collection for project \""
+ e.getProjectName() + "\" was already scheduled";
msg = "Error: garbage collection for project \""
+ e.getProjectName() + "\" was already scheduled.";
break;
case GC_FAILED:
msg = "error: garbage collection for project \"" + e.getProjectName()
+ "\" failed";
msg = "Error: garbage collection for project \"" + e.getProjectName()
+ "\" failed.";
break;
default:
msg = "error: garbage collection for project \"" + e.getProjectName()
+ "\" failed: " + e.getType();
msg = "Error: garbage collection for project \"" + e.getProjectName()
+ "\" failed: " + e.getType() + ".";
}
}
}