SSH: Don't use providers in commands
SSH commands are created in request scope. That why it's not needed to use providers for current user and review db, that are also provided in the same scope. Providers are needed when data is used across scope boundaries, e.g. PatchSetParser that is bound in singleton scope must use providers to access current user and review db. Change-Id: I53b5d1c4004cd0fbbc6b5f6cdb798b2201e2a9be
This commit is contained in:

committed by
David Ostrovsky

parent
29a1f982bb
commit
e3d68ae823
@@ -72,7 +72,7 @@ public class ListGroupsCommand extends SshCommand {
|
||||
final GroupControl.GenericFactory genericGroupControlFactory,
|
||||
final Provider<IdentifiedUser> identifiedUser,
|
||||
final IdentifiedUser.GenericFactory userFactory,
|
||||
final Provider<GetGroups> accountGetGroups,
|
||||
final GetGroups accountGetGroups,
|
||||
final GroupJson json,
|
||||
GroupBackend groupBackend) {
|
||||
super(groupCache, groupControlFactory, genericGroupControlFactory,
|
||||
|
Reference in New Issue
Block a user