opendev/gerrit
Code Issues Proposed changes

Reset image styling when diff is re-rendered

Browse Source 
Because the image diff builder added classes directly on the diff table
element, and because the table element is reused across diff renders,
it was possible for the class to leak into the next diff render, which
may not have been an image diff. Apply the same styles without adding
classes to the table.

Bug: Issue 9651
Change-Id: Ie66a0dbd0577cce3a78c570d7055681271c5a70d
This commit is contained in:
Wyatt Allen
2018-08-28 16:28:26 -07:00
parent 8d052edb22
commit e3ef1da5b0
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.js
View File

@@ -35,7 +35,6 @@
GrDiffBuilderImage.prototype.constructor = GrDiffBuilderImage;
GrDiffBuilderImage.prototype.renderDiff = function() {
this._outputEl.classList.add('image-diff');
const section = this._createElement('tbody', 'image-diff');
this._emitImagePair(section);

4
polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
View File

@@ -55,7 +55,6 @@ limitations under the License.
background-color: var(--table-header-background-color);
}
.image-diff .gr-diff {
background-color: var(--table-header-background-color);
text-align: center;
}
.image-diff img {
@@ -83,6 +82,9 @@ limitations under the License.
.content {
background-color: var(--view-background-color);
}
.image-diff .content {
background-color: var(--table-header-background-color);
}
.full-width {
width: 100%;
}