diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/ChainedReceiveCommands.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/ChainedReceiveCommands.java index cfbaa41e8d..a3b30d1900 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/ChainedReceiveCommands.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/ChainedReceiveCommands.java @@ -17,8 +17,6 @@ package com.google.gerrit.server.git; import static com.google.common.base.Preconditions.checkArgument; import static com.google.common.base.Preconditions.checkNotNull; -import com.google.common.base.Optional; - import org.eclipse.jgit.lib.BatchRefUpdate; import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.lib.Repository; @@ -28,6 +26,7 @@ import java.io.IOException; import java.util.Collections; import java.util.LinkedHashMap; import java.util.Map; +import java.util.Optional; /** * Collection of {@link ReceiveCommand}s that supports multiple updates per ref. @@ -96,7 +95,7 @@ public class ChainedReceiveCommands implements RefCache { if (cmd != null) { return !cmd.getNewId().equals(ObjectId.zeroId()) ? Optional.of(cmd.getNewId()) - : Optional.absent(); + : Optional.empty(); } return refCache.get(refName); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/RefCache.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/RefCache.java index 562db086a6..96593ac3a2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/RefCache.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/RefCache.java @@ -14,11 +14,10 @@ package com.google.gerrit.server.git; -import com.google.common.base.Optional; - import org.eclipse.jgit.lib.ObjectId; import java.io.IOException; +import java.util.Optional; /** * Simple short-lived cache of individual refs read from a repo. diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/RepoRefCache.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/RepoRefCache.java index 1dfa51e7ef..77f697a731 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/RepoRefCache.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/RepoRefCache.java @@ -14,8 +14,6 @@ package com.google.gerrit.server.git; -import com.google.common.base.Optional; - import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.lib.Ref; import org.eclipse.jgit.lib.RefDatabase; @@ -24,6 +22,7 @@ import org.eclipse.jgit.lib.Repository; import java.io.IOException; import java.util.HashMap; import java.util.Map; +import java.util.Optional; /** {@link RefCache} backed directly by a repository. */ public class RepoRefCache implements RefCache { @@ -42,9 +41,7 @@ public class RepoRefCache implements RefCache { return id; } Ref ref = refdb.exactRef(refName); - id = ref != null - ? Optional.of(ref.getObjectId()) - : Optional.absent(); + id = Optional.ofNullable(ref).map(Ref::getObjectId); ids.put(refName, id); return id; } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/ChangeNotes.java b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/ChangeNotes.java index 4967b0f49b..68be2c538d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/ChangeNotes.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/ChangeNotes.java @@ -566,7 +566,7 @@ public class ChangeNotes extends AbstractChangeNotes { @Override protected ObjectId readRef(Repository repo) throws IOException { return refs != null - ? refs.get(getRefName()).orNull() + ? refs.get(getRefName()).orElse(null) : super.readRef(repo); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/NoteDbChangeState.java b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/NoteDbChangeState.java index 4aed71e30f..ad54f02555 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/NoteDbChangeState.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/NoteDbChangeState.java @@ -22,7 +22,6 @@ import static java.util.Comparator.comparing; import com.google.auto.value.AutoValue; import com.google.common.annotations.VisibleForTesting; -import com.google.common.base.Optional; import com.google.common.base.Predicates; import com.google.common.base.Splitter; import com.google.common.collect.ImmutableMap; @@ -40,6 +39,7 @@ import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map; +import java.util.Optional; /** * The state of all relevant NoteDb refs across all repos corresponding to a diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/NoteDbUpdateManager.java b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/NoteDbUpdateManager.java index 18cac47747..1f64bcc359 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/NoteDbUpdateManager.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/NoteDbUpdateManager.java @@ -21,7 +21,6 @@ import static com.google.gerrit.reviewdb.client.RefNames.REFS_DRAFT_COMMENTS; import static com.google.gerrit.server.notedb.NoteDbTable.CHANGES; import com.google.auto.value.AutoValue; -import com.google.common.base.Optional; import com.google.common.collect.ArrayListMultimap; import com.google.common.collect.HashBasedTable; import com.google.common.collect.ImmutableList; @@ -58,6 +57,7 @@ import java.util.Collection; import java.util.HashMap; import java.util.HashSet; import java.util.Map; +import java.util.Optional; import java.util.Set; /** @@ -362,7 +362,7 @@ public class NoteDbUpdateManager implements AutoCloseable { StagedResult r = StagedResult.create( e.getKey(), NoteDbChangeState.Delta.create( - e.getKey(), Optional.absent(), e.getValue()), + e.getKey(), Optional.empty(), e.getValue()), changeRepo, allUsersRepo); checkState(r.changeCommands().isEmpty(), "should not have change commands when updating only drafts: %s", r); @@ -550,7 +550,7 @@ public class NoteDbUpdateManager implements AutoCloseable { for (Map.Entry> e : all.asMap().entrySet()) { String refName = e.getKey(); Collection updates = e.getValue(); - ObjectId old = or.cmds.get(refName).or(ObjectId.zeroId()); + ObjectId old = or.cmds.get(refName).orElse(ObjectId.zeroId()); // Only actually write to the ref if one of the updates explicitly allows // us to do so, i.e. it is known to represent a new change. This avoids // writing partial change meta if the change hasn't been backfilled yet. diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/ChangeRebuilderImpl.java b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/ChangeRebuilderImpl.java index 1f687fc808..037e86baa1 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/ChangeRebuilderImpl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/ChangeRebuilderImpl.java @@ -19,10 +19,10 @@ import static com.google.common.base.Preconditions.checkState; import static com.google.gerrit.reviewdb.client.RefNames.changeMetaRef; import static com.google.gerrit.server.notedb.ChangeNoteUtil.FOOTER_HASHTAGS; import static com.google.gerrit.server.notedb.ChangeNoteUtil.FOOTER_PATCH_SET; + import static java.util.concurrent.TimeUnit.SECONDS; import static java.util.stream.Collectors.toList; -import com.google.common.base.Optional; import com.google.common.base.Splitter; import com.google.common.collect.ArrayListMultimap; import com.google.common.collect.ImmutableSet; @@ -87,6 +87,7 @@ import java.util.Comparator; import java.util.List; import java.util.Map; import java.util.Objects; +import java.util.Optional; import java.util.Set; public class ChangeRebuilderImpl extends ChangeRebuilder { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/StatusChangeEvent.java b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/StatusChangeEvent.java index c7632e8015..ca55e7534f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/StatusChangeEvent.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/StatusChangeEvent.java @@ -14,7 +14,6 @@ package com.google.gerrit.server.notedb.rebuild; -import com.google.common.base.Optional; import com.google.common.collect.ImmutableMap; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; @@ -25,6 +24,7 @@ import com.google.gwtorm.server.OrmException; import java.sql.Timestamp; import java.util.Map; +import java.util.Optional; import java.util.regex.Pattern; class StatusChangeEvent extends Event { @@ -40,7 +40,7 @@ class StatusChangeEvent extends Event { Change change, Change noteDbChange) { String msg = message.getMessage(); if (msg == null) { - return Optional.absent(); + return Optional.empty(); } for (Map.Entry e : PATTERNS.entrySet()) { if (e.getValue().matcher(msg).matches()) { @@ -48,7 +48,7 @@ class StatusChangeEvent extends Event { message, change, noteDbChange, e.getKey())); } } - return Optional.absent(); + return Optional.empty(); } private final Change change; diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/notedb/NoteDbChangeStateTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/notedb/NoteDbChangeStateTest.java index 216f71bbf3..47b4939c22 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/notedb/NoteDbChangeStateTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/notedb/NoteDbChangeStateTest.java @@ -18,9 +18,9 @@ import static com.google.common.base.Preconditions.checkArgument; import static com.google.common.truth.Truth.assertThat; import static com.google.gerrit.server.notedb.NoteDbChangeState.applyDelta; import static com.google.gerrit.server.notedb.NoteDbChangeState.parse; + import static org.eclipse.jgit.lib.ObjectId.zeroId; -import com.google.common.base.Optional; import com.google.common.collect.ImmutableMap; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; @@ -33,6 +33,8 @@ import com.google.gwtorm.server.StandardKeyEncoder; import org.eclipse.jgit.lib.ObjectId; import org.junit.Test; +import java.util.Optional; + /** Unit tests for {@link NoteDbChangeState}. */ public class NoteDbChangeStateTest { static { @@ -134,7 +136,7 @@ public class NoteDbChangeStateTest { // Static factory methods to avoid type arguments when using as method args. private static Optional noMetaId() { - return Optional.absent(); + return Optional.empty(); } private static Optional metaId(ObjectId id) {