opendev/gerrit
Code Issues Proposed changes

Remove "Hashtags" header in change screen

Browse Source 
With all #hashtags prefixed with "#", it feels
wasteful to use a <td>-column to explain that
the #hashtags are actually #hashtags. It is
now obvious enough.

Fix: Remove the table header for Hashtags and
rename the Add-button.

Change-Id: I149ded73d5dd3239c46d1320fb3a94b7b38a6e1b
This commit is contained in:
Gustaf Lundh
2014-09-22 00:10:34 +02:00
parent a3e4722e4c
commit e42c7d380a
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml
View File

@@ -459,8 +459,7 @@ limitations under the License.
<td ui:field='actionDate'/> <td ui:field='actionDate'/>
</tr> </tr>
<tr ui:field='hashtagTableRow'> <tr ui:field='hashtagTableRow'>
<th><ui:msg>Hashtags</ui:msg></th> <td colspan='2'>
<td>
<c:Hashtags ui:field='hashtags'/> <c:Hashtags ui:field='hashtags'/>
</td> </td>
</tr> </tr>

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.ui.xml
View File

@@ -60,7 +60,7 @@ limitations under the License.
addStyleNames='{style.openAdd}' addStyleNames='{style.openAdd}'
visible='false'> visible='false'>
<ui:attribute name='title'/> <ui:attribute name='title'/>
<div><ui:msg>Add...</ui:msg></div> <div><ui:msg>Add #...</ui:msg></div>
</g:Button> </g:Button>
</div> </div>
<div ui:field='form' style='display: none' aria-hidden='true'> <div ui:field='form' style='display: none' aria-hidden='true'>