opendev/gerrit
Code Issues Proposed changes

Rework some CSS constant usage

Browse Source 
Usage of the --header-background-color constant in place of #eee was a
bit aggressive. This change modifies the styling to use constants that
have a more consistent usage (table-header-background-color, for
instance) and also introduces another new color,
--chip-background-color, for styling chips.

Bug: Issue 8809
Change-Id: Ie3acbfa4d221acc4f210f76bbb425a21e7f8b63e
This commit is contained in:
Kasper Nilsson
2018-04-30 10:14:58 -07:00
parent 9813123504
commit e46284e4c2
6 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.html
View File

@@ -58,8 +58,9 @@ limitations under the License.
margin-bottom: 1em; margin-bottom: 1em;
} }
ul li { ul li {
border: 1px solid var(--border-color);
border-radius: .2em; border-radius: .2em;
background: var(--header-background-color); background: var(--chip-background-color);
display: inline-block; display: inline-block;
margin: 0 .2em .4em .2em; margin: 0 .2em .4em .2em;
padding: .2em .4em; padding: .2em .4em;

2
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html
View File

@@ -120,7 +120,7 @@ limitations under the License.
display: block; display: block;
} }
.previewContainer gr-formatted-text { .previewContainer gr-formatted-text {
background: var(--header-background-color); background: var(--table-header-background-color);
padding: 1em; padding: 1em;
} }
.draftsContainer h3 { .draftsContainer h3 {

2
polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
View File

@@ -201,7 +201,7 @@ limitations under the License.
display: block; display: block;
} }
.target-row td.blame { .target-row td.blame {
background: var(--header-background-color); background: var(--diff-selection-background-color);
} }
col.blame { col.blame {
display: none; display: none;

2
polygerrit-ui/app/elements/shared/gr-account-chip/gr-account-chip.html
View File

@@ -31,7 +31,7 @@ limitations under the License.
} }
.container { .container {
align-items: center; align-items: center;
background: var(--header-background-color); background: var(--table-header-background-color);
border-radius: .75em; border-radius: .75em;
display: inline-flex; display: inline-flex;
padding: 0 .5em; padding: 0 .5em;

2
polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.html
View File

@@ -31,7 +31,7 @@ limitations under the License.
} }
.container { .container {
align-items: center; align-items: center;
background: var(--header-background-color); background: var(--chip-background-color);
border-radius: .75em; border-radius: .75em;
display: inline-flex; display: inline-flex;
padding: 0 .5em; padding: 0 .5em;

2
polygerrit-ui/app/styles/app-theme.html
View File

@@ -42,6 +42,8 @@ limitations under the License.
--table-header-background-color: #fafafa; --table-header-background-color: #fafafa;
--table-subheader-background-color: #eaeaea; --table-subheader-background-color: #eaeaea;
--chip-background-color: var(--header-background-color);
--dropdown-background-color: #fff; --dropdown-background-color: #fff;
/* Font sizes */ /* Font sizes */