diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RevisionNote.java b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RevisionNote.java index d93336a3da..4c9f7026e8 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RevisionNote.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RevisionNote.java @@ -83,7 +83,7 @@ class RevisionNote { if (isJson(raw, p.value)) { RevisionNoteData data = parseJson(noteUtil, p.value); - comments = data.exportComments(status); + comments = data.exportComments(changeId, status); if (status == PatchLineComment.Status.PUBLISHED) { pushCert = data.pushCert; } else { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RevisionNoteData.java b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RevisionNoteData.java index 9998ba0c76..73083b797d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RevisionNoteData.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/RevisionNoteData.java @@ -48,19 +48,17 @@ class RevisionNoteData { String uuid; String filename; int patchSetId; - int changeId; CommentKey(PatchLineComment.Key k) { uuid = k.get(); filename = k.getParentKey().getFileName(); patchSetId = k.getParentKey().getParentKey().get(); - changeId = k.getParentKey().getParentKey().getParentKey().get(); } - PatchLineComment.Key export() { + PatchLineComment.Key export(Change.Id changeId) { return new PatchLineComment.Key( new Patch.Key( - new PatchSet.Id(new Change.Id(changeId), patchSetId), + new PatchSet.Id(changeId, patchSetId), filename), uuid); } @@ -112,9 +110,10 @@ class RevisionNoteData { this.serverId = serverId; } - PatchLineComment export(PatchLineComment.Status status) { + PatchLineComment export(Change.Id changeId, + PatchLineComment.Status status) { PatchLineComment plc = new PatchLineComment( - key.export(), lineNbr, author.export(), parentUuid, writtenOn); + key.export(changeId), lineNbr, author.export(), parentUuid, writtenOn); plc.setSide(side); plc.setMessage(message); if (range != null) { @@ -131,11 +130,12 @@ class RevisionNoteData { String pushCert; List comments; - ImmutableList exportComments( + + ImmutableList exportComments(Change.Id changeId, PatchLineComment.Status status) { return ImmutableList.copyOf( comments.stream() - .map(c -> c.export(status)) + .map(c -> c.export(changeId, status)) .collect(toList())); } }