opendev/gerrit
Code Issues Proposed changes

Display links in PatchSetSelectBox only once

Browse Source 
On navigation to the next/previous patch, the links in the
PatchSetSelectBox of the old patch are show twice until the new patch
is loaded. This is especially bad if the loading of the next/previous
patch fails with an exception so that the screen stays with the old
patch. Retrying in this situation to navigate to the next/previous
patch adds another instance of the links to the PatchSetSelectBox.

Change-Id: Ia5a4e2b12e22cf01ac76bd044977cbe024875595
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-08-08 09:34:04 +02:00
parent 897ceab188
commit e5ade76a81
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchSetSelectBox.java
View File

@@ -90,6 +90,8 @@ public class PatchSetSelectBox extends Composite {
this.idActive = (side == Side.A) ? idSideA : idSideB;
this.links = new LinkedList<Anchor>();
linkPanel.clear();
if (screenType == PatchScreen.Type.UNIFIED) {
sideMarker.setInnerText((side == Side.A) ? "(-)" : "(+)");
} else {