opendev/gerrit
Code Issues Proposed changes

Fix method duplication incurred when splitting OutgoingEmail

Browse Source 
Remove the methods that were duplicated by accident in
ChangeEmail, and fix some access rights to those which
are now solely in OutoingEmail so that ChangeEmail can
still use them.

Change-Id: Iaf53b6314e0f57c84a6c99a7fe4fdb1deaf01f01
This commit is contained in:
Martin Fick
2010-07-23 09:33:55 -06:00
parent df89f998d5
commit e6784e9701
2 changed files with 2 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java
View File

@@ -237,16 +237,6 @@ public abstract class ChangeEmail extends OutgoingEmail {
return null;
}
private String getSettingsUrl() {
if (getGerritUrl() != null) {
final StringBuilder r = new StringBuilder();
r.append(getGerritUrl());
r.append("settings");
return r.toString();
}
return null;
}
protected String getChangeMessageThreadId() {
final StringBuilder r = new StringBuilder();
r.append('<');
@@ -328,13 +318,6 @@ public abstract class ChangeEmail extends OutgoingEmail {
return r != null ? r.getOwners() : Collections.<AccountGroup.Id> emptySet();
}
/** Schedule this message for delivery to the listed accounts. */
protected void add(final RecipientType rt, final Collection<Account.Id> list) {
for (final Account.Id id : list) {
add(rt, id);
}
}
/** TO or CC all vested parties (change owner, patch set uploader, author). */
protected void rcptToAuthors(final RecipientType rt) {
add(rt, change.getOwner());
@@ -347,12 +330,6 @@ public abstract class ChangeEmail extends OutgoingEmail {
}
}
private void add(final RecipientType rt, final UserIdentity who) {
if (who != null && who.getAccount() != null) {
add(rt, who.getAccount());
}
}
/** BCC any user who has starred this change. */
protected void bccStarredBy() {
try {