From e69cd5c9b78ec7c1f10d30f220bf0b61462ab44d Mon Sep 17 00:00:00 2001 From: Han-Wen Nienhuys Date: Wed, 31 Jan 2018 16:24:52 +0100 Subject: [PATCH] Clarify use of PermissionCollection.Factory#filter. Change-Id: I4d106a8490207aaceaa8a6d60790a55f69f34f1a --- .../google/gerrit/server/permissions/PermissionCollection.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/java/com/google/gerrit/server/permissions/PermissionCollection.java b/java/com/google/gerrit/server/permissions/PermissionCollection.java index 1e8ea9a8ea..aa50c253d0 100644 --- a/java/com/google/gerrit/server/permissions/PermissionCollection.java +++ b/java/com/google/gerrit/server/permissions/PermissionCollection.java @@ -61,7 +61,8 @@ public class PermissionCollection { } /** - * Get all permissions that apply to a reference. + * Get all permissions that apply to a reference. The user is only used for per-user ref names, + * so the return value may include permissions for groups the user is not part of. * * @param matcherList collection of sections that should be considered, in priority order * (project specific definitions must appear before inherited ones).