opendev/gerrit
Code Issues Proposed changes

Fix lint errors

Browse Source 
Change-Id: I71e0c481c4408058dd48b6295876d7b952cdbd38
This commit is contained in:
Becky Siegel 2017-01-04 13:38:54 -08:00
parent 4dc0da639e
commit e6bb34fbf0
3 changed files with 4 additions and 3 deletions
polygerrit-ui/app/elements
change/gr-file-list
gr-file-list_test.html
diff/gr-diff-builder
gr-diff-builder.js
settings/gr-settings-view
gr-settings-view_test.html

2
polygerrit-ui/app/elements/change/gr-file-list/gr-file-list_test.html

@ -393,7 +393,7 @@ limitations under the License.
'1d');
assert.equal(
element._computeCountString(comments, '1',
'file_added_in_rev2.txt', 'comment'),'');
'file_added_in_rev2.txt', 'comment'), '');
assert.equal(
element._computeCommentsStringMobile(comments, '1',
'file_added_in_rev2.txt'), '');

2
polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js

@ -575,7 +575,7 @@
return group.type === GrDiffGroup.Type.DELTA &&
(!group.adds.length || !group.removes.length) &&
!(!group.adds.length && !group.removes.length);
}
};
window.GrDiffBuilder = GrDiffBuilder;
})(window, GrDiffGroup, GrDiffLine);

3
polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.html

@ -387,7 +387,8 @@ limitations under the License.
test('show-alert is fired when email is confirmed', function(done) {
sandbox.spy(element, 'fire');
element._loadingPromise.then(function() {
assert.isTrue(element.fire.calledWith('show-alert', {message: 'bar'}));
assert.isTrue(
element.fire.calledWith('show-alert', {message: 'bar'}));
done();
});
resolveConfirm('bar');