opendev/gerrit
Code Issues Proposed changes

A11y - toggle button for dark mode should be associated with the label next

Browse Source 
Change-Id: I8436107444ca16042261aca8e657793f14fa9c12
This commit is contained in:
Milutin Kristofic
2020-05-25 10:02:05 +02:00
parent 7c55ca449e
commit e6d00ed84e
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_html.js
View File

@@ -98,10 +98,11 @@ export const htmlTemplate = html`
<section class="darkToggle"> <section class="darkToggle">
<div class="toggle"> <div class="toggle">
<paper-toggle-button <paper-toggle-button
aria-labelledby="darkThemeToggleLabel"
checked="[[_isDark]]" checked="[[_isDark]]"
on-change="_handleToggleDark" on-change="_handleToggleDark"
></paper-toggle-button> ></paper-toggle-button>
<div>Dark theme (alpha)</div> <div id="darkThemeToggleLabel">Dark theme (alpha)</div>
</div> </div>
<p> <p>
Gerrit's dark theme is in early alpha, and almost definitely will not Gerrit's dark theme is in early alpha, and almost definitely will not