opendev/gerrit
Code Issues Proposed changes

ChangeIT: Check that reviewer was added

Browse Source 
Change-Id: I2712d7a53483a3b0daa8cde5ae32fd21cee3d3ce
This commit is contained in:
Dave Borowitz
2014-05-13 16:24:17 -07:00
parent 91cd1c6719
commit e6ffd895ac
1 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/change/ChangeIT.java
View File

@@ -16,21 +16,28 @@ package com.google.gerrit.acceptance.api.change;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Sets;
import com.google.gerrit.acceptance.AbstractDaemonTest; import com.google.gerrit.acceptance.AbstractDaemonTest;
import com.google.gerrit.acceptance.NoHttpd; import com.google.gerrit.acceptance.NoHttpd;
import com.google.gerrit.acceptance.PushOneCommit; import com.google.gerrit.acceptance.PushOneCommit;
import com.google.gerrit.extensions.api.changes.AddReviewerInput; import com.google.gerrit.extensions.api.changes.AddReviewerInput;
import com.google.gerrit.extensions.api.changes.ChangeApi;
import com.google.gerrit.extensions.api.changes.ReviewInput; import com.google.gerrit.extensions.api.changes.ReviewInput;
import com.google.gerrit.extensions.common.ApprovalInfo;
import com.google.gerrit.extensions.common.ChangeInfo; import com.google.gerrit.extensions.common.ChangeInfo;
import com.google.gerrit.extensions.common.ChangeStatus; import com.google.gerrit.extensions.common.ChangeStatus;
import com.google.gerrit.extensions.common.LabelInfo;
import com.google.gerrit.extensions.restapi.ResourceConflictException; import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.reviewdb.client.Account;
import org.eclipse.jgit.api.errors.GitAPIException; import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.lib.Constants; import org.eclipse.jgit.lib.Constants;
import org.junit.Test; import org.junit.Test;
import java.io.IOException; import java.io.IOException;
import java.util.Set;
@NoHttpd @NoHttpd
public class ChangeIT extends AbstractDaemonTest { public class ChangeIT extends AbstractDaemonTest {
@@ -101,15 +108,25 @@ public class ChangeIT extends AbstractDaemonTest {
.rebase(); .rebase();
} }
private static Set<Account.Id> getReviewers(ChangeInfo ci) {
Set<Account.Id> result = Sets.newHashSet();
for (LabelInfo li : ci.labels.values()) {
for (ApprovalInfo ai : li.all) {
result.add(new Account.Id(ai._accountId));
}
}
return result;
}
@Test @Test
public void addReviewer() throws GitAPIException, public void addReviewer() throws GitAPIException,
IOException, RestApiException { IOException, RestApiException {
PushOneCommit.Result r = createChange(); PushOneCommit.Result r = createChange();
AddReviewerInput in = new AddReviewerInput(); AddReviewerInput in = new AddReviewerInput();
in.reviewer = user.email; in.reviewer = user.email;
gApi.changes() ChangeApi cApi = gApi.changes().id("p~master~" + r.getChangeId());
.id("p~master~" + r.getChangeId()) cApi.addReviewer(in);
.addReviewer(in); assertEquals(ImmutableSet.of(user.id), getReviewers(cApi.get()));
} }
@Test @Test