opendev/gerrit
Code Issues Proposed changes

Bind the REST API in an own module

Browse Source 
This is a preparation to move the bindings for the REST API out of
GerritGlobalModule so that at Google we can replace them with custom
bindings.

Change-Id: I36b24206375ee0db4f14e8d50de7cd2721236747
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2018-05-15 09:13:56 +02:00
parent cfadd11fc1
commit e7077b8820
2 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/com/google/gerrit/server/config/GerritGlobalModule.java
View File

@@ -169,6 +169,7 @@ import com.google.gerrit.server.query.change.ChangeData;
import com.google.gerrit.server.query.change.ChangeQueryBuilder; import com.google.gerrit.server.query.change.ChangeQueryBuilder;
import com.google.gerrit.server.query.change.ChangeQueryProcessor; import com.google.gerrit.server.query.change.ChangeQueryProcessor;
import com.google.gerrit.server.query.change.ConflictsCacheImpl; import com.google.gerrit.server.query.change.ConflictsCacheImpl;
import com.google.gerrit.server.restapi.RestApiModule;
import com.google.gerrit.server.restapi.change.SuggestReviewers; import com.google.gerrit.server.restapi.change.SuggestReviewers;
import com.google.gerrit.server.restapi.group.GroupModule; import com.google.gerrit.server.restapi.group.GroupModule;
import com.google.gerrit.server.rules.DefaultSubmitRule; import com.google.gerrit.server.rules.DefaultSubmitRule;
@@ -305,12 +306,7 @@ public class GerritGlobalModule extends FactoryModule {
install(new AuditModule()); install(new AuditModule());
bind(UiActions.class); bind(UiActions.class);
install(new com.google.gerrit.server.restapi.access.Module()); install(new RestApiModule());
install(new com.google.gerrit.server.restapi.config.Module());
install(new com.google.gerrit.server.restapi.change.Module());
install(new com.google.gerrit.server.restapi.account.Module());
install(new com.google.gerrit.server.restapi.project.Module());
install(new com.google.gerrit.server.restapi.group.Module());
bind(GitReferenceUpdated.class); bind(GitReferenceUpdated.class);
DynamicMap.mapOf(binder(), new TypeLiteral<Cache<?, ?>>() {}); DynamicMap.mapOf(binder(), new TypeLiteral<Cache<?, ?>>() {});

29
java/com/google/gerrit/server/restapi/RestApiModule.java Normal file
View File

@@ -0,0 +1,29 @@
// Copyright (C) 2018 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.server.restapi;
import com.google.inject.AbstractModule;
public class RestApiModule extends AbstractModule {
@Override
protected void configure() {
install(new com.google.gerrit.server.restapi.access.Module());
install(new com.google.gerrit.server.restapi.account.Module());
install(new com.google.gerrit.server.restapi.change.Module());
install(new com.google.gerrit.server.restapi.config.Module());
install(new com.google.gerrit.server.restapi.group.Module());
install(new com.google.gerrit.server.restapi.project.Module());
}
}