diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/AcceptanceTestRequestScope.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/AcceptanceTestRequestScope.java index 63bdfd2610..6ee7efad32 100644 --- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/AcceptanceTestRequestScope.java +++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/AcceptanceTestRequestScope.java @@ -130,8 +130,7 @@ public class AcceptanceTestRequestScope { } } - private static final ThreadLocal current = - new ThreadLocal(); + private static final ThreadLocal current = new ThreadLocal<>(); private static Context requireContext() { final Context ctx = current.get(); diff --git a/gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheFactory.java b/gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheFactory.java index cb209e2b4c..85e4599cc7 100644 --- a/gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheFactory.java +++ b/gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheFactory.java @@ -212,6 +212,6 @@ class H2CacheFactory implements PersistentCacheFactory, LifecycleListener { long maxSize) { File db = new File(cacheDir, name).getAbsoluteFile(); String url = "jdbc:h2:" + db.toURI().toString(); - return new SqlStore(url, keyType, maxSize); + return new SqlStore<>(url, keyType, maxSize); } } diff --git a/gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java b/gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java index 4aca42b90d..de7613d7e3 100644 --- a/gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java +++ b/gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java @@ -115,7 +115,7 @@ public class H2CacheImpl extends AbstractLoadingCache { @Override public void put(final K key, V val) { - final ValueHolder h = new ValueHolder(val); + final ValueHolder h = new ValueHolder<>(val); h.created = TimeUtil.nowMs(); mem.put(key, h); executor.execute(new Runnable() { @@ -246,7 +246,7 @@ public class H2CacheImpl extends AbstractLoadingCache { } } - final ValueHolder h = new ValueHolder(loader.load(key)); + final ValueHolder h = new ValueHolder<>(loader.load(key)); h.created = TimeUtil.nowMs(); executor.execute(new Runnable() { @Override @@ -302,7 +302,7 @@ public class H2CacheImpl extends AbstractLoadingCache { return (KeyType) OTHER; } - static final KeyType OTHER = new KeyType(); + static final KeyType OTHER = new KeyType<>(); static final KeyType STRING = new KeyType() { @Override String columnType() { @@ -346,7 +346,7 @@ public class H2CacheImpl extends AbstractLoadingCache { int cores = Runtime.getRuntime().availableProcessors(); int keep = Math.min(cores, 16); - this.handles = new ArrayBlockingQueue(keep); + this.handles = new ArrayBlockingQueue<>(keep); } synchronized void open() { @@ -440,7 +440,7 @@ public class H2CacheImpl extends AbstractLoadingCache { @SuppressWarnings("unchecked") V val = (V) r.getObject(1); - ValueHolder h = new ValueHolder(val); + ValueHolder h = new ValueHolder<>(val); h.clean = true; hitCount.incrementAndGet(); touch(c, key); diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/LabelTypes.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/LabelTypes.java index b47445e601..18928f23b4 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/LabelTypes.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/LabelTypes.java @@ -33,7 +33,7 @@ public class LabelTypes { public LabelTypes(final List approvals) { labelTypes = - Collections.unmodifiableList(new ArrayList(approvals)); + Collections.unmodifiableList(new ArrayList<>(approvals)); } public List getLabelTypes() { diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/Permission.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/Permission.java index 0326e0213b..2379b4ac9e 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/Permission.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/Permission.java @@ -48,7 +48,7 @@ public class Permission implements Comparable { private static final int labelAsIndex; static { - NAMES_LC = new ArrayList(); + NAMES_LC = new ArrayList<>(); NAMES_LC.add(OWNER.toLowerCase()); NAMES_LC.add(READ.toLowerCase()); NAMES_LC.add(ABANDON.toLowerCase()); @@ -229,7 +229,7 @@ public class Permission implements Comparable { private void initRules() { if (rules == null) { - rules = new ArrayList(4); + rules = new ArrayList<>(4); } } diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ReviewInput.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ReviewInput.java index 993fa14cb6..9a88b0c4e2 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ReviewInput.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ReviewInput.java @@ -97,7 +97,7 @@ public class ReviewInput { throw new IllegalArgumentException(); } if (labels == null) { - labels = new LinkedHashMap(4); + labels = new LinkedHashMap<>(4); } labels.put(name, value); return this; diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicItem.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicItem.java index 91bf7a6117..9ef7d1b783 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicItem.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicItem.java @@ -78,7 +78,7 @@ public class DynamicItem { Key> key = (Key>) Key.get( Types.newParameterizedType(DynamicItem.class, member.getType())); binder.bind(key) - .toProvider(new DynamicItemProvider(member, key)) + .toProvider(new DynamicItemProvider<>(member, key)) .in(Scopes.SINGLETON); } @@ -111,10 +111,10 @@ public class DynamicItem { DynamicItem(Key> key, Provider provider, String pluginName) { NamedProvider in = null; if (provider != null) { - in = new NamedProvider(provider, pluginName); + in = new NamedProvider<>(provider, pluginName); } this.key = key; - this.ref = new AtomicReference>(in); + this.ref = new AtomicReference<>(in); } /** @@ -148,7 +148,7 @@ public class DynamicItem { * @return handle to remove the item at a later point in time. */ public RegistrationHandle set(Provider impl, String pluginName) { - final NamedProvider item = new NamedProvider(impl, pluginName); + final NamedProvider item = new NamedProvider<>(impl, pluginName); NamedProvider old = null; while (!ref.compareAndSet(old, item)) { old = ref.get(); @@ -180,7 +180,7 @@ public class DynamicItem { */ public ReloadableRegistrationHandle set(Key key, Provider impl, String pluginName) { - final NamedProvider item = new NamedProvider(impl, pluginName); + final NamedProvider item = new NamedProvider<>(impl, pluginName); NamedProvider old = null; while (!ref.compareAndSet(old, item)) { old = ref.get(); @@ -216,7 +216,7 @@ public class DynamicItem { @Override public ReloadableHandle replace(Key newKey, Provider newItem) { - NamedProvider n = new NamedProvider(newItem, item.pluginName); + NamedProvider n = new NamedProvider<>(newItem, item.pluginName); if (ref.compareAndSet(item, n)) { return new ReloadableHandle(newKey, n, defaultItem); } diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicItemProvider.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicItemProvider.java index 1074ee5960..9b09d15b6e 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicItemProvider.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicItemProvider.java @@ -37,7 +37,7 @@ class DynamicItemProvider implements Provider> { } public DynamicItem get() { - return new DynamicItem(key, find(injector, type), "gerrit"); + return new DynamicItem<>(key, find(injector, type), "gerrit"); } private static Provider find(Injector src, TypeLiteral type) { diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicMap.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicMap.java index 2d6098c886..42518918d1 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicMap.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicMap.java @@ -81,14 +81,14 @@ public abstract class DynamicMap implements Iterable> { Key> key = (Key>) Key.get( Types.newParameterizedType(DynamicMap.class, member.getType())); binder.bind(key) - .toProvider(new DynamicMapProvider(member)) + .toProvider(new DynamicMapProvider<>(member)) .in(Scopes.SINGLETON); } final ConcurrentMap> items; DynamicMap() { - items = new ConcurrentHashMap>( + items = new ConcurrentHashMap<>( 16 /* initial size */, 0.75f /* load factor */, 1 /* concurrency level of 1, load/unload is single threaded */); @@ -115,7 +115,7 @@ public abstract class DynamicMap implements Iterable> { * @return sorted set of active plugins that supply at least one item. */ public SortedSet plugins() { - SortedSet r = new TreeSet(); + SortedSet r = new TreeSet<>(); for (NamePair p : items.keySet()) { r.add(p.pluginName); } @@ -129,7 +129,7 @@ public abstract class DynamicMap implements Iterable> { * @return items exported by a plugin, keyed by the export name. */ public SortedMap> byPlugin(String pluginName) { - SortedMap> r = new TreeMap>(); + SortedMap> r = new TreeMap<>(); for (Map.Entry> e : items.entrySet()) { if (e.getKey().pluginName.equals(pluginName)) { r.put(e.getKey().exportName, e.getValue()); diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicMapProvider.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicMapProvider.java index c6e4701537..2554673fec 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicMapProvider.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicMapProvider.java @@ -34,7 +34,7 @@ class DynamicMapProvider implements Provider> { public DynamicMap get() { PrivateInternals_DynamicMapImpl m = - new PrivateInternals_DynamicMapImpl(); + new PrivateInternals_DynamicMapImpl<>(); List> bindings = injector.findBindingsByType(type); if (bindings != null) { for (Binding b : bindings) { diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicSet.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicSet.java index b2f19e5b64..628745a225 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicSet.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicSet.java @@ -72,7 +72,7 @@ public class DynamicSet implements Iterable { Key> key = (Key>) Key.get( Types.newParameterizedType(DynamicSet.class, member.getType())); binder.bind(key) - .toProvider(new DynamicSetProvider(member)) + .toProvider(new DynamicSetProvider<>(member)) .in(Scopes.SINGLETON); } @@ -136,7 +136,7 @@ public class DynamicSet implements Iterable { private final CopyOnWriteArrayList>> items; DynamicSet(Collection>> base) { - items = new CopyOnWriteArrayList>>(base); + items = new CopyOnWriteArrayList<>(base); } @Override @@ -194,8 +194,7 @@ public class DynamicSet implements Iterable { * @return handle to remove the item at a later point in time. */ public RegistrationHandle add(final Provider item) { - final AtomicReference> ref = - new AtomicReference>(item); + final AtomicReference> ref = new AtomicReference<>(item); items.add(ref); return new RegistrationHandle() { @Override @@ -218,7 +217,7 @@ public class DynamicSet implements Iterable { * without it ever leaving the collection. */ public ReloadableRegistrationHandle add(Key key, Provider item) { - AtomicReference> ref = new AtomicReference>(item); + AtomicReference> ref = new AtomicReference<>(item); items.add(ref); return new ReloadableHandle(ref, key, item); } diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicSetProvider.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicSetProvider.java index 21fa1b8428..9ea96d4ff1 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicSetProvider.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicSetProvider.java @@ -36,7 +36,7 @@ class DynamicSetProvider implements Provider> { } public DynamicSet get() { - return new DynamicSet(find(injector, type)); + return new DynamicSet<>(find(injector, type)); } private static List>> find( @@ -47,16 +47,12 @@ class DynamicSetProvider implements Provider> { if (cnt == 0) { return Collections.emptyList(); } - List>> r = newList(cnt); + List>> r = new ArrayList<>(cnt); for (Binding b : bindings) { if (b.getKey().getAnnotation() != null) { - r.add(new AtomicReference>(b.getProvider())); + r.add(new AtomicReference<>(b.getProvider())); } } return r; } - - private static List>> newList(int cnt) { - return new ArrayList>>(cnt); - } } diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/PrivateInternals_DynamicTypes.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/PrivateInternals_DynamicTypes.java index 3742f47c67..96538e1cfa 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/PrivateInternals_DynamicTypes.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/PrivateInternals_DynamicTypes.java @@ -31,7 +31,7 @@ import java.util.Map; /** DO NOT USE */ public class PrivateInternals_DynamicTypes { public static Map, DynamicItem> dynamicItemsOf(Injector src) { - Map, DynamicItem> m = newHashMap(); + Map, DynamicItem> m = new HashMap<>(); for (Map.Entry, Binding> e : src.getBindings().entrySet()) { TypeLiteral type = e.getKey().getTypeLiteral(); if (type.getRawType() == DynamicItem.class) { @@ -47,7 +47,7 @@ public class PrivateInternals_DynamicTypes { } public static Map, DynamicSet> dynamicSetsOf(Injector src) { - Map, DynamicSet> m = newHashMap(); + Map, DynamicSet> m = new HashMap<>(); for (Map.Entry, Binding> e : src.getBindings().entrySet()) { TypeLiteral type = e.getKey().getTypeLiteral(); if (type.getRawType() == DynamicSet.class) { @@ -63,7 +63,7 @@ public class PrivateInternals_DynamicTypes { } public static Map, DynamicMap> dynamicMapsOf(Injector src) { - Map, DynamicMap> m = newHashMap(); + Map, DynamicMap> m = new HashMap<>(); for (Map.Entry, Binding> e : src.getBindings().entrySet()) { TypeLiteral type = e.getKey().getTypeLiteral(); if (type.getRawType() == DynamicMap.class) { @@ -85,7 +85,7 @@ public class PrivateInternals_DynamicTypes { return Collections.emptyList(); } - List handles = new ArrayList(4); + List handles = new ArrayList<>(4); try { for (Map.Entry, DynamicItem> e : items.entrySet()) { @SuppressWarnings("unchecked") @@ -115,7 +115,7 @@ public class PrivateInternals_DynamicTypes { return Collections.emptyList(); } - List handles = new ArrayList(4); + List handles = new ArrayList<>(4); try { for (Map.Entry, DynamicSet> e : sets.entrySet()) { @SuppressWarnings("unchecked") @@ -148,7 +148,7 @@ public class PrivateInternals_DynamicTypes { return Collections.emptyList(); } - List handles = new ArrayList(4); + List handles = new ArrayList<>(4); try { for (Map.Entry, DynamicMap> e : maps.entrySet()) { @SuppressWarnings("unchecked") @@ -183,7 +183,7 @@ public class PrivateInternals_DynamicTypes { @Override public void start() { - handles = new ArrayList(4); + handles = new ArrayList<>(4); Injector parent = self.getParent(); while (parent != null) { handles.addAll(attachSets(self, dynamicSetsOf(parent))); @@ -211,10 +211,6 @@ public class PrivateInternals_DynamicTypes { } } - private static Map newHashMap() { - return new HashMap(); - } - private static List> bindings(Injector src, TypeLiteral type) { return src.findBindingsByType(type); } diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/Response.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/Response.java index 848004dc73..314c89819a 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/Response.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/Response.java @@ -21,12 +21,12 @@ public abstract class Response { /** HTTP 200 OK: pointless wrapper for type safety. */ public static Response ok(T value) { - return new Impl(200, value); + return new Impl<>(200, value); } /** HTTP 201 Created: typically used when a new resource is made. */ public static Response created(T value) { - return new Impl(201, value); + return new Impl<>(201, value); } /** HTTP 204 No Content: typically used when the resource is deleted. */ diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/RestApiModule.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/RestApiModule.java index b3a0e18144..7708a5cf89 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/RestApiModule.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/RestApiModule.java @@ -31,47 +31,47 @@ public abstract class RestApiModule extends AbstractModule { protected ReadViewBinder get(TypeLiteral> viewType) { - return new ReadViewBinder(view(viewType, GET, "/")); + return new ReadViewBinder<>(view(viewType, GET, "/")); } protected ModifyViewBinder put(TypeLiteral> viewType) { - return new ModifyViewBinder(view(viewType, PUT, "/")); + return new ModifyViewBinder<>(view(viewType, PUT, "/")); } protected ModifyViewBinder post(TypeLiteral> viewType) { - return new ModifyViewBinder(view(viewType, POST, "/")); + return new ModifyViewBinder<>(view(viewType, POST, "/")); } protected ModifyViewBinder delete(TypeLiteral> viewType) { - return new ModifyViewBinder(view(viewType, DELETE, "/")); + return new ModifyViewBinder<>(view(viewType, DELETE, "/")); } protected ReadViewBinder get(TypeLiteral> viewType, String name) { - return new ReadViewBinder(view(viewType, GET, name)); + return new ReadViewBinder<>(view(viewType, GET, name)); } protected ModifyViewBinder put(TypeLiteral> viewType, String name) { - return new ModifyViewBinder(view(viewType, PUT, name)); + return new ModifyViewBinder<>(view(viewType, PUT, name)); } protected ModifyViewBinder post(TypeLiteral> viewType, String name) { - return new ModifyViewBinder(view(viewType, POST, name)); + return new ModifyViewBinder<>(view(viewType, POST, name)); } protected ModifyViewBinder delete(TypeLiteral> viewType, String name) { - return new ModifyViewBinder(view(viewType, DELETE, name)); + return new ModifyViewBinder<>(view(viewType, DELETE, name)); } protected

ChildCollectionBinder

child(TypeLiteral> type, String name) { - return new ChildCollectionBinder

(view(type, GET, name)); + return new ChildCollectionBinder<>(view(type, GET, name)); } protected diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/css/rebind/CssLinker.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/css/rebind/CssLinker.java index 0f6992d5f9..af80b3cc36 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/css/rebind/CssLinker.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/css/rebind/CssLinker.java @@ -44,8 +44,7 @@ public class CssLinker extends AbstractLinker { final ArtifactSet returnTo = new ArtifactSet(); int index = 0; - final HashMap css = - new HashMap(); + final HashMap css = new HashMap<>(); for (final StandardStylesheetReference ssr : artifacts . find(StandardStylesheetReference.class)) { diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyCommandSet.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyCommandSet.java index 6600a18fb0..e2fec27a45 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyCommandSet.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyCommandSet.java @@ -35,7 +35,7 @@ public class KeyCommandSet implements KeyPressHandler { } public KeyCommandSet(final String setName) { - map = new HashMap(); + map = new HashMap<>(); name = setName; } @@ -79,7 +79,7 @@ public class KeyCommandSet implements KeyPressHandler { public void add(final KeyCommandSet set) { if (sets == null) { - sets = new ArrayList(); + sets = new ArrayList<>(); } assert !sets.contains(set); sets.add(set); diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java index 67a5ef4e7f..c08e830dba 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java @@ -133,8 +133,7 @@ public class KeyHelpPopup extends PluginSafePopupPanel implements * the same name, so that each set name appears at most once. */ private static Collection combinedSetsByName() { - final LinkedHashMap byName = - new LinkedHashMap(); + LinkedHashMap byName = new LinkedHashMap<>(); for (final KeyCommandSet set : GlobalKey.active.all.getSets()) { KeyCommandSet v = byName.get(set.getName()); if (v == null) { @@ -171,7 +170,7 @@ public class KeyHelpPopup extends PluginSafePopupPanel implements lists.resizeRows(row + keys.size()); } - Map rows = new HashMap(); + Map rows = new HashMap<>(); FORMAT_KEYS: for (int i = 0; i < keys.size(); i++) { final KeyCommand k = keys.get(i); if (rows.containsKey(k)) { @@ -234,7 +233,7 @@ public class KeyHelpPopup extends PluginSafePopupPanel implements } private List sort(final KeyCommandSet set) { - final List keys = new ArrayList(set.getKeys()); + final List keys = new ArrayList<>(set.getKeys()); Collections.sort(keys, new Comparator() { @Override public int compare(KeyCommand arg0, KeyCommand arg1) { diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/AttMap.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/AttMap.java index 46d7f51ead..b08b29f0b9 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/AttMap.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/AttMap.java @@ -23,7 +23,7 @@ class AttMap { private static final HashMap TAGS; static { final Tag src = new SrcTag(); - TAGS = new HashMap(); + TAGS = new HashMap<>(); TAGS.put("a", new AnchorTag()); TAGS.put("form", new FormTag()); TAGS.put("img", src); @@ -31,8 +31,8 @@ class AttMap { TAGS.put("frame", src); } - private final ArrayList names = new ArrayList(); - private final ArrayList values = new ArrayList(); + private final ArrayList names = new ArrayList<>(); + private final ArrayList values = new ArrayList<>(); private Tag tag = ANY; private int live; diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/HighlightSuggestOracle.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/HighlightSuggestOracle.java index ed4e6cb080..216add1b23 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/HighlightSuggestOracle.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/HighlightSuggestOracle.java @@ -45,7 +45,7 @@ public abstract class HighlightSuggestOracle extends SuggestOracle { final Response response) { final String qpat = getQueryPattern(request.getQuery()); final boolean html = isHTML(); - final ArrayList r = new ArrayList(); + final ArrayList r = new ArrayList<>(); for (final Suggestion s : response.getSuggestions()) { r.add(new BoldSuggestion(qpat, s, html)); } diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleEvent.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleEvent.java index 80a940a20b..74218b4bfc 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleEvent.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleEvent.java @@ -22,7 +22,7 @@ public class DialogVisibleEvent extends GwtEvent { public static Type getType() { if (TYPE == null) { - TYPE = new Type(); + TYPE = new Type<>(); } return TYPE; } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/MessageOfTheDayBar.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/MessageOfTheDayBar.java index fa569b8684..b3d8c238e2 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/MessageOfTheDayBar.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/MessageOfTheDayBar.java @@ -74,7 +74,7 @@ class MessageOfTheDayBar extends Composite { } private static List filter(List in) { - List show = new ArrayList(); + List show = new ArrayList<>(); for (HostPageData.Message m : in) { if (Cookies.getCookie(cookieName(m)) == null) { show.add(m); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/PermissionEditor.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/PermissionEditor.java index efb2fb405d..b3d856458f 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/PermissionEditor.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/PermissionEditor.java @@ -124,8 +124,8 @@ public class PermissionEditor extends Composite implements Editor, PermissionNameRenderer nameRenderer = new PermissionNameRenderer(projectAccess.getCapabilities()); - normalName = new ValueLabel(nameRenderer); - deletedName = new ValueLabel(nameRenderer); + normalName = new ValueLabel<>(nameRenderer); + deletedName = new ValueLabel<>(nameRenderer); initWidget(uiBinder.createAndBindUi(this)); groupToAdd.setProject(projectName); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/PermissionRuleEditor.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/PermissionRuleEditor.java index 07862f46be..9e719ead68 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/PermissionRuleEditor.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/PermissionRuleEditor.java @@ -101,7 +101,7 @@ public class PermissionRuleEditor extends Composite implements Permission permission, PermissionRange.WithDefaults validRange) { this.groupInfo = groupInfo; - action = new ValueListBox(actionRenderer); + action = new ValueListBox<>(actionRenderer); if (validRange != null && 10 < validRange.getRangeSize()) { min = new RangeBox.Box(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/RangeBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/RangeBox.java index bf04b07632..088899e882 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/RangeBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/RangeBox.java @@ -49,7 +49,7 @@ abstract class RangeBox extends Composite implements final ValueListBox list; List() { - list = new ValueListBox(rangeRenderer); + list = new ValueListBox<>(rangeRenderer); initWidget(list); } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java index 9d9078db42..aa01ef2a11 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java @@ -300,7 +300,7 @@ public class ChangeScreen extends Screen CallbackGroup cbs1 = new CallbackGroup(); final CallbackGroup cbs2 = new CallbackGroup(); final PatchSet.Id psId = event.getValue().getCurrentPatchSet().getId(); - final Map patches = new HashMap(); + final Map patches = new HashMap<>(); String revId = event.getValue().getCurrentPatchSetDetail().getInfo().getRevId(); @@ -330,7 +330,7 @@ public class ChangeScreen extends Screen private void dependsOn(RelatedChanges.RelatedInfo info) { ChangeAndCommit self = null; - Map m = new HashMap(); + Map m = new HashMap<>(); for (int i = 0; i < info.changes().length(); i++) { ChangeAndCommit c = info.changes().get(i); if (changeId.equals(c.legacy_id())) { @@ -342,7 +342,7 @@ public class ChangeScreen extends Screen } if (self != null && self.commit() != null && self.commit().parents() != null) { - List d = new ArrayList(); + List d = new ArrayList<>(); for (CommitInfo p : Natives.asList(self.commit().parents())) { ChangeAndCommit pc = m.get(p.commit()); if (pc != null && pc.has_change_number()) { @@ -356,12 +356,12 @@ public class ChangeScreen extends Screen } private void neededBy(RelatedChanges.RelatedInfo info) { - Set mine = new HashSet(); + Set mine = new HashSet<>(); for (PatchSet ps : event.getValue().getPatchSets()) { mine.add(ps.getRevision().get()); } - List n = new ArrayList(); + List n = new ArrayList<>(); for (int i = 0; i < info.changes().length(); i++) { ChangeAndCommit c = info.changes().get(i); if (c.has_change_number() @@ -418,7 +418,7 @@ public class ChangeScreen extends Screen } public void onFailure(Throwable caught) {} })); - final Set withDrafts = new HashSet(); + final Set withDrafts = new HashSet<>(); event.getValue().setPatchSetsWithDraftComments(withDrafts); for (PatchSet ps : event.getValue().getPatchSets()) { if (!ps.getId().equals(psId)) { @@ -478,7 +478,7 @@ public class ChangeScreen extends Screen public void onSuccess(NativeMap result) { JsArray fileInfos = result.values(); FileInfo.sortFileInfoByPath(fileInfos); - List list = new ArrayList(fileInfos.length()); + List list = new ArrayList<>(fileInfos.length()); for (FileInfo f : Natives.asList(fileInfos)) { Patch p = patches.get(f.path()); if (p == null) { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java index 3a65d20bb9..571e74286a 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java @@ -59,7 +59,7 @@ public class ChangeTable extends NavigationTable { keysAction.add(new StarKeyCommand(0, 's', Util.C.changeTableStar())); } - sections = new ArrayList

(); + sections = new ArrayList<>(); table.setText(0, C_STAR, ""); table.setText(0, C_SUBJECT, Util.C.changeTableColumnSubject()); table.setText(0, C_OWNER, Util.C.changeTableColumnOwner()); @@ -308,7 +308,7 @@ public class ChangeTable extends NavigationTable { parent.insertNoneRow(dataBegin); } } else { - Set cids = new HashSet(); + Set cids = new HashSet<>(); if (!hadData) { parent.removeRow(dataBegin); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java index 31685e4f63..b7a0ec8a22 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java @@ -76,7 +76,7 @@ class PatchSetComplexDisclosurePanel extends ComplexDisclosurePanel private Grid infoTable; private Panel actionsPanel; private PatchTable patchTable; - private final Set registeredClickHandler = new HashSet(); + private final Set registeredClickHandler = new HashSet<>(); private PatchSet.Id diffBaseId; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java index 480518541f..01c8fdb661 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java @@ -44,7 +44,7 @@ import java.util.Map; */ public class PatchSetsBlock extends Composite { private final Map patchSetPanels = - new HashMap(); + new HashMap<>(); private final FlowPanel body; private HandlerRegistration regNavigation; @@ -84,7 +84,7 @@ public class PatchSetsBlock extends Composite { } } - patchSetPanelsList = new ArrayList(); + patchSetPanelsList = new ArrayList<>(); for (final PatchSet ps : patchSets) { final PatchSetComplexDisclosurePanel p = diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchTable.java index b89d1cc5b2..425309dfa4 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchTable.java @@ -105,7 +105,7 @@ public class PatchTable extends Composite { private Map patchMap() { if (patchMap == null) { - patchMap = new HashMap(); + patchMap = new HashMap<>(); for (int i = 0; i < patchList.size(); i++) { patchMap.put(patchList.get(i).getKey(), i); } @@ -154,7 +154,7 @@ public class PatchTable extends Composite { myTable.addClickHandler(clickHandler); } else { if (clickHandlers == null) { - clickHandlers = new ArrayList(2); + clickHandlers = new ArrayList<>(2); } clickHandlers.add(clickHandler); } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java index 10b7ac7b09..f718b5d4b7 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java @@ -97,7 +97,7 @@ public class PublishCommentScreen extends AccountScreen implements super.onInitUI(); addStyleName(Gerrit.RESOURCES.css().publishCommentsScreen()); - approvalButtons = new ArrayList(); + approvalButtons = new ArrayList<>(); descBlock = new ChangeDescriptionBlock(null); add(descBlock); @@ -289,7 +289,7 @@ public class PublishCommentScreen extends AccountScreen implements if (nativeValues == null || nativeValues.length() == 0) { return; } - List values = new ArrayList(nativeValues.length()); + List values = new ArrayList<>(nativeValues.length()); for (int i = 0; i < nativeValues.length(); i++) { values.add(nativeValues.get(i)); } @@ -350,7 +350,7 @@ public class PublishCommentScreen extends AccountScreen implements } draftsPanel.clear(); - commentEditors = new ArrayList(); + commentEditors = new ArrayList<>(); if (!drafts.isEmpty()) { draftsPanel.add(new SmallHeading(Util.C.headingPatchComments())); @@ -468,8 +468,8 @@ public class PublishCommentScreen extends AccountScreen implements } private List draftList() { - List d = new ArrayList(); - List paths = new ArrayList(drafts.keySet()); + List d = new ArrayList<>(); + List paths = new ArrayList<>(drafts.keySet()); Collections.sort(paths); for (String path : paths) { JsArray comments = drafts.get(path); @@ -512,7 +512,7 @@ public class PublishCommentScreen extends AccountScreen implements SavedState(final PublishCommentScreen p) { patchSetId = p.patchSetId; message = p.message.getText(); - approvals = new HashMap(); + approvals = new HashMap<>(); for (final ValueRadioButton b : p.approvalButtons) { if (b.getValue()) { approvals.put(b.label.name(), b.value); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PreferencesBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PreferencesBox.java index 0ef5272dc5..586b057fc8 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PreferencesBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PreferencesBox.java @@ -429,8 +429,8 @@ class PreferencesBox extends Composite { private static final Map NAME_TO_MODE; private static final Map NORMALIZED_MODES; static { - NAME_TO_MODE = new TreeMap(); - NORMALIZED_MODES = new HashMap(); + NAME_TO_MODE = new TreeMap<>(); + NORMALIZED_MODES = new HashMap<>(); for (String type : ModeInjector.getKnownMimeTypes()) { String name = type; if (name.startsWith("text/x-")) { @@ -459,7 +459,7 @@ class PreferencesBox extends Composite { private void setMode(String modeType) { if (modeType != null && !modeType.isEmpty()) { if (NORMALIZED_MODES.containsKey(modeType)) { - modeType =NORMALIZED_MODES.get(modeType); + modeType = NORMALIZED_MODES.get(modeType); } for (int i = 0; i < mode.getItemCount(); i++) { if (mode.getValue(i).equals(modeType)) { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchSetSelectBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchSetSelectBox.java index e45ee1fd4e..083820b330 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchSetSelectBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchSetSelectBox.java @@ -90,7 +90,7 @@ public class PatchSetSelectBox extends Composite { this.idSideA = idSideA; this.idSideB = idSideB; this.idActive = (side == Side.A) ? idSideA : idSideB; - this.links = new HashMap(); + this.links = new HashMap<>(); linkPanel.clear(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/RestApi.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/RestApi.java index da620d811b..2bc4ac1e9b 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/RestApi.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/RestApi.java @@ -327,7 +327,7 @@ public class RestApi { private void send( Method method, AsyncCallback cb) { - HttpCallback httpCallback = new HttpCallback(background, cb); + HttpCallback httpCallback = new HttpCallback<>(background, cb); try { if (!background) { RpcStatus.INSTANCE.onRpcStart(); @@ -367,7 +367,7 @@ public class RestApi { private void sendJSON( Method method, JavaScriptObject content, AsyncCallback cb) { - HttpCallback httpCallback = new HttpCallback(background, cb); + HttpCallback httpCallback = new HttpCallback<>(background, cb); try { if (!background) { RpcStatus.INSTANCE.onRpcStart(); @@ -384,7 +384,7 @@ public class RestApi { private void sendRaw(Method method, String body, AsyncCallback cb) { - HttpCallback httpCallback = new HttpCallback(background, cb); + HttpCallback httpCallback = new HttpCallback<>(background, cb); try { if (!background) { RpcStatus.INSTANCE.onRpcStart(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CherryPickDialog.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CherryPickDialog.java index 1d5a74fbed..54c4c53466 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CherryPickDialog.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CherryPickDialog.java @@ -50,8 +50,7 @@ public abstract class CherryPickDialog extends ActionDialog { newBranch = new SuggestBox(new HighlightSuggestOracle() { @Override protected void onRequestSuggestions(Request request, Callback done) { - LinkedList suggestions = - new LinkedList(); + LinkedList suggestions = new LinkedList<>(); for (final BranchInfo b : branches) { if (b.ref().contains(request.getQuery())) { suggestions.add(new BranchSuggestion(b)); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ScreenLoadEvent.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ScreenLoadEvent.java index 562e53a5d8..45ba8084ac 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ScreenLoadEvent.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ScreenLoadEvent.java @@ -24,7 +24,7 @@ public class ScreenLoadEvent extends GwtEvent { this.screen = screen; } - public static final Type TYPE = new Type(); + public static final Type TYPE = new Type<>(); @Override protected void dispatch(ScreenLoadHandler handler) { diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/DirectChangeByCommit.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/DirectChangeByCommit.java index 402ea1b15e..11383ca036 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/DirectChangeByCommit.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/DirectChangeByCommit.java @@ -50,7 +50,7 @@ class DirectChangeByCommit extends HttpServlet { protected void doGet(final HttpServletRequest req, final HttpServletResponse rsp) throws IOException { String query = CharMatcher.is('/').trimTrailingFrom(req.getPathInfo()); - HashSet ids = new HashSet(); + HashSet ids = new HashSet<>(); try { ChangeQueryBuilder builder = queryBuilder.create(currentUser.get()); Predicate visibleToMe = builder.is_visible(); diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java index 28a91904b5..bbe6972611 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java @@ -152,7 +152,7 @@ class GerritConfigProvider implements Provider { reportBugUrl : "http://code.google.com/p/gerrit/issues/list"); config.setReportBugText(cfg.getString("gerrit", null, "reportBugText")); - final Set fields = new HashSet(); + final Set fields = new HashSet<>(); for (final Account.FieldName n : Account.FieldName.values()) { if (realm.allowsEdit(n)) { fields.add(n); diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GitOverHttpServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GitOverHttpServlet.java index 03d54e4d65..24c2afaeb3 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GitOverHttpServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GitOverHttpServlet.java @@ -356,7 +356,7 @@ public class GitOverHttpServlet extends GitServlet { if (isGet) { cache.put(cacheKey, Collections.unmodifiableSet( - new HashSet(rp.getAdvertisedObjects()))); + new HashSet<>(rp.getAdvertisedObjects()))); } } diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/ProjectDigestFilter.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/ProjectDigestFilter.java index 45e450430c..be222569a2 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/ProjectDigestFilter.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/ProjectDigestFilter.java @@ -231,7 +231,7 @@ class ProjectDigestFilter implements Filter { } private Map parseAuthorization(String auth) { - Map p = new HashMap(); + Map p = new HashMap<>(); int next = "Digest ".length(); while (next < auth.length()) { if (next < auth.length() && auth.charAt(next) == ',') { diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java index c2b0cc852d..f831ab5542 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java @@ -98,7 +98,7 @@ class GitWebServlet extends HttpServlet { this.projectControl = projectControl; this.anonymousUserProvider = anonymousUserProvider; this.gitwebCgi = gitWebConfig.getGitwebCGI(); - this.deniedActions = new HashSet(); + this.deniedActions = new HashSet<>(); final String url = gitWebConfig.getUrl(); if ((url != null) && (!url.equals("gitweb"))) { @@ -398,7 +398,7 @@ class GitWebServlet extends HttpServlet { } private static Map getParameters(HttpServletRequest req) { - final Map params = new HashMap(); + final Map params = new HashMap<>(); for (final String pair : req.getQueryString().split("[&;]")) { final int eq = pair.indexOf('='); if (0 < eq) { @@ -669,11 +669,11 @@ class GitWebServlet extends HttpServlet { private Map envMap; EnvList() { - envMap = new HashMap(); + envMap = new HashMap<>(); } EnvList(final EnvList l) { - envMap = new HashMap(l.envMap); + envMap = new HashMap<>(l.envMap); } /** Set a name/value pair, null values will be treated as an empty String */ diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServlet.java index ec96f0b1fe..0b453a0229 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServlet.java @@ -51,9 +51,9 @@ import javax.servlet.http.HttpServletResponse; final class GerritJsonServlet extends JsonServlet { private static final Logger log = LoggerFactory.getLogger(GerritJsonServlet.class); private static final ThreadLocal currentCall = - new ThreadLocal(); + new ThreadLocal<>(); private static final ThreadLocal currentMethod = - new ThreadLocal(); + new ThreadLocal<>(); private final Provider session; private final RemoteJsonService service; private final AuditService audit; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SuggestServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SuggestServiceImpl.java index f8d43a85ba..dcd181cf22 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SuggestServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SuggestServiceImpl.java @@ -137,8 +137,7 @@ class SuggestServiceImpl extends BaseServiceImplementation implements final int max = 10; final int n = limit <= 0 ? max : Math.min(limit, max); - final LinkedHashMap r = - new LinkedHashMap(); + LinkedHashMap r = new LinkedHashMap<>(); for (final Account p : db.accounts().suggestByFullName(a, b, n)) { addSuggestion(r, p, new AccountInfo(p), active, visibilityControl); } @@ -159,7 +158,7 @@ class SuggestServiceImpl extends BaseServiceImplementation implements } } } - return new ArrayList(r.values()); + return new ArrayList<>(r.values()); } private void addSuggestion(Map map, Account account, @@ -251,7 +250,7 @@ class SuggestServiceImpl extends BaseServiceImplementation implements final List suggestedAccounts = suggestAccount(db, query, Boolean.TRUE, limit, visibilityControl); final List reviewer = - new ArrayList(suggestedAccounts.size()); + new ArrayList<>(suggestedAccounts.size()); for (final AccountInfo a : suggestedAccounts) { reviewer.add(new ReviewerInfo(a)); } diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SystemInfoServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SystemInfoServiceImpl.java index 931605cbf8..56a6a507b9 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SystemInfoServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SystemInfoServiceImpl.java @@ -72,7 +72,7 @@ class SystemInfoServiceImpl implements SystemInfoService { } public void daemonHostKeys(final AsyncCallback> callback) { - final ArrayList r = new ArrayList(hostKeys.size()); + final ArrayList r = new ArrayList<>(hostKeys.size()); for (final HostKey hk : hostKeys) { String host = hk.getHost(); if (host.startsWith("*:")) { diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountServiceImpl.java index 90357ae87b..bdb0028d2a 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountServiceImpl.java @@ -113,8 +113,7 @@ class AccountServiceImpl extends BaseServiceImplementation implements final AsyncCallback> callback) { run(callback, new Action>() { public List run(ReviewDb db) throws OrmException { - final List r = - new ArrayList(); + List r = new ArrayList<>(); for (final AccountProjectWatch w : db.accountProjectWatches() .byAccount(getAccountId()).toList()) { diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/DeleteExternalIds.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/DeleteExternalIds.java index 12bc76107f..1d45c7d225 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/DeleteExternalIds.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/DeleteExternalIds.java @@ -63,7 +63,7 @@ class DeleteExternalIds extends Handler> { public Set call() throws OrmException { final Map have = have(); - List toDelete = new ArrayList(); + List toDelete = new ArrayList<>(); for (AccountExternalId.Key k : keys) { final AccountExternalId id = have.get(k); if (id != null && id.canDelete()) { @@ -86,7 +86,7 @@ class DeleteExternalIds extends Handler> { throws OrmException { Map r; - r = new HashMap(); + r = new HashMap<>(); for (AccountExternalId i : detailFactory.call()) { r.put(i.getKey(), i); } @@ -94,7 +94,7 @@ class DeleteExternalIds extends Handler> { } private Set toKeySet(List toDelete) { - Set r = new HashSet(); + Set r = new HashSet<>(); for (AccountExternalId i : toDelete) { r.add(i.getKey()); } diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/PatchSetDetailFactory.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/PatchSetDetailFactory.java index fce8637154..c4a8bb62bd 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/PatchSetDetailFactory.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/PatchSetDetailFactory.java @@ -138,7 +138,7 @@ class PatchSetDetailFactory extends Handler { } final List patches = list.toPatchList(patchSet.getId()); - final Map byKey = new HashMap(); + final Map byKey = new HashMap<>(); for (final Patch p : patches) { byKey.put(p.getKey(), p); } diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAccessFactory.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAccessFactory.java index ee4439f49b..f0f93903c9 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAccessFactory.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAccessFactory.java @@ -114,8 +114,8 @@ class ProjectAccessFactory extends Handler { } final RefControl metaConfigControl = pc.controlForRef(RefNames.REFS_CONFIG); - List local = new ArrayList(); - Set ownerOf = new HashSet(); + List local = new ArrayList<>(); + Set ownerOf = new HashSet<>(); Map visibleGroups = new HashMap<>(); for (AccessSection section : config.getAccessSections()) { diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAccessHandler.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAccessHandler.java index b2b8bb346c..52283b2fe8 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAccessHandler.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAccessHandler.java @@ -185,7 +185,7 @@ public abstract class ProjectAccessHandler extends Handler { } private static Set scanSectionNames(ProjectConfig config) { - Set names = new HashSet(); + Set names = new HashSet<>(); for (AccessSection section : config.getAccessSections()) { names.add(section.getName()); } diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ReviewProjectAccess.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ReviewProjectAccess.java index 6537a6b529..51aa2c0cce 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ReviewProjectAccess.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ReviewProjectAccess.java @@ -182,7 +182,7 @@ public class ReviewProjectAccess extends ProjectAccessHandler { private void insertAncestors(PatchSet.Id id, RevCommit src) throws OrmException { final int cnt = src.getParentCount(); - List toInsert = new ArrayList(cnt); + List toInsert = new ArrayList<>(cnt); for (int p = 0; p < cnt; p++) { PatchSetAncestor a; diff --git a/gerrit-launcher/src/main/java/com/google/gerrit/launcher/GerritLauncher.java b/gerrit-launcher/src/main/java/com/google/gerrit/launcher/GerritLauncher.java index 6c39743e3e..474b284843 100644 --- a/gerrit-launcher/src/main/java/com/google/gerrit/launcher/GerritLauncher.java +++ b/gerrit-launcher/src/main/java/com/google/gerrit/launcher/GerritLauncher.java @@ -192,7 +192,7 @@ public final class GerritLauncher { throw e; } - final SortedMap jars = new TreeMap(); + final SortedMap jars = new TreeMap<>(); try { final ZipFile zf = new ZipFile(path); try { @@ -220,7 +220,7 @@ public final class GerritLauncher { // The extension API needs to be its own ClassLoader, along // with a few of its dependencies. Try to construct this first. - List extapi = new ArrayList(); + List extapi = new ArrayList<>(); move(jars, "gerrit-extension-api-", extapi); move(jars, "guice-", extapi); move(jars, "javax.inject-1.jar", extapi); @@ -592,7 +592,7 @@ public final class GerritLauncher { private static ClassLoader useDevClasspath() throws MalformedURLException, FileNotFoundException { File out = getDeveloperBuckOut(); - List dirs = new ArrayList(); + List dirs = new ArrayList<>(); dirs.add(new File(new File(out, "eclipse"), "classes").toURI().toURL()); ClassLoader cl = GerritLauncher.class.getClassLoader(); for (URL u : ((URLClassLoader) cl).getURLs()) { diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/BaseInit.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/BaseInit.java index 313408ed4e..bacdd2d9d8 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/BaseInit.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/BaseInit.java @@ -185,7 +185,7 @@ public class BaseInit extends SiteProgram { private SiteInit createSiteInit() { final ConsoleUI ui = getConsoleUI(); final File sitePath = getSitePath(); - final List m = new ArrayList(); + final List m = new ArrayList<>(); m.add(new InitModule(standalone, initDb)); m.add(new AbstractModule() { @@ -250,7 +250,7 @@ public class BaseInit extends SiteProgram { } void upgradeSchema() throws OrmException { - final List pruneList = new ArrayList(); + final List pruneList = new ArrayList<>(); schemaUpdater.update(new UpdateUI() { @Override public void message(String msg) { @@ -316,7 +316,7 @@ public class BaseInit extends SiteProgram { } private Injector createSysInjector(final SiteInit init) { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); modules.add(new AbstractModule() { @Override protected void configure() { diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Daemon.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Daemon.java index 9d10e6684b..1776a3949c 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Daemon.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Daemon.java @@ -303,13 +303,13 @@ public class Daemon extends SiteProgram { } private Injector createCfgInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); modules.add(new AuthConfigModule()); return dbInjector.createChildInjector(modules); } private Injector createSysInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); modules.add(SchemaVersionCheck.module()); modules.add(new LogFileCompressor.Module()); modules.add(new WorkQueue.Module()); @@ -376,7 +376,7 @@ public class Daemon extends SiteProgram { } private Injector createSshInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); modules.add(sysInjector.getInstance(SshModule.class)); if (!test) { modules.add(new SshHostKeyModule()); @@ -401,7 +401,7 @@ public class Daemon extends SiteProgram { } private Injector createWebInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); if (sshd) { modules.add(new ProjectQoSFilter.Module()); } @@ -429,7 +429,7 @@ public class Daemon extends SiteProgram { } private Injector createHttpdInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); modules.add(new JettyModule(new JettyEnv(webInjector))); return webInjector.createChildInjector(modules); } diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/LocalUsernamesToLowerCase.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/LocalUsernamesToLowerCase.java index 323d7f28f3..d208a3cf26 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/LocalUsernamesToLowerCase.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/LocalUsernamesToLowerCase.java @@ -70,7 +70,7 @@ public class LocalUsernamesToLowerCase extends SiteProgram { db.close(); } - final List workers = new ArrayList(threads); + final List workers = new ArrayList<>(threads); for (int tid = 0; tid < threads; tid++) { Worker t = new Worker(); t.start(); diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/PrologShell.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/PrologShell.java index 4c66f0bed3..fa434a6ea7 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/PrologShell.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/PrologShell.java @@ -33,7 +33,7 @@ import java.util.List; public class PrologShell extends AbstractProgram { @Option(name = "-s", metaVar = "FILE.pl", usage = "file to load") - private List fileName = new ArrayList(); + private List fileName = new ArrayList<>(); @Override public int run() { diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Reindex.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Reindex.java index fb84cfa428..6d93dcd8a1 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Reindex.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Reindex.java @@ -252,7 +252,7 @@ public class Reindex extends SiteProgram { Key.get(new TypeLiteral>() {})); final List dbs = Collections.synchronizedList( Lists. newArrayListWithCapacity(threads + 1)); - final ThreadLocal localDb = new ThreadLocal(); + final ThreadLocal localDb = new ThreadLocal<>(); bind(ReviewDb.class).toProvider(new Provider() { @Override diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Rulec.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Rulec.java index cabdc6432e..17a54d4798 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Rulec.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Rulec.java @@ -47,7 +47,7 @@ public class Rulec extends SiteProgram { private boolean quiet; @Argument(index = 0, multiValued = true, metaVar = "PROJECT", usage = "project to compile rules for") - private List projectNames = new ArrayList(); + private List projectNames = new ArrayList<>(); private Injector dbInjector; @@ -71,7 +71,7 @@ public class Rulec extends SiteProgram { } }).injectMembers(this); - LinkedHashSet names = new LinkedHashSet(); + LinkedHashSet names = new LinkedHashSet<>(); for (String name : projectNames) { names.add(new Project.NameKey(name)); } diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java index 60b51449ca..31d75f1851 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java @@ -371,7 +371,7 @@ public class JettyServer { private Handler makeContext(final JettyEnv env, final Config cfg) throws MalformedURLException, IOException { - final Set paths = new HashSet(); + final Set paths = new HashSet<>(); for (URI u : listenURLs(cfg)) { String p = u.getPath(); if (p == null || p.isEmpty()) { @@ -383,7 +383,7 @@ public class JettyServer { paths.add(p); } - final List all = new ArrayList(); + final List all = new ArrayList<>(); for (String path : paths) { all.add(makeContext(path, env, cfg)); } diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitPluginStepsLoader.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitPluginStepsLoader.java index 5584cf310c..1b8600ddbb 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitPluginStepsLoader.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitPluginStepsLoader.java @@ -54,7 +54,7 @@ public class InitPluginStepsLoader { public Collection getInitSteps() { List jars = scanJarsInPluginsDirectory(); - ArrayList pluginsInitSteps = new ArrayList(); + ArrayList pluginsInitSteps = new ArrayList<>(); for (File jar : jars) { InitStep init = loadInitStep(jar); diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/Section.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/Section.java index bbb1d9f0f9..5cce4a24a8 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/Section.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/Section.java @@ -55,7 +55,7 @@ public class Section { } public void set(final String name, final String value) { - final ArrayList all = new ArrayList(); + final ArrayList all = new ArrayList<>(); all.addAll(Arrays.asList(flags.cfg.getStringList(section, subsection, name))); if (value != null) { diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/SitePathInitializer.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/SitePathInitializer.java index 85e33e6fc8..892a8a5a95 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/SitePathInitializer.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/SitePathInitializer.java @@ -125,7 +125,7 @@ public class SitePathInitializer { } private static List stepsOf(final Injector injector) { - final ArrayList r = new ArrayList(); + final ArrayList r = new ArrayList<>(); for (Binding b : all(injector)) { r.add(b.getProvider().get()); } diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/shell/JythonShell.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/shell/JythonShell.java index 38f08c18ff..5b537ae297 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/shell/JythonShell.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/shell/JythonShell.java @@ -85,7 +85,7 @@ public class JythonShell { } catch (IllegalAccessException e) { throw noInterpreter(e); } - injectedVariables = new ArrayList(); + injectedVariables = new ArrayList<>(); set("Shell", this); } diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/RuntimeShutdown.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/RuntimeShutdown.java index c00ad7fefc..40aaa75c70 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/RuntimeShutdown.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/RuntimeShutdown.java @@ -46,7 +46,7 @@ public class RuntimeShutdown { private static final Logger log = LoggerFactory.getLogger(ShutdownCallback.class); - private final List tasks = new ArrayList(); + private final List tasks = new ArrayList<>(); private boolean shutdownStarted; private boolean shutdownComplete; diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/SiteProgram.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/SiteProgram.java index daef56297d..3c605108b9 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/SiteProgram.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/SiteProgram.java @@ -90,7 +90,7 @@ public abstract class SiteProgram extends AbstractProgram { /** @return provides database connectivity and site path. */ protected Injector createDbInjector(final DataSourceProvider.Context context) { final File sitePath = getSitePath(); - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); Module sitePathModule = new AbstractModule() { @Override diff --git a/gerrit-plugin-gwt-archetype/src/main/resources/archetype-resources/src/main/java/HelloMenu.java b/gerrit-plugin-gwt-archetype/src/main/resources/archetype-resources/src/main/java/HelloMenu.java index 0baa04443e..f3c8dea0d6 100644 --- a/gerrit-plugin-gwt-archetype/src/main/resources/archetype-resources/src/main/java/HelloMenu.java +++ b/gerrit-plugin-gwt-archetype/src/main/resources/archetype-resources/src/main/java/HelloMenu.java @@ -27,7 +27,7 @@ public class HelloMenu implements TopMenu { @Inject public HelloMenu(@PluginName String pluginName) { - menuEntries = new ArrayList(); + menuEntries = new ArrayList<>(); menuEntries.add(new MenuEntry("Hello", Collections .singletonList(new MenuItem("Hello Screen", "#/x/" + pluginName, "")))); } diff --git a/gerrit-prettify/src/main/java/com/google/gerrit/prettify/client/PrettyFormatter.java b/gerrit-prettify/src/main/java/com/google/gerrit/prettify/client/PrettyFormatter.java index d4aef2a125..ed42f10f0e 100644 --- a/gerrit-prettify/src/main/java/com/google/gerrit/prettify/client/PrettyFormatter.java +++ b/gerrit-prettify/src/main/java/com/google/gerrit/prettify/client/PrettyFormatter.java @@ -125,7 +125,7 @@ public abstract class PrettyFormatter implements SparseHtmlFile { public void format(SparseFileContent src) { content = new SparseFileContent(); content.setSize(src.size()); - trailingEdits = new HashSet(); + trailingEdits = new HashSet<>(); String html = toHTML(src); @@ -365,7 +365,7 @@ public abstract class PrettyFormatter implements SparseHtmlFile { // in the source. That simplifies our loop below because we'll never // run off the end of the edit list. // - List edits = new ArrayList(this.edits.size() + 1); + List edits = new ArrayList<>(this.edits.size() + 1); edits.addAll(this.edits); edits.add(new Edit(src.size(), src.size())); diff --git a/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/SparseFileContent.java b/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/SparseFileContent.java index aa08af075b..b6e3bf95a2 100644 --- a/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/SparseFileContent.java +++ b/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/SparseFileContent.java @@ -29,7 +29,7 @@ public class SparseFileContent { private transient int currentRangeIdx; public SparseFileContent() { - ranges = new ArrayList(); + ranges = new ArrayList<>(); } public int size() { @@ -222,7 +222,7 @@ public class SparseFileContent { public SparseFileContent apply(SparseFileContent a, List edits) { EditList list = new EditList(edits, size, a.size(), size); - ArrayList lines = new ArrayList(size); + ArrayList lines = new ArrayList<>(size); for (final EditList.Hunk hunk : list.getHunks()) { while (hunk.next()) { if (hunk.isContextLine()) { @@ -277,7 +277,7 @@ public class SparseFileContent { private Range(final int b) { base = b; - lines = new ArrayList(); + lines = new ArrayList<>(); } protected Range() { diff --git a/gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java b/gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java index 17940c0806..09c566fc5b 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java +++ b/gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java @@ -156,7 +156,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { /** Listeners to receive changes as they happen (limited by visibility * of holder's user). */ private final Map listeners = - new ConcurrentHashMap(); + new ConcurrentHashMap<>(); /** Listeners to receive all changes as they happen. */ private final DynamicSet unrestrictedListeners; @@ -320,7 +320,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { public HookResult doRefUpdateHook(final Project project, final String refname, final Account uploader, final ObjectId oldId, final ObjectId newId) { - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--project", project.getName()); addArg(args, "--refname", refname); addArg(args, "--uploader", getDisplayName(uploader)); @@ -355,7 +355,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { event.uploader = eventFactory.asAccountAttribute(uploader.getAccount()); fireEvent(change, event, db); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--change", event.change.id); addArg(args, "--is-draft", patchSet.isDraft() ? "true" : "false"); addArg(args, "--change-url", event.change.url); @@ -379,7 +379,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { event.uploader = eventFactory.asAccountAttribute(uploader.getAccount()); fireEvent(change, event, db); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--change", event.change.id); addArg(args, "--change-url", event.change.url); addArg(args, "--project", event.change.project); @@ -413,7 +413,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { fireEvent(change, event, db); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--change", event.change.id); addArg(args, "--is-draft", patchSet.isDraft() ? "true" : "false"); addArg(args, "--change-url", event.change.url); @@ -442,7 +442,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { event.patchSet = eventFactory.asPatchSetAttribute(patchSet); fireEvent(change, event, db); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--change", event.change.id); addArg(args, "--change-url", event.change.url); addArg(args, "--project", event.change.project); @@ -465,7 +465,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { event.reason = reason; fireEvent(change, event, db); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--change", event.change.id); addArg(args, "--change-url", event.change.url); addArg(args, "--project", event.change.project); @@ -489,7 +489,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { event.reason = reason; fireEvent(change, event, db); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--change", event.change.id); addArg(args, "--change-url", event.change.url); addArg(args, "--project", event.change.project); @@ -513,7 +513,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { event.reason = reason; fireEvent(change, event, db); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--change", event.change.id); addArg(args, "--change-url", event.change.url); addArg(args, "--project", event.change.project); @@ -539,7 +539,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { event.refUpdate = eventFactory.asRefUpdateAttribute(oldId, newId, refName); fireEvent(refName, event); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--oldrev", event.refUpdate.oldRev); addArg(args, "--newrev", event.refUpdate.newRev); addArg(args, "--refname", event.refUpdate.refName); @@ -560,7 +560,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { event.reviewer = eventFactory.asAccountAttribute(account); fireEvent(change, event, db); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--change", event.change.id); addArg(args, "--change-url", event.change.url); addArg(args, "--project", event.change.project); @@ -580,7 +580,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { event.oldTopic = oldTopic; fireEvent(change, event, db); - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--change", event.change.id); addArg(args, "--project", event.change.project); addArg(args, "--branch", event.change.branch); @@ -593,7 +593,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { public void doClaSignupHook(Account account, ContributorAgreement cla) { if (account != null) { - final List args = new ArrayList(); + final List args = new ArrayList<>(); addArg(args, "--submitter", getDisplayName(account)); addArg(args, "--user-id", account.getId().toString()); addArg(args, "--cla-name", cla.getName()); @@ -721,7 +721,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { } SyncHookTask syncHook = new SyncHookTask(project, hook, args); - FutureTask task = new FutureTask(syncHook); + FutureTask task = new FutureTask<>(syncHook); syncHookThreadPool.execute(task); @@ -781,7 +781,7 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener { HookResult result = null; try { - final List argv = new ArrayList(1 + args.size()); + final List argv = new ArrayList<>(1 + args.size()); argv.add(hook.getAbsolutePath()); argv.addAll(args); diff --git a/gerrit-server/src/main/java/com/google/gerrit/rules/PrologCompiler.java b/gerrit-server/src/main/java/com/google/gerrit/rules/PrologCompiler.java index 8202ac25ea..7f6bff4d57 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/rules/PrologCompiler.java +++ b/gerrit-server/src/main/java/com/google/gerrit/rules/PrologCompiler.java @@ -154,13 +154,13 @@ public class PrologCompiler implements Callable { } DiagnosticCollector diagnostics = - new DiagnosticCollector(); + new DiagnosticCollector<>(); StandardJavaFileManager fileManager = compiler.getStandardFileManager(diagnostics, null, null); try { Iterable compilationUnits = fileManager .getJavaFileObjectsFromFiles(getAllFiles(tempDir, ".java")); - ArrayList options = new ArrayList(); + ArrayList options = new ArrayList<>(); String classpath = getMyClasspath(); if (classpath != null) { options.add("-classpath"); @@ -270,7 +270,7 @@ public class PrologCompiler implements Callable { } private List getAllFiles(File dir, String extension) { - ArrayList fileList = new ArrayList(); + ArrayList fileList = new ArrayList<>(); getAllFiles(dir, extension, fileList); return fileList; } @@ -287,7 +287,7 @@ public class PrologCompiler implements Callable { } private List getRelativePaths(File dir, String extension) { - ArrayList pathList = new ArrayList(); + ArrayList pathList = new ArrayList<>(); getRelativePaths(dir, extension, "", pathList); return pathList; } diff --git a/gerrit-server/src/main/java/com/google/gerrit/rules/PrologEnvironment.java b/gerrit-server/src/main/java/com/google/gerrit/rules/PrologEnvironment.java index 234a0e7be3..029a5d7dfb 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/rules/PrologEnvironment.java +++ b/gerrit-server/src/main/java/com/google/gerrit/rules/PrologEnvironment.java @@ -73,8 +73,8 @@ public class PrologEnvironment extends BufferingPrologControl { setMaxArity(MAX_ARITY); setEnabled(EnumSet.allOf(Prolog.Feature.class), false); args = a; - storedValues = new HashMap, Object>(); - cleanup = new LinkedList(); + storedValues = new HashMap<>(); + cleanup = new LinkedList<>(); } public Args getArgs() { diff --git a/gerrit-server/src/main/java/com/google/gerrit/rules/RulesCache.java b/gerrit-server/src/main/java/com/google/gerrit/rules/RulesCache.java index 4a3cd9a7ad..e677b53dd9 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/rules/RulesCache.java +++ b/gerrit-server/src/main/java/com/google/gerrit/rules/RulesCache.java @@ -80,11 +80,10 @@ public class RulesCache { private static final List PACKAGE_LIST = ImmutableList.of( Prolog.BUILTIN, "gerrit"); - private final Map machineCache = - new HashMap(); + private final Map machineCache = new HashMap<>(); private final ReferenceQueue dead = - new ReferenceQueue(); + new ReferenceQueue<>(); private static final class MachineRef extends WeakReference { final ObjectId key; diff --git a/gerrit-server/src/main/java/com/google/gerrit/rules/StoredValue.java b/gerrit-server/src/main/java/com/google/gerrit/rules/StoredValue.java index e17346baba..132360b890 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/rules/StoredValue.java +++ b/gerrit-server/src/main/java/com/google/gerrit/rules/StoredValue.java @@ -25,12 +25,12 @@ import com.googlecode.prolog_cafe.lang.SystemException; public class StoredValue { /** Construct a new unique key that does not match any other key. */ public static StoredValue create() { - return new StoredValue(); + return new StoredValue<>(); } /** Construct a key based on a Java Class object, useful for singletons. */ public static StoredValue create(Class clazz) { - return new StoredValue(clazz); + return new StoredValue<>(clazz); } private final Object key; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java index 939be28583..68a62a19f6 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java @@ -147,7 +147,7 @@ public class ChangeUtil { public static void insertAncestors(ReviewDb db, PatchSet.Id id, RevCommit src) throws OrmException { int cnt = src.getParentCount(); - List toInsert = new ArrayList(cnt); + List toInsert = new ArrayList<>(cnt); for (int p = 0; p < cnt; p++) { PatchSetAncestor a = new PatchSetAncestor(new PatchSetAncestor.Id(id, p + 1)); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/MimeUtilFileTypeRegistry.java b/gerrit-server/src/main/java/com/google/gerrit/server/MimeUtilFileTypeRegistry.java index ff46b00baf..5263c6b38d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/MimeUtilFileTypeRegistry.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/MimeUtilFileTypeRegistry.java @@ -94,7 +94,7 @@ public class MimeUtilFileTypeRegistry implements FileTypeRegistry { @SuppressWarnings("unchecked") public MimeType getMimeType(final String path, final byte[] content) { - Set mimeTypes = new HashSet(); + Set mimeTypes = new HashSet<>(); if (content != null && content.length > 0) { try { mimeTypes.addAll(mimeUtil.getMimeTypes(content)); @@ -112,7 +112,7 @@ public class MimeUtilFileTypeRegistry implements FileTypeRegistry { return MimeUtil2.UNKNOWN_MIME_TYPE; } - final List types = new ArrayList(mimeTypes); + final List types = new ArrayList<>(mimeTypes); Collections.sort(types, new Comparator() { @Override public int compare(MimeType a, MimeType b) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/RequestCleanup.java b/gerrit-server/src/main/java/com/google/gerrit/server/RequestCleanup.java index d836646bc9..b8c08881db 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/RequestCleanup.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/RequestCleanup.java @@ -32,7 +32,7 @@ public class RequestCleanup implements Runnable { private static final Logger log = LoggerFactory.getLogger(RequestCleanup.class); - private final List cleanup = new LinkedList(); + private final List cleanup = new LinkedList<>(); private boolean ran; /** Register a task to be completed after the request ends. */ diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/access/ListAccess.java b/gerrit-server/src/main/java/com/google/gerrit/server/access/ListAccess.java index 8ff4e03634..5d651aedb6 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/access/ListAccess.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/access/ListAccess.java @@ -157,8 +157,7 @@ public class ListAccess implements RestReadView { pc.controlForRef(RefNames.REFS_CONFIG); local = Maps.newHashMap(); ownerOf = Sets.newHashSet(); - Map visibleGroups = - new HashMap(); + Map visibleGroups = new HashMap<>(); for (AccessSection section : config.getAccessSections()) { String name = section.getName(); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountCacheImpl.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountCacheImpl.java index 65b166b92c..a521840bfd 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountCacheImpl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountCacheImpl.java @@ -163,7 +163,7 @@ public class AccountCacheImpl implements AccountCache { Collections.unmodifiableCollection(db.accountExternalIds().byAccount( who).toList()); - Set internalGroups = new HashSet(); + Set internalGroups = new HashSet<>(); for (AccountGroupMember g : db.accountGroupMembers().byAccount(who)) { final AccountGroup.Id groupId = g.getAccountGroupId(); final AccountGroup group = groupCache.get(groupId); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountInfoCacheFactory.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountInfoCacheFactory.java index e3cf02366a..32781f0c95 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountInfoCacheFactory.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountInfoCacheFactory.java @@ -36,7 +36,7 @@ public class AccountInfoCacheFactory { @Inject AccountInfoCacheFactory(final AccountCache accountCache) { this.accountCache = accountCache; - this.out = new HashMap(); + this.out = new HashMap<>(); } /** @@ -66,7 +66,7 @@ public class AccountInfoCacheFactory { * Create an AccountInfoCache with the currently loaded Account entities. * */ public AccountInfoCache create() { - final List r = new ArrayList(out.size()); + final List r = new ArrayList<>(out.size()); for (final Account a : out.values()) { r.add(new AccountInfo(a)); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountManager.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountManager.java index f068812022..3ba307607d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountManager.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountManager.java @@ -200,8 +200,8 @@ public class AccountManager { if (authConfig.isAllowGoogleAccountUpgrade() && who.isScheme(OpenIdUrls.URL_GOOGLE + "?") && who.getEmailAddress() != null) { - final List openId = new ArrayList(); - final List v1 = new ArrayList(); + final List openId = new ArrayList<>(); + final List v1 = new ArrayList<>(); for (final AccountExternalId extId : db.accountExternalIds() .byEmailAddress(who.getEmailAddress())) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountResolver.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountResolver.java index 383ed0512b..cc66294288 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountResolver.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountResolver.java @@ -179,7 +179,7 @@ public class AccountResolver { // At this point we have no clue. Just perform a whole bunch of suggestions // and pray we come up with a reasonable result list. // - Set result = new HashSet(); + Set result = new HashSet<>(); String a = nameOrEmail; String b = nameOrEmail + "\u9fa5"; for (Account act : schema.get().accounts().suggestByFullName(a, b, 10)) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountState.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountState.java index 488370ee89..66607e26b0 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountState.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountState.java @@ -74,7 +74,7 @@ public class AccountState { * validated by Gerrit directly. */ public Set getEmailAddresses() { - final Set emails = new HashSet(); + final Set emails = new HashSet<>(); for (final AccountExternalId e : externalIds) { if (e.getEmailAddress() != null && !e.getEmailAddress().isEmpty()) { emails.add(e.getEmailAddress()); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityCollection.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityCollection.java index 0247dbe3a3..f60c794400 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityCollection.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityCollection.java @@ -43,8 +43,7 @@ public class CapabilityCollection { section = new AccessSection(AccessSection.GLOBAL_CAPABILITIES); } - Map> tmp = - new HashMap>(); + Map> tmp = new HashMap<>(); for (Permission permission : section.getPermissions()) { for (PermissionRule rule : permission.getRules()) { if (!permission.getName().equals(GlobalCapability.EMAIL_REVIEWERS) @@ -54,7 +53,7 @@ public class CapabilityCollection { List r = tmp.get(permission.getName()); if (r == null) { - r = new ArrayList(2); + r = new ArrayList<>(2); tmp.put(permission.getName(), r); } r.add(rule); @@ -62,8 +61,7 @@ public class CapabilityCollection { } configureDefaults(tmp, section); - Map> res = - new HashMap>(); + Map> res = new HashMap<>(); for (Map.Entry> e : tmp.entrySet()) { List rules = e.getValue(); if (rules.size() == 1) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityControl.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityControl.java index aad22eb0b7..8ccb7312ca 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityControl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/CapabilityControl.java @@ -54,7 +54,7 @@ public class CapabilityControl { CapabilityControl(ProjectCache projectCache, @Assisted CurrentUser currentUser) { capabilities = projectCache.getAllProjects().getCapabilityCollection(); user = currentUser; - effective = new HashMap>(); + effective = new HashMap<>(); } /** Identity of the user the control will compute for. */ @@ -268,7 +268,7 @@ public class CapabilityControl { return rules; } - List mine = new ArrayList(rules.size()); + List mine = new ArrayList<>(rules.size()); for (PermissionRule rule : rules) { if (match(groups, rule)) { mine.add(rule); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/ChangeUserName.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/ChangeUserName.java index 1210906c6d..6dd51e1a0e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/ChangeUserName.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/ChangeUserName.java @@ -141,7 +141,7 @@ public class ChangeUserName implements Callable { } private Collection old() throws OrmException { - final Collection r = new ArrayList(1); + final Collection r = new ArrayList<>(1); for (AccountExternalId i : db.accountExternalIds().byAccount( user.getAccountId())) { if (i.isScheme(SCHEME_USERNAME)) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java index 9b4f4df98d..889addf2ad 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java @@ -83,7 +83,7 @@ public class GroupDetailFactory implements Callable { } private List loadMembers() throws OrmException { - List members = new ArrayList(); + List members = new ArrayList<>(); for (final AccountGroupMember m : db.accountGroupMembers().byGroup(groupId)) { if (control.canSeeMember(m.getAccountId())) { aic.want(m.getAccountId()); @@ -117,7 +117,7 @@ public class GroupDetailFactory implements Callable { } private List loadIncludes() throws OrmException { - List groups = new ArrayList(); + List groups = new ArrayList<>(); for (final AccountGroupById m : db.accountGroupById().byGroup(groupId)) { if (control.canSeeGroup(m.getIncludeUUID())) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupMembers.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupMembers.java index df5b2c1918..3fe9d2560f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupMembers.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupMembers.java @@ -91,7 +91,7 @@ public class GroupMembers { projectControl.controlFor(project, currentUser).getProjectState() .getOwners(); - final HashSet projectOwners = new HashSet(); + final HashSet projectOwners = new HashSet<>(); for (final AccountGroup.UUID ownerGroup : ownerGroups) { if (!seen.contains(ownerGroup)) { projectOwners.addAll(listAccounts(ownerGroup, project, seen)); @@ -107,7 +107,7 @@ public class GroupMembers { final GroupDetail groupDetail = groupDetailFactory.create(group.getId()).call(); - final Set members = new HashSet(); + final Set members = new HashSet<>(); if (groupDetail.members != null) { for (final AccountGroupMember member : groupDetail.members) { members.add(accountCache.get(member.getAccountId()).getAccount()); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/PerformCreateGroup.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/PerformCreateGroup.java index ca1bf32ee1..a54a97b5f2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/PerformCreateGroup.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/PerformCreateGroup.java @@ -126,10 +126,8 @@ public class PerformCreateGroup { private void addMembers(final AccountGroup.Id groupId, final Collection members) throws OrmException { - final List memberships = - new ArrayList(); - final List membershipsAudit = - new ArrayList(); + List memberships = new ArrayList<>(); + List membershipsAudit = new ArrayList<>(); for (Account.Id accountId : members) { final AccountGroupMember membership = new AccountGroupMember(new AccountGroupMember.Key(accountId, groupId)); @@ -149,10 +147,8 @@ public class PerformCreateGroup { private void addGroups(final AccountGroup.Id groupId, final Collection groups) throws OrmException { - final List includeList = - new ArrayList(); - final List includesAudit = - new ArrayList(); + List includeList = new ArrayList<>(); + List includesAudit = new ArrayList<>(); for (AccountGroup.UUID includeUUID : groups) { final AccountGroupById groupInclude = new AccountGroupById(new AccountGroupById.Key(groupId, includeUUID)); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java index afefe6fb27..5a19814a86 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java @@ -169,10 +169,10 @@ import javax.security.auth.login.LoginException; LdapQuery.Result findAccount(final Helper.LdapSchema schema, final DirContext ctx, final String username) throws NamingException, AccountException { - final HashMap params = new HashMap(); + final HashMap params = new HashMap<>(); params.put(LdapRealm.USERNAME, username); - final List res = new ArrayList(); + final List res = new ArrayList<>(); for (LdapQuery accountQuery : schema.accountQueryList) { res.addAll(accountQuery.query(ctx, params)); } @@ -193,10 +193,10 @@ import javax.security.auth.login.LoginException; final String username, LdapQuery.Result account) throws NamingException, AccountException { final LdapSchema schema = getSchema(ctx); - final Set groupDNs = new HashSet(); + final Set groupDNs = new HashSet<>(); if (!schema.groupMemberQueryList.isEmpty()) { - final HashMap params = new HashMap(); + final HashMap params = new HashMap<>(); if (account == null) { try { @@ -244,7 +244,7 @@ import javax.security.auth.login.LoginException; } } - final Set actual = new HashSet(); + final Set actual = new HashSet<>(); for (String dn : groupDNs) { actual.add(new AccountGroup.UUID(LDAP_UUID + dn)); } @@ -305,10 +305,10 @@ import javax.security.auth.login.LoginException; LdapSchema(final DirContext ctx) { type = discoverLdapType(ctx); - groupMemberQueryList = new ArrayList(); - accountQueryList = new ArrayList(); + groupMemberQueryList = new ArrayList<>(); + accountQueryList = new ArrayList<>(); - final Set accountAtts = new HashSet(); + final Set accountAtts = new HashSet<>(); // Group query // diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapGroupBackend.java b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapGroupBackend.java index 26c1c7af7d..7731b7de07 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapGroupBackend.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapGroupBackend.java @@ -227,7 +227,7 @@ public class LdapGroupBackend implements GroupBackend { ParameterizedString filter = ParameterizedString.asis( schema.groupPattern.replace(GROUPNAME, name).toString()); Set returnAttrs = - new HashSet(schema.groupName.getParameterNames()); + new HashSet<>(schema.groupName.getParameterNames()); Map params = Collections.emptyMap(); for (String groupBase : schema.groupBases) { LdapQuery query = new LdapQuery( diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapQuery.java b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapQuery.java index 8a6dfeb3e1..1f6801162c 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapQuery.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapQuery.java @@ -69,7 +69,7 @@ class LdapQuery { sc.setReturningAttributes(returnAttributes); res = ctx.search(base, pattern.getRawPattern(), pattern.bind(params), sc); try { - final List r = new ArrayList(); + final List r = new ArrayList<>(); try { while (res.hasMore()) { r.add(new Result(res.next())); @@ -83,7 +83,7 @@ class LdapQuery { } class Result { - private final Map atts = new HashMap(); + private final Map atts = new HashMap<>(); Result(final SearchResult sr) { if (returnAttributes != null) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapRealm.java b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapRealm.java index 7cde019749..84b5277988 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapRealm.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapRealm.java @@ -88,7 +88,7 @@ public class LdapRealm implements Realm { this.membershipCache = membershipCache; this.config = config; - this.readOnlyAccountFields = new HashSet(); + this.readOnlyAccountFields = new HashSet<>(); if (optdef(config, "accountFullName", "DEFAULT") != null) { readOnlyAccountFields.add(Account.FieldName.FULL_NAME); @@ -174,7 +174,7 @@ public class LdapRealm implements Realm { return null; } - final Map values = new HashMap(); + final Map values = new HashMap<>(); for (final String name : m.attributes()) { values.put(name, m.get(name)); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/cache/CacheModule.java b/gerrit-server/src/main/java/com/google/gerrit/server/cache/CacheModule.java index c09338068c..2276defe91 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/cache/CacheModule.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/cache/CacheModule.java @@ -83,8 +83,7 @@ public abstract class CacheModule extends AbstractModule { @SuppressWarnings("unchecked") Key> key = (Key>) Key.get(type, Names.named(name)); - CacheProvider m = - new CacheProvider(this, name, keyType, valType); + CacheProvider m = new CacheProvider<>(this, name, keyType, valType); bind(key).toProvider(m).asEagerSingleton(); bind(ANY_CACHE).annotatedWith(Exports.named(name)).to(key); return m.maximumWeight(1024); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java index 5321acd5ea..909b32a0b8 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java @@ -441,8 +441,7 @@ public class ChangeJson { private Map initLabels(ChangeData cd, LabelTypes labelTypes, boolean standard) throws OrmException { // Don't use Maps.newTreeMap(Comparator) due to OpenJDK bug 100167. - Map labels = - new TreeMap(labelTypes.nameComparator()); + Map labels = new TreeMap<>(labelTypes.nameComparator()); for (SubmitRecord rec : submitRecords(cd)) { if (rec.labels == null) { continue; @@ -572,8 +571,7 @@ public class ChangeJson { // would have done. These should really come from a stored submit record. // // Don't use Maps.newTreeMap(Comparator) due to OpenJDK bug 100167. - Map labels = - new TreeMap(labelTypes.nameComparator()); + Map labels = new TreeMap<>(labelTypes.nameComparator()); for (String name : labelNames) { LabelType type = labelTypes.byLabel(name); LabelInfo li = new LabelInfo(); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerJson.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerJson.java index 22ddd2d2ff..2b9ca6a9e1 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerJson.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerJson.java @@ -90,7 +90,7 @@ public class ReviewerJson { LabelTypes labelTypes = ctl.getLabelTypes(); // Don't use Maps.newTreeMap(Comparator) due to OpenJDK bug 100167. - out.approvals = new TreeMap(labelTypes.nameComparator()); + out.approvals = new TreeMap<>(labelTypes.nameComparator()); for (PatchSetApproval ca : approvals) { for (PermissionRange pr : ctl.getLabelRanges()) { if (!pr.isEmpty()) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/config/AuthConfig.java b/gerrit-server/src/main/java/com/google/gerrit/server/config/AuthConfig.java index a633acd10e..1d640c2d1a 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/config/AuthConfig.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/config/AuthConfig.java @@ -112,7 +112,7 @@ public class AuthConfig { s = new String[] {"http://", "https://"}; } - List r = new ArrayList(); + List r = new ArrayList<>(); for (String pattern : s) { r.add(OpenIdProviderPattern.create(pattern)); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/config/ConfigUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/config/ConfigUtil.java index e081b02afd..ab290cbaea 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/config/ConfigUtil.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/config/ConfigUtil.java @@ -165,7 +165,7 @@ public class ConfigUtil { public static > List getEnumList(final Config config, final String section, final String subsection, final String setting, final T[] all, final T defaultValue) { - final List list = new ArrayList(); + final List list = new ArrayList<>(); final String[] values = config.getStringList(section, subsection, setting); if (values.length == 0) { list.add(defaultValue); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/config/DownloadConfig.java b/gerrit-server/src/main/java/com/google/gerrit/server/config/DownloadConfig.java index f259871485..80031c2ee2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/config/DownloadConfig.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/config/DownloadConfig.java @@ -40,13 +40,13 @@ public class DownloadConfig { ConfigUtil.getEnumList(cfg, "download", null, "scheme", DownloadScheme.DEFAULT_DOWNLOADS); downloadSchemes = - Collections.unmodifiableSet(new HashSet(allSchemes)); + Collections.unmodifiableSet(new HashSet<>(allSchemes)); List allCommands = ConfigUtil.getEnumList(cfg, "download", null, "command", DownloadCommand.DEFAULT_DOWNLOADS); downloadCommands = - Collections.unmodifiableSet(new HashSet(allCommands)); + Collections.unmodifiableSet(new HashSet<>(allCommands)); } /** Scheme used to download. */ diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/config/TrackingFootersProvider.java b/gerrit-server/src/main/java/com/google/gerrit/server/config/TrackingFootersProvider.java index c10c0eb287..a76b010dd8 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/config/TrackingFootersProvider.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/config/TrackingFootersProvider.java @@ -34,8 +34,7 @@ public class TrackingFootersProvider implements Provider { private static String FOOTER_TAG = "footer"; private static String SYSTEM_TAG = "system"; private static String REGEX_TAG = "match"; - private final List trackingFooters = - new ArrayList(); + private final List trackingFooters = new ArrayList<>(); private static final Logger log = LoggerFactory.getLogger(TrackingFootersProvider.class); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java b/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java index 9d4857447f..3045a865df 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java @@ -190,7 +190,7 @@ public class EventFactory { */ public void addSubmitRecords(ChangeAttribute ca, List submitRecords) { - ca.submitRecords = new ArrayList(); + ca.submitRecords = new ArrayList<>(); for (SubmitRecord submitRecord : submitRecords) { SubmitRecordAttribute sa = new SubmitRecordAttribute(); @@ -209,7 +209,7 @@ public class EventFactory { private void addSubmitRecordLabels(SubmitRecord submitRecord, SubmitRecordAttribute sa) { if (submitRecord.labels != null && !submitRecord.labels.isEmpty()) { - sa.labels = new ArrayList(); + sa.labels = new ArrayList<>(); for (SubmitRecord.Label lbl : submitRecord.labels) { SubmitLabelAttribute la = new SubmitLabelAttribute(); la.label = lbl.label; @@ -224,8 +224,8 @@ public class EventFactory { } public void addDependencies(ChangeAttribute ca, Change change) { - ca.dependsOn = new ArrayList(); - ca.neededBy = new ArrayList(); + ca.dependsOn = new ArrayList<>(); + ca.neededBy = new ArrayList<>(); try { final ReviewDb db = schema.open(); try { @@ -293,7 +293,7 @@ public class EventFactory { public void addTrackingIds(ChangeAttribute a, Multimap set) { if (!set.isEmpty()) { - a.trackingIds = new ArrayList(set.size()); + a.trackingIds = new ArrayList<>(set.size()); for (Map.Entry> e : set.asMap().entrySet()) { for (String id : e.getValue()) { TrackingIdAttribute t = new TrackingIdAttribute(); @@ -324,7 +324,7 @@ public class EventFactory { Map> approvals, boolean includeFiles, Change change, LabelTypes labelTypes) { if (!ps.isEmpty()) { - ca.patchSets = new ArrayList(ps.size()); + ca.patchSets = new ArrayList<>(ps.size()); for (PatchSet p : ps) { PatchSetAttribute psa = asPatchSetAttribute(p); if (approvals != null) { @@ -344,8 +344,7 @@ public class EventFactory { if (comment.getKey().getParentKey().getParentKey().get() == Integer.parseInt(patchSetAttribute.number)) { if (patchSetAttribute.comments == null) { - patchSetAttribute.comments = - new ArrayList(); + patchSetAttribute.comments = new ArrayList<>(); } patchSetAttribute.comments.add(asPatchSetLineAttribute(comment)); } @@ -358,7 +357,7 @@ public class EventFactory { PatchList patchList = patchListCache.get(change, patchSet); for (PatchListEntry patch : patchList.getPatches()) { if (patchSetAttribute.files == null) { - patchSetAttribute.files = new ArrayList(); + patchSetAttribute.files = new ArrayList<>(); } PatchAttribute p = new PatchAttribute(); @@ -376,7 +375,7 @@ public class EventFactory { public void addComments(ChangeAttribute ca, Collection messages) { if (!messages.isEmpty()) { - ca.comments = new ArrayList(); + ca.comments = new ArrayList<>(); for (ChangeMessage message : messages) { ca.comments.add(asMessageAttribute(message)); } @@ -402,7 +401,7 @@ public class EventFactory { try { final ReviewDb db = schema.open(); try { - p.parents = new ArrayList(); + p.parents = new ArrayList<>(); for (PatchSetAncestor a : db.patchSetAncestors().ancestorsOf( patchSet.getId())) { p.parents.add(a.getAncestorRevision().get()); @@ -452,7 +451,7 @@ public class EventFactory { public void addApprovals(PatchSetAttribute p, Collection list, LabelTypes labelTypes) { if (!list.isEmpty()) { - p.approvals = new ArrayList(list.size()); + p.approvals = new ArrayList<>(list.size()); for (PatchSetApproval a : list) { if (a.getValue() != 0) { p.approvals.add(asApprovalAttribute(a, labelTypes)); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/AccountsSection.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/AccountsSection.java index 7d868bf854..4ea24ef829 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/AccountsSection.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/AccountsSection.java @@ -24,7 +24,7 @@ public class AccountsSection { public List getSameGroupVisibility() { if (sameGroupVisibility == null) { - sameGroupVisibility = new ArrayList(); + sameGroupVisibility = new ArrayList<>(); } return sameGroupVisibility; } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/BanCommitResult.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/BanCommitResult.java index 1b4845502f..baae6294fe 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/BanCommitResult.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/BanCommitResult.java @@ -21,9 +21,9 @@ import java.util.List; public class BanCommitResult { - private final List newlyBannedCommits = new LinkedList(); - private final List alreadyBannedCommits = new LinkedList(); - private final List ignoredObjectIds = new LinkedList(); + private final List newlyBannedCommits = new LinkedList<>(); + private final List alreadyBannedCommits = new LinkedList<>(); + private final List ignoredObjectIds = new LinkedList<>(); public BanCommitResult() { } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/ChangeMergeQueue.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/ChangeMergeQueue.java index a6b0a12e6e..a1dc71b3b2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/ChangeMergeQueue.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/ChangeMergeQueue.java @@ -55,10 +55,8 @@ public class ChangeMergeQueue implements MergeQueue { private static final Logger log = LoggerFactory.getLogger(ChangeMergeQueue.class); - private final Map active = - new HashMap(); - private final Map recheck = - new HashMap(); + private final Map active = new HashMap<>(); + private final Map recheck = new HashMap<>(); private final WorkQueue workQueue; private final Provider bgFactory; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/LocalDiskRepositoryManager.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/LocalDiskRepositoryManager.java index 43e0156497..196d3e9bdd 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/LocalDiskRepositoryManager.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/LocalDiskRepositoryManager.java @@ -234,7 +234,7 @@ public class LocalDiskRepositoryManager implements GitRepositoryManager { private void onCreateProject(final Project.NameKey newProjectName) { namesUpdateLock.lock(); try { - SortedSet n = new TreeSet(names); + SortedSet n = new TreeSet<>(names); n.add(newProjectName); names = Collections.unmodifiableSortedSet(n); } finally { @@ -345,7 +345,7 @@ public class LocalDiskRepositoryManager implements GitRepositoryManager { // scanning the filesystem. Don't rely on the cached names collection. namesUpdateLock.lock(); try { - SortedSet n = new TreeSet(); + SortedSet n = new TreeSet<>(); scanProjects(basePath, "", n); names = Collections.unmodifiableSortedSet(n); return n; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java index 78a2bc2759..4324d1a219 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java @@ -206,8 +206,8 @@ public class MergeOp { this.approvalsUtil = approvalsUtil; destBranch = branch; toMerge = ArrayListMultimap.create(); - potentiallyStillSubmittable = new ArrayList(); - commits = new HashMap(); + potentiallyStillSubmittable = new ArrayList<>(); + commits = new HashMap<>(); toUpdate = Lists.newArrayList(); } @@ -238,11 +238,11 @@ public class MergeOp { final ListMultimap toMergeNextTurn = ArrayListMultimap.create(); final List potentiallyStillSubmittableOnNextRun = - new ArrayList(); + new ArrayList<>(); while (!toMerge.isEmpty()) { toMergeNextTurn.clear(); final Set submitTypes = - new HashSet(toMerge.keySet()); + new HashSet<>(toMerge.keySet()); for (final SubmitType submitType : submitTypes) { if (reopen) { branchUpdate = openBranch(); @@ -418,7 +418,7 @@ public class MergeOp { private Set getAlreadyAccepted(final CodeReviewCommit branchTip) throws MergeException { - final Set alreadyAccepted = new HashSet(); + final Set alreadyAccepted = new HashSet<>(); if (branchTip != null) { alreadyAccepted.add(branchTip); @@ -453,7 +453,7 @@ public class MergeOp { throw new MergeException(e.getMessage(), e); } - final Set tips = new HashSet(); + final Set tips = new HashSet<>(); for (final Ref r : allRefs.values()) { tips.add(r.getObjectId()); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeSorter.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeSorter.java index 9b4582d54f..498539052f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeSorter.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeSorter.java @@ -40,8 +40,8 @@ public class MergeSorter { Collection sort(final Collection incoming) throws IOException { - final Set heads = new HashSet(); - final Set sort = new HashSet(incoming); + final Set heads = new HashSet<>(); + final Set sort = new HashSet<>(incoming); while (!sort.isEmpty()) { final CodeReviewCommit n = removeOne(sort); @@ -52,7 +52,7 @@ public class MergeSorter { } RevCommit c; - final RevCommitList contents = new RevCommitList(); + final RevCommitList contents = new RevCommitList<>(); while ((c = rw.next()) != null) { if (!c.has(canMergeFlag) || !incoming.contains(c)) { // We cannot merge n as it would bring something we @@ -60,7 +60,7 @@ public class MergeSorter { // if (n.missing == null) { n.setStatusCode(CommitMergeStatus.MISSING_DEPENDENCY); - n.missing = new ArrayList(); + n.missing = new ArrayList<>(); } n.missing.add((CodeReviewCommit) c); } else { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java index 9b74ee58a8..742499bb26 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java @@ -360,7 +360,7 @@ public class MergeUtil { if (submitter != null) { IdentifiedUser who = identifiedUserFactory.create(submitter.getAccountId()); - Set emails = new HashSet(); + Set emails = new HashSet<>(); for (RevCommit c : codeReviewCommits) { try { rw.parseBody(c); @@ -551,7 +551,7 @@ public class MergeUtil { final CodeReviewCommit mergeTip, final ObjectId treeId, final CodeReviewCommit n) throws IOException, MissingObjectException, IncorrectObjectTypeException { - final List merged = new ArrayList(); + final List merged = new ArrayList<>(); rw.resetRetain(canMergeFlag); rw.markStart(n); rw.markUninteresting(mergeTip); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/MultiProgressMonitor.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/MultiProgressMonitor.java index 45ecb6344d..4279b317ec 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/MultiProgressMonitor.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/MultiProgressMonitor.java @@ -132,7 +132,7 @@ public class MultiProgressMonitor { private final OutputStream out; private final String taskName; - private final List tasks = new CopyOnWriteArrayList(); + private final List tasks = new CopyOnWriteArrayList<>(); private int spinnerIndex; private char spinnerState = NO_SPINNER; private boolean done; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/PerThreadRequestScope.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/PerThreadRequestScope.java index e7bb0ae7cd..608743214d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/PerThreadRequestScope.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/PerThreadRequestScope.java @@ -81,7 +81,7 @@ public class PerThreadRequestScope { } } - private static final ThreadLocal current = new ThreadLocal(); + private static final ThreadLocal current = new ThreadLocal<>(); private static Context requireContext() { final Context ctx = current.get(); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java index 5d4d946ba6..d5dae8e44e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java @@ -437,7 +437,7 @@ public class ProjectConfig extends VersionedMetaData { private void loadContributorAgreements( Config rc, Map groupsByName) { - contributorAgreements = new HashMap(); + contributorAgreements = new HashMap<>(); for (String name : rc.getSubsections(CONTRIBUTOR_AGREEMENT)) { ContributorAgreement ca = getContributorAgreement(name, true); ca.setDescription(rc.getString(CONTRIBUTOR_AGREEMENT, name, KEY_DESCRIPTION)); @@ -535,7 +535,7 @@ public class ProjectConfig extends VersionedMetaData { private void loadAccessSections( Config rc, Map groupsByName) { - accessSections = new HashMap(); + accessSections = new HashMap<>(); for (String refName : rc.getSubsections(ACCESS)) { if (RefConfigSection.isValid(refName)) { AccessSection as = getAccessSection(refName, true); @@ -757,9 +757,8 @@ public class ProjectConfig extends VersionedMetaData { } private Map readGroupList() throws IOException { - groupsByUUID = new HashMap(); - Map groupsByName = - new HashMap(); + groupsByUUID = new HashMap<>(); + Map groupsByName = new HashMap<>(); BufferedReader br = new BufferedReader(new StringReader(readUTF8(GROUP_LIST))); String s; @@ -814,7 +813,7 @@ public class ProjectConfig extends VersionedMetaData { set(rc, DASHBOARD, null, KEY_DEFAULT, p.getDefaultDashboard()); set(rc, DASHBOARD, null, KEY_LOCAL_DEFAULT, p.getLocalDefaultDashboard()); - Set keepGroups = new HashSet(); + Set keepGroups = new HashSet<>(); saveAccountsSection(rc, keepGroups); saveContributorAgreements(rc, keepGroups); saveAccessSections(rc, keepGroups); @@ -931,7 +930,7 @@ public class ProjectConfig extends VersionedMetaData { private List ruleToStringList( List list, Set keepGroups) { - List rules = new ArrayList(); + List rules = new ArrayList<>(); for (PermissionRule rule : sort(list)) { if (rule.getGroup().getUUID() != null) { keepGroups.add(rule.getGroup().getUUID()); @@ -945,12 +944,12 @@ public class ProjectConfig extends VersionedMetaData { Config rc, Set keepGroups) { AccessSection capability = accessSections.get(AccessSection.GLOBAL_CAPABILITIES); if (capability != null) { - Set have = new HashSet(); + Set have = new HashSet<>(); for (Permission permission : sort(capability.getPermissions())) { have.add(permission.getName().toLowerCase()); boolean needRange = GlobalCapability.hasRange(permission.getName()); - List rules = new ArrayList(); + List rules = new ArrayList<>(); for (PermissionRule rule : sort(permission.getRules())) { GroupReference group = rule.getGroup(); if (group.getUUID() != null) { @@ -990,12 +989,12 @@ public class ProjectConfig extends VersionedMetaData { rc.unset(ACCESS, refName, KEY_GROUP_PERMISSIONS); } - Set have = new HashSet(); + Set have = new HashSet<>(); for (Permission permission : sort(as.getPermissions())) { have.add(permission.getName().toLowerCase()); boolean needRange = Permission.hasRange(permission.getName()); - List rules = new ArrayList(); + List rules = new ArrayList<>(); for (PermissionRule rule : sort(permission.getRules())) { GroupReference group = rule.getGroup(); if (group.getUUID() != null) { @@ -1139,7 +1138,7 @@ public class ProjectConfig extends VersionedMetaData { private void error(ValidationError error) { if (validationErrors == null) { - validationErrors = new ArrayList(4); + validationErrors = new ArrayList<>(4); } validationErrors.add(error); } @@ -1158,7 +1157,7 @@ public class ProjectConfig extends VersionedMetaData { } private static > List sort(Collection m) { - ArrayList r = new ArrayList(m); + ArrayList r = new ArrayList<>(m); Collections.sort(r); return r; } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/RebaseSorter.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/RebaseSorter.java index b0232cab27..8595582fd3 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/RebaseSorter.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/RebaseSorter.java @@ -42,8 +42,8 @@ public class RebaseSorter { public List sort(Collection incoming) throws IOException { - final List sorted = new ArrayList(); - final Set sort = new HashSet(incoming); + final List sorted = new ArrayList<>(); + final Set sort = new HashSet<>(incoming); while (!sort.isEmpty()) { final CodeReviewCommit n = removeOne(sort); @@ -54,7 +54,7 @@ public class RebaseSorter { } CodeReviewCommit c; - final List contents = new ArrayList(); + final List contents = new ArrayList<>(); while ((c = (CodeReviewCommit) rw.next()) != null) { if (!c.has(canMergeFlag) || !incoming.contains(c)) { // We cannot merge n as it would bring something we @@ -62,7 +62,7 @@ public class RebaseSorter { // if (n.missing == null) { n.setStatusCode(CommitMergeStatus.MISSING_DEPENDENCY); - n.missing = new ArrayList(); + n.missing = new ArrayList<>(); } n.missing.add(c); } else { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java index ca4a4ef82b..0256322891 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java @@ -304,10 +304,10 @@ public class ReceiveCommits { private List newChanges = Collections.emptyList(); private final Map replaceByChange = - new HashMap(); + new HashMap<>(); private final Map replaceByCommit = - new HashMap(); - private final Set validCommits = new HashSet(); + new HashMap<>(); + private final Set validCommits = new HashSet<>(); private ListMultimap refsByChange; private SetMultimap refsById; @@ -318,7 +318,7 @@ public class ReceiveCommits { private final MergeQueue mergeQueue; private final DynamicMap pluginConfigEntries; - private final List messages = new ArrayList(); + private final List messages = new ArrayList<>(); private ListMultimap errors = LinkedListMultimap.create(); private Task newProgress; private Task replaceProgress; @@ -437,7 +437,7 @@ public class ReceiveCommits { rp.setCheckReferencedObjectsAreReachable(config.checkReferencedObjectsAreReachable); rp.setAdvertiseRefsHook(new VisibleRefFilter(tagCache, changeCache, repo, projectControl, db, false)); } - List advHooks = new ArrayList(3); + List advHooks = new ArrayList<>(3); advHooks.add(new AdvertiseRefsHook() { @Override public void advertiseRefs(BaseReceivePack rp) @@ -1392,7 +1392,7 @@ public class ReceiveCommits { } List pending = Lists.newArrayList(); - final Set newChangeIds = new HashSet(); + final Set newChangeIds = new HashSet<>(); for (;;) { final RevCommit c = walk.next(); if (c == null) { @@ -2220,7 +2220,7 @@ public class ReceiveCommits { final SetMultimap byCommit = changeRefsById(); final Map byKey = openChangesByKey( new Branch.NameKey(project.getNameKey(), cmd.getRefName())); - final List toClose = new ArrayList(); + final List toClose = new ArrayList<>(); RevCommit c; while ((c = rw.next()) != null) { final Set refs = byCommit.get(c.copy()); @@ -2328,7 +2328,7 @@ public class ReceiveCommits { private Map openChangesByKey(Branch.NameKey branch) throws OrmException { - final Map r = new HashMap(); + final Map r = new HashMap<>(); for (Change c : db.changes().byBranchOpenAll(branch)) { r.put(c.getKey(), c.getId()); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReloadSubmitQueueOp.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReloadSubmitQueueOp.java index bcc2107344..850f2bec48 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReloadSubmitQueueOp.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReloadSubmitQueueOp.java @@ -46,7 +46,7 @@ public class ReloadSubmitQueueOp extends DefaultQueueOp { } public void run() { - final HashSet pending = new HashSet(); + final HashSet pending = new HashSet<>(); try { final ReviewDb c = schema.open(); try { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/RenameGroupOp.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/RenameGroupOp.java index 74900065d3..2b3994c8c0 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/RenameGroupOp.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/RenameGroupOp.java @@ -69,7 +69,7 @@ public class RenameGroupOp extends DefaultQueueOp { this.uuid = uuid; this.oldName = oldName; this.newName = newName; - this.retryOn = new ArrayList(); + this.retryOn = new ArrayList<>(); } @Override diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java index 5424887ee3..0279244b78 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java @@ -110,7 +110,7 @@ public class SubmoduleOp { this.repoManager = repoManager; this.gitRefUpdated = gitRefUpdated; - updatedSubscribers = new HashSet(); + updatedSubscribers = new HashSet<>(); } public void update() throws SubmoduleException { @@ -151,14 +151,13 @@ public class SubmoduleOp { destBranch.get()); final Set oldSubscriptions = - new HashSet(schema.submoduleSubscriptions() + new HashSet<>(schema.submoduleSubscriptions() .bySuperProject(destBranch).toList()); final List newSubscriptions = new SubmoduleSectionParser(bbc, thisServer, target, repoManager) .parseAllSections(); - final Set alreadySubscribeds = - new HashSet(); + final Set alreadySubscribeds = new HashSet<>(); for (SubmoduleSubscription s : newSubscriptions) { if (oldSubscriptions.contains(s)) { alreadySubscribeds.add(s); @@ -232,12 +231,10 @@ public class SubmoduleOp { + s.toString()); } else { - Map modules = - new HashMap(1); + Map modules = new HashMap<>(1); modules.put(updatedBranch, mergedCommit); - Map paths = - new HashMap(1); + Map paths = new HashMap<>(1); paths.put(updatedBranch, s.getPath()); try { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/TagMatcher.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/TagMatcher.java index b63378ff54..e55092794e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/TagMatcher.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/TagMatcher.java @@ -27,8 +27,8 @@ import java.util.List; class TagMatcher { final BitSet mask = new BitSet(); - final List newRefs = new ArrayList(); - final List lostRefs = new ArrayList(); + final List newRefs = new ArrayList<>(); + final List lostRefs = new ArrayList<>(); final TagSetHolder holder; final TagCache cache; final Repository db; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/TagSet.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/TagSet.java index 3eb927394e..761d5d6d67 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/TagSet.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/TagSet.java @@ -51,8 +51,8 @@ class TagSet { TagSet(Project.NameKey projectName) { this.projectName = projectName; - this.refs = new HashMap(); - this.tags = new ObjectIdOwnerMap(); + this.refs = new HashMap<>(); + this.tags = new ObjectIdOwnerMap<>(); } Tag lookupTag(AnyObjectId id) { @@ -238,7 +238,7 @@ class TagSet { // Gerrit Code Review server, perhaps about 50% of new references. // Since a complete rebuild is so costly, try this approach first. - Map byObj = new HashMap(); + Map byObj = new HashMap<>(); for (CachedRef r : old.refs.values()) { ObjectId id = r.get(); if (!byObj.containsKey(id)) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/VisibleRefFilter.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/VisibleRefFilter.java index 343b49c23a..62d80fa613 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/VisibleRefFilter.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/VisibleRefFilter.java @@ -77,8 +77,8 @@ public class VisibleRefFilter extends AbstractAdvertiseRefsHook { } final Set visibleChanges = visibleChanges(); - final Map result = new HashMap(); - final List deferredTags = new ArrayList(); + final Map result = new HashMap<>(); + final List deferredTags = new ArrayList<>(); for (Ref ref : refs.values()) { if (ref.getName().startsWith(RefNames.REFS_CACHE_AUTOMERGE)) { @@ -149,7 +149,7 @@ public class VisibleRefFilter extends AbstractAdvertiseRefsHook { final Project project = projectCtl.getProject(); try { - final Set visibleChanges = new HashSet(); + final Set visibleChanges = new HashSet<>(); for (Change change : changeCache.get(project.getNameKey())) { if (projectCtl.controlFor(change).isVisible(reviewDb)) { visibleChanges.add(change.getId()); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/WorkQueue.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/WorkQueue.java index 60eacb1167..8c11aec0ee 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/WorkQueue.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/WorkQueue.java @@ -96,7 +96,7 @@ public class WorkQueue { public WorkQueue(IdGenerator idGenerator, int defaultThreadPoolSize) { this.idGenerator = idGenerator; - this.queues = new CopyOnWriteArrayList(); + this.queues = new CopyOnWriteArrayList<>(); this.defaultQueueSize = defaultThreadPoolSize; } @@ -119,7 +119,7 @@ public class WorkQueue { /** Get all of the tasks currently scheduled in any work queue. */ public List> getTasks() { - final List> r = new ArrayList>(); + final List> r = new ArrayList<>(); for (final Executor e : queues) { e.addAllTo(r); } @@ -186,7 +186,7 @@ public class WorkQueue { } }); - all = new ConcurrentHashMap>( // + all = new ConcurrentHashMap<>( // corePoolSize << 1, // table size 0.75f, // load factor corePoolSize + 4 // concurrency level @@ -207,9 +207,9 @@ public class WorkQueue { Task task; if (runnable instanceof ProjectRunnable) { - task = new ProjectTask((ProjectRunnable) runnable, r, this, id); + task = new ProjectTask<>((ProjectRunnable) runnable, r, this, id); } else { - task = new Task(runnable, r, this, id); + task = new Task<>(runnable, r, this, id); } if (all.putIfAbsent(task.getTaskId(), task) == null) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/CherryPick.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/CherryPick.java index 6d15ed3c2b..08421cac5a 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/CherryPick.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/CherryPick.java @@ -56,7 +56,7 @@ public class CherryPick extends SubmitStrategy { this.patchSetInfoFactory = patchSetInfoFactory; this.gitRefUpdated = gitRefUpdated; - this.newCommits = new HashMap(); + this.newCommits = new HashMap<>(); } @Override @@ -212,7 +212,7 @@ public class CherryPick extends SubmitStrategy { private static void insertAncestors(ReviewDb db, PatchSet.Id id, RevCommit src) throws OrmException { final int cnt = src.getParentCount(); - List toInsert = new ArrayList(cnt); + List toInsert = new ArrayList<>(cnt); for (int p = 0; p < cnt; p++) { PatchSetAncestor a; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/RebaseIfNecessary.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/RebaseIfNecessary.java index 5fabb06a20..c38f5f21f1 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/RebaseIfNecessary.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/RebaseIfNecessary.java @@ -52,7 +52,7 @@ public class RebaseIfNecessary extends SubmitStrategy { super(args); this.patchSetInfoFactory = patchSetInfoFactory; this.rebaseChange = rebaseChange; - this.newCommits = new HashMap(); + this.newCommits = new HashMap<>(); this.committerIdent = committerIdent; } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java index 1bf754a807..a77938e7c9 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java @@ -92,8 +92,7 @@ public class CommitValidators { public List validateForReceiveCommits( CommitReceivedEvent receiveEvent) throws CommitValidationException { - List validators = - new LinkedList(); + List validators = new LinkedList<>(); validators.add(new UploadMergesPermissionValidator(refControl)); validators.add(new AmendedGerritMergeCommitValidationListener( @@ -110,8 +109,7 @@ public class CommitValidators { validators.add(new ConfigValidator(refControl, repo)); validators.add(new PluginCommitValidationListener(commitValidationListeners)); - List messages = - new LinkedList(); + List messages = new LinkedList<>(); try { for (CommitValidationListener commitValidator : validators) { @@ -128,8 +126,7 @@ public class CommitValidators { public List validateForGerritCommits( CommitReceivedEvent receiveEvent) throws CommitValidationException { - List validators = - new LinkedList(); + List validators = new LinkedList<>(); validators.add(new UploadMergesPermissionValidator(refControl)); validators.add(new AmendedGerritMergeCommitValidationListener( @@ -145,8 +142,7 @@ public class CommitValidators { validators.add(new ConfigValidator(refControl, repo)); validators.add(new PluginCommitValidationListener(commitValidationListeners)); - List messages = - new LinkedList(); + List messages = new LinkedList<>(); try { for (CommitValidationListener commitValidator : validators) { @@ -181,8 +177,7 @@ public class CommitValidators { CommitReceivedEvent receiveEvent) throws CommitValidationException { final List idList = receiveEvent.commit.getFooterLines(CHANGE_ID); - List messages = - new LinkedList(); + List messages = new LinkedList<>(); if (idList.isEmpty()) { if (projectControl.getProjectState().isRequireChangeID()) { @@ -321,8 +316,7 @@ public class CommitValidators { IdentifiedUser currentUser = (IdentifiedUser) refControl.getCurrentUser(); if (RefNames.REFS_CONFIG.equals(refControl.getRefName())) { - List messages = - new LinkedList(); + List messages = new LinkedList<>(); try { ProjectConfig cfg = @@ -381,8 +375,7 @@ public class CommitValidators { @Override public List onCommitReceived( CommitReceivedEvent receiveEvent) throws CommitValidationException { - List messages = - new LinkedList(); + List messages = new LinkedList<>(); for (CommitValidationListener validator : commitValidationListeners) { try { @@ -452,8 +445,7 @@ public class CommitValidators { if (!currentUser.getEmailAddresses().contains(author.getEmailAddress()) && !refControl.canForgeAuthor()) { - List messages = - new LinkedList(); + List messages = new LinkedList<>(); messages.add(getInvalidEmailError(receiveEvent.commit, "author", author, currentUser, canonicalWebUrl)); @@ -483,8 +475,7 @@ public class CommitValidators { if (!currentUser.getEmailAddresses() .contains(committer.getEmailAddress()) && !refControl.canForgeCommitter()) { - List messages = - new LinkedList(); + List messages = new LinkedList<>(); messages.add(getInvalidEmailError(receiveEvent.commit, "committer", committer, currentUser, canonicalWebUrl)); throw new CommitValidationException("invalid committer", messages); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/group/ListGroups.java b/gerrit-server/src/main/java/com/google/gerrit/server/group/ListGroups.java index f6b71877a1..91a0ec5551 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/group/ListGroups.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/group/ListGroups.java @@ -67,7 +67,7 @@ public class ListGroups implements RestReadView { @Option(name = "--project", aliases = {"-p"}, usage = "projects for which the groups should be listed") - private final List projects = new ArrayList(); + private final List projects = new ArrayList<>(); @Option(name = "--visible-to-all", usage = "to list only groups that are visible to all registered users") private boolean visibleToAll; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/index/ChangeSchemas.java b/gerrit-server/src/main/java/com/google/gerrit/server/index/ChangeSchemas.java index bd37408eae..1a628d3e27 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/index/ChangeSchemas.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/index/ChangeSchemas.java @@ -220,7 +220,7 @@ public class ChangeSchemas { private static Schema release(Collection> fields) { - return new Schema(true, fields); + return new Schema<>(true, fields); } @SafeVarargs @@ -231,7 +231,7 @@ public class ChangeSchemas { @SafeVarargs @SuppressWarnings("unused") private static Schema developer(FieldDef... fields) { - return new Schema(false, Arrays.asList(fields)); + return new Schema<>(false, Arrays.asList(fields)); } public static final ImmutableMap> ALL; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/index/IndexCollection.java b/gerrit-server/src/main/java/com/google/gerrit/server/index/IndexCollection.java index 2558cb454c..2380c76d7e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/index/IndexCollection.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/index/IndexCollection.java @@ -35,7 +35,7 @@ public class IndexCollection implements LifecycleListener { @VisibleForTesting public IndexCollection() { this.writeIndexes = Lists.newCopyOnWriteArrayList(); - this.searchIndex = new AtomicReference(); + this.searchIndex = new AtomicReference<>(); } /** @return the current search index version. */ diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/index/Schema.java b/gerrit-server/src/main/java/com/google/gerrit/server/index/Schema.java index c3a60d0034..0de13791d1 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/index/Schema.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/index/Schema.java @@ -113,9 +113,9 @@ public class Schema { if (v == null) { return null; } else if (f.isRepeatable()) { - return new Values(f, (Iterable) v); + return new Values<>(f, (Iterable) v); } else { - return new Values(f, Collections.singleton(v)); + return new Values<>(f, Collections.singleton(v)); } } }).filter(Predicates.notNull()); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java index 4e51a730c6..d38c5a3b4e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java @@ -98,7 +98,7 @@ public abstract class ChangeEmail extends NotificationEmail { formatChange(); appendText(velocifyFile("ChangeFooter.vm")); try { - TreeSet names = new TreeSet(); + TreeSet names = new TreeSet<>(); for (Account.Id who : changeData.reviewers().values()) { names.add(getNameEmailFor(who)); } @@ -338,7 +338,7 @@ public abstract class ChangeEmail extends NotificationEmail { /** Find all users who are authors of any part of this change. */ protected Set getAuthors() { - Set authors = new HashSet(); + Set authors = new HashSet<>(); authors.add(change.getOwner()); if (patchSet != null) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java index cb92b0fe4e..32a95ddeac 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java @@ -65,7 +65,7 @@ public class CommentSender extends ReplyToChangeSender { public void setPatchLineComments(final List plc) { inlineComments = plc; - Set paths = new HashSet(); + Set paths = new HashSet<>(); for (PatchLineComment c : plc) { Patch.Key p = c.getKey().getParentKey(); if (!Patch.COMMIT_MSG.equals(p.getFileName())) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/EmailHeader.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/EmailHeader.java index 6492a5e7ca..d4dce703bb 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/EmailHeader.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/EmailHeader.java @@ -114,7 +114,7 @@ public abstract class EmailHeader { } public static class AddressList extends EmailHeader { - private final List
list = new ArrayList
(); + private final List
list = new ArrayList<>(); public AddressList() { } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/MailUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/MailUtil.java index ac367ef200..26cccb8b3e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/MailUtil.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/MailUtil.java @@ -86,14 +86,14 @@ public class MailUtil { private final Set cc; public MailRecipients() { - this.reviewers = new HashSet(); - this.cc = new HashSet(); + this.reviewers = new HashSet<>(); + this.cc = new HashSet<>(); } public MailRecipients(final Set reviewers, final Set cc) { - this.reviewers = new HashSet(reviewers); - this.cc = new HashSet(cc); + this.reviewers = new HashSet<>(reviewers); + this.cc = new HashSet<>(cc); } public void add(final MailRecipients recipients) { @@ -111,14 +111,13 @@ public class MailUtil { } public Set getCcOnly() { - final Set cc = new HashSet(this.cc); + final Set cc = new HashSet<>(this.cc); cc.removeAll(reviewers); return Collections.unmodifiableSet(cc); } public Set getAll() { - final Set all = - new HashSet(reviewers.size() + cc.size()); + final Set all = new HashSet<>(reviewers.size() + cc.size()); all.addAll(reviewers); all.addAll(cc); return Collections.unmodifiableSet(all); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/NewChangeSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/NewChangeSender.java index 9ff0dbd04a..0dbcbe0048 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/NewChangeSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/NewChangeSender.java @@ -26,8 +26,8 @@ import java.util.Set; /** Sends an email alerting a user to a new change for them to review. */ public abstract class NewChangeSender extends ChangeEmail { - private final Set reviewers = new HashSet(); - private final Set extraCC = new HashSet(); + private final Set reviewers = new HashSet<>(); + private final Set extraCC = new HashSet<>(); protected NewChangeSender(EmailArguments ea, Change c) { super(ea, c, "newchange"); @@ -61,7 +61,7 @@ public abstract class NewChangeSender extends ChangeEmail { if (reviewers.isEmpty()) { return null; } - List names = new ArrayList(); + List names = new ArrayList<>(); for (Account.Id id : reviewers) { names.add(getNameFor(id)); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java index dc09a9cbc7..32f74bc4c4 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java @@ -52,7 +52,7 @@ public abstract class OutgoingEmail { private static final String HDR_CC = "CC"; protected String messageClass; - private final HashSet rcptTo = new HashSet(); + private final HashSet rcptTo = new HashSet<>(); private final Map headers; private final Set
smtpRcptTo = Sets.newHashSet(); private Address smtpFromAddress; @@ -66,7 +66,7 @@ public abstract class OutgoingEmail { protected OutgoingEmail(EmailArguments ea, String mc) { args = ea; messageClass = mc; - headers = new LinkedHashMap(); + headers = new LinkedHashMap<>(); } public void setFrom(final Account.Id id) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ProjectWatch.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ProjectWatch.java index 04c3f9fd97..3d16372116 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ProjectWatch.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ProjectWatch.java @@ -64,7 +64,7 @@ public class ProjectWatch { /** Returns all watchers that are relevant */ public final Watchers getWatchers(NotifyType type) throws OrmException { Watchers matching = new Watchers(); - Set projectWatchers = new HashSet(); + Set projectWatchers = new HashSet<>(); for (AccountProjectWatch w : args.db.get().accountProjectWatches() .byProject(project)) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplacePatchSetSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplacePatchSetSender.java index d80fb50746..8412d223a2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplacePatchSetSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ReplacePatchSetSender.java @@ -33,8 +33,8 @@ public class ReplacePatchSetSender extends ReplyToChangeSender { public ReplacePatchSetSender create(Change change); } - private final Set reviewers = new HashSet(); - private final Set extraCC = new HashSet(); + private final Set reviewers = new HashSet<>(); + private final Set extraCC = new HashSet<>(); @Inject public ReplacePatchSetSender(EmailArguments ea, @Assisted Change c) { @@ -74,7 +74,7 @@ public class ReplacePatchSetSender extends ReplyToChangeSender { if (reviewers.isEmpty()) { return null; } - List names = new ArrayList(); + List names = new ArrayList<>(); for (Account.Id id : reviewers) { names.add(getNameFor(id)); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java index f16cb5a7b5..b1c5955bd4 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java @@ -107,7 +107,7 @@ public class SmtpEmailSender implements EmailSender { smtpUser = cfg.getString("sendemail", null, "smtpuser"); smtpPass = cfg.getString("sendemail", null, "smtppass"); - Set rcpt = new HashSet(); + Set rcpt = new HashSet<>(); for (String addr : cfg.getStringList("sendemail", null, "allowrcpt")) { rcpt.add(addr); } @@ -152,7 +152,7 @@ public class SmtpEmailSender implements EmailSender { } final Map hdrs = - new LinkedHashMap(callerHeaders); + new LinkedHashMap<>(callerHeaders); setMissingHeader(hdrs, "MIME-Version", "1.0"); setMissingHeader(hdrs, "Content-Type", "text/plain; charset=UTF-8"); setMissingHeader(hdrs, "Content-Transfer-Encoding", "8bit"); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java index 52cba098b2..4961befe4d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineLoader.java @@ -78,7 +78,7 @@ class IntraLineLoader extends CacheLoader { } static IntraLineDiff compute(IntraLineDiffKey key) throws Exception { - List edits = new ArrayList(key.getEdits()); + List edits = new ArrayList<>(key.getEdits()); Text aContent = key.getTextA(); Text bContent = key.getTextB(); combineLineEdits(edits, aContent, bContent); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineWorkerPool.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineWorkerPool.java index 5c6338fea1..49ae9503ac 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineWorkerPool.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/IntraLineWorkerPool.java @@ -45,7 +45,7 @@ public class IntraLineWorkerPool { int workers = cfg.getInt( "cache", PatchListCacheImpl.INTRA_NAME, "maxIdleWorkers", Runtime.getRuntime().availableProcessors() * 3 / 2); - workerPool = new ArrayBlockingQueue(workers, true /* fair */); + workerPool = new ArrayBlockingQueue<>(workers, true /* fair */); } Worker acquire() { @@ -73,8 +73,8 @@ public class IntraLineWorkerPool { private final ArrayBlockingQueue result; Worker() { - input = new ArrayBlockingQueue(1); - result = new ArrayBlockingQueue(1); + input = new ArrayBlockingQueue<>(1); + result = new ArrayBlockingQueue<>(1); setName("IntraLineDiff-" + count.getAndIncrement()); setDaemon(true); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchList.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchList.java index 59e30507fd..7d449124ed 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchList.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchList.java @@ -127,7 +127,7 @@ public class PatchList implements Serializable { * how the cache is keyed versus how the database is keyed. */ public List toPatchList(final PatchSet.Id setId) { - final ArrayList r = new ArrayList(patches.length); + final ArrayList r = new ArrayList<>(patches.length); for (final PatchListEntry e : patches) { r.add(e.toPatch(setId)); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListEntry.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListEntry.java index 852165c28c..31f5e96b4d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListEntry.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListEntry.java @@ -168,7 +168,7 @@ public class PatchListEntry { public List getHeaderLines() { final IntList m = RawParseUtils.lineMap(header, 0, header.length); - final List headerLines = new ArrayList(m.size() - 1); + final List headerLines = new ArrayList<>(m.size() - 1); for (int i = 1; i < m.size() - 1; i++) { final int b = m.get(i); int e = m.get(i + 1); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListLoader.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListLoader.java index 2cda3346ca..f704ea2dca 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListLoader.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListLoader.java @@ -311,7 +311,7 @@ public class PatchListLoader extends CacheLoader { MergeFormatter fmt = new MergeFormatter(); Map> r = m.getMergeResults(); - Map resolved = new HashMap(); + Map resolved = new HashMap<>(); for (Map.Entry> entry : r.entrySet()) { MergeResult p = entry.getValue(); TemporaryBuffer buf = new TemporaryBuffer.LocalFile(10 * 1024 * 1024); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchScriptBuilder.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchScriptBuilder.java index 0db7dee1af..a52b066230 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchScriptBuilder.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchScriptBuilder.java @@ -136,7 +136,7 @@ class PatchScriptBuilder { a.resolve(null, aId); b.resolve(a, bId); - edits = new ArrayList(content.getEdits()); + edits = new ArrayList<>(content.getEdits()); if (!isModify(content)) { intralineDifferenceIsPossible = false; @@ -148,7 +148,7 @@ class PatchScriptBuilder { if (d != null) { switch (d.getStatus()) { case EDIT_LIST: - edits = new ArrayList(d.getEdits()); + edits = new ArrayList<>(d.getEdits()); break; case DISABLED: @@ -185,7 +185,7 @@ class PatchScriptBuilder { for (int i = 0; i < a.size(); i++) { a.addLine(i); } - edits = new ArrayList(1); + edits = new ArrayList<>(1); edits.add(new Edit(a.size(), a.size())); } else { @@ -269,7 +269,7 @@ class PatchScriptBuilder { // correct hunks from this, but because the Edit is empty they will not // style it specially. // - final List empty = new ArrayList(); + final List empty = new ArrayList<>(); int lastLine; lastLine = -1; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchScriptFactory.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchScriptFactory.java index ed4470ab67..3ec88f7313 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchScriptFactory.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchScriptFactory.java @@ -212,10 +212,10 @@ public class PatchScriptFactory implements Callable { private void loadCommentsAndHistory(final ChangeType changeType, final String oldName, final String newName) throws OrmException { - history = new ArrayList(); + history = new ArrayList<>(); comments = new CommentDetail(psa, psb); - final Map byKey = new HashMap(); + final Map byKey = new HashMap<>(); final AccountInfoCacheFactory aic = aicFactory.create(); // This seems like a cheap trick. It doesn't properly account for a diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java index 8165bf2124..340300af19 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java @@ -123,8 +123,7 @@ public class PatchSetInfoFactory { private List toParentInfos(final RevCommit[] parents, final RevWalk walk) throws IOException, MissingObjectException { - List pInfos = - new ArrayList(parents.length); + List pInfos = new ArrayList<>(parents.length); for (RevCommit parent : parents) { walk.parseBody(parent); RevId rev = new RevId(parent.getId().name()); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginGuiceEnvironment.java b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginGuiceEnvironment.java index bc622ad4f7..ba90bdd305 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginGuiceEnvironment.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginGuiceEnvironment.java @@ -108,10 +108,10 @@ public class PluginGuiceEnvironment { this.copyConfigModule = ccm; this.copyConfigKeys = Guice.createInjector(ccm).getAllBindings().keySet(); - onStart = new CopyOnWriteArrayList(); + onStart = new CopyOnWriteArrayList<>(); onStart.addAll(listeners(sysInjector, StartPluginListener.class)); - onReload = new CopyOnWriteArrayList(); + onReload = new CopyOnWriteArrayList<>(); onReload.addAll(listeners(sysInjector, ReloadPluginListener.class)); sysItems = dynamicItemsOf(sysInjector); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginLoader.java b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginLoader.java index b4d8df1a25..a8a0d63351 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginLoader.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginLoader.java @@ -151,7 +151,7 @@ public class PluginLoader implements LifecycleListener { if (!all) { return running.values(); } else { - ArrayList plugins = new ArrayList(running.values()); + List plugins = new ArrayList<>(running.values()); plugins.addAll(disabled.values()); return plugins; } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java index 377a768961..1ef537809e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java @@ -505,7 +505,7 @@ public class ChangeControl { * the out collection is reversed to restore it to the original ordering. */ public List resultsToSubmitRecord(Term submitRule, List results) { - List out = new ArrayList(results.size()); + List out = new ArrayList<>(results.size()); for (int resultIdx = results.size() - 1; 0 <= resultIdx; resultIdx--) { Term submitRecord = results.get(resultIdx); SubmitRecord rec = new SubmitRecord(); @@ -534,7 +534,7 @@ public class ChangeControl { return logInvalidResult(submitRule, submitRecord); } - rec.labels = new ArrayList (submitRecord.arity()); + rec.labels = new ArrayList<>(submitRecord.arity()); for (Term state : ((StructureTerm) submitRecord).args()) { if (!state.isStructure() || 2 != state.arity() || !"label".equals(state.name())) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java index d249b1df69..f6c9107b8f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java @@ -241,10 +241,9 @@ public class ListProjects implements RestReadView { int found = 0; Map output = Maps.newTreeMap(); Map hiddenNames = Maps.newHashMap(); - Set rejected = new HashSet(); + Set rejected = new HashSet<>(); - final TreeMap treeMap = - new TreeMap(); + final TreeMap treeMap = new TreeMap<>(); try { for (final Project.NameKey projectName : scan()) { final ProjectState e = projectCache.get(projectName); @@ -442,7 +441,7 @@ public class ListProjects implements RestReadView { private void printProjectTree(final PrintWriter stdout, final TreeMap treeMap) { - final SortedSet sortedNodes = new TreeSet(); + final SortedSet sortedNodes = new TreeSet<>(); // Builds the inheritance tree using a list. // diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/PerRequestProjectControlCache.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/PerRequestProjectControlCache.java index 19a42aee77..f46a88118e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/PerRequestProjectControlCache.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/PerRequestProjectControlCache.java @@ -34,7 +34,7 @@ public class PerRequestProjectControlCache { CurrentUser userProvider) { this.projectCache = projectCache; this.user = userProvider; - this.controls = new HashMap(); + this.controls = new HashMap<>(); } ProjectControl get(Project.NameKey nameKey) throws NoSuchProjectException { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/PerformCreateProject.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/PerformCreateProject.java index 22a761ba9e..f8cd9c16c2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/PerformCreateProject.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/PerformCreateProject.java @@ -240,11 +240,10 @@ public class PerformCreateProject { if (createProjectArgs.ownerIds == null || createProjectArgs.ownerIds.isEmpty()) { - createProjectArgs.ownerIds = - new ArrayList(projectOwnerGroups); + createProjectArgs.ownerIds = new ArrayList<>(projectOwnerGroups); } - List transformedBranches = new ArrayList(); + List transformedBranches = new ArrayList<>(); if (createProjectArgs.branch == null || createProjectArgs.branch.isEmpty()) { createProjectArgs.branch = Collections.singletonList(Constants.MASTER); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/PermissionCollection.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/PermissionCollection.java index 3b6ce91faa..f3ad45f52a 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/PermissionCollection.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/PermissionCollection.java @@ -109,12 +109,11 @@ public class PermissionCollection { List sections = Lists.newArrayList(sectionToProject.keySet()); sorter.sort(ref, sections); - Set seen = new HashSet(); - Set seenBlockingRules = new HashSet(); - Set exclusiveGroupPermissions = new HashSet(); + Set seen = new HashSet<>(); + Set seenBlockingRules = new HashSet<>(); + Set exclusiveGroupPermissions = new HashSet<>(); - HashMap> permissions = - new HashMap>(); + HashMap> permissions = new HashMap<>(); Map ruleProps = Maps.newIdentityHashMap(); for (AccessSection section : sections) { Project.NameKey project = sectionToProject.get(section); @@ -133,7 +132,7 @@ public class PermissionCollection { if (addRule) { List r = permissions.get(permission.getName()); if (r == null) { - r = new ArrayList(2); + r = new ArrayList<>(2); permissions.put(permission.getName(), r); } r.add(rule); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java index c7cc9c37f2..53b73686d5 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java @@ -193,7 +193,7 @@ public class ProjectControl { public RefControl controlForRef(String refName) { if (refControls == null) { - refControls = new HashMap(); + refControls = new HashMap<>(); } RefControl ctl = refControls.get(refName); if (ctl == null) { @@ -313,7 +313,7 @@ public class ProjectControl { private static Set getGroups( final List sectionMatcherList) { - final Set all = new HashSet(); + final Set all = new HashSet<>(); for (final SectionMatcher matcher : sectionMatcherList) { final AccessSection section = matcher.section; for (final Permission permission : section.getPermissions()) { @@ -448,7 +448,7 @@ public class ProjectControl { } private Set allRefPatterns(String permissionName) { - Set all = new HashSet(); + Set all = new HashSet<>(); for (SectionMatcher matcher : access()) { AccessSection section = matcher.section; Permission permission = section.getPermission(permissionName); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectNode.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectNode.java index cc85312c38..e74511a4d9 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectNode.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectNode.java @@ -33,7 +33,7 @@ public class ProjectNode implements TreeNode, Comparable { private final Project project; private final boolean isVisible; - private final SortedSet children = new TreeSet(); + private final SortedSet children = new TreeSet<>(); @Inject protected ProjectNode(final AllProjectsName allProjectsName, diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectState.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectState.java index 69f76e3c77..f6b96d791e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectState.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectState.java @@ -134,7 +134,7 @@ public class ProjectState { if (isAllProjects && !Permission.canBeOnAllProjects(AccessSection.ALL, Permission.OWNER)) { localOwners = Collections.emptySet(); } else { - HashSet groups = new HashSet(); + HashSet groups = new HashSet<>(); AccessSection all = config.getAccessSection(AccessSection.ALL); if (all != null) { Permission owner = all.getPermission(Permission.OWNER); @@ -254,7 +254,7 @@ public class ProjectState { List sm = localAccessSections; if (sm == null) { Collection fromConfig = config.getAccessSections(); - sm = new ArrayList(fromConfig.size()); + sm = new ArrayList<>(fromConfig.size()); for (AccessSection section : fromConfig) { if (isAllProjects) { List copy = diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java index da093b6b5a..00ecee319d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java @@ -68,7 +68,7 @@ public class RefControl { this.projectControl = projectControl; this.refName = ref; this.relevant = relevant; - this.effective = new HashMap>(); + this.effective = new HashMap<>(); } public String getRefName() { @@ -387,7 +387,7 @@ public class RefControl { /** All value ranges of any allowed label permission. */ public List getLabelRanges(boolean isChangeOwner) { - List r = new ArrayList(); + List r = new ArrayList<>(); for (Map.Entry> e : relevant.getDeclaredPermissions()) { if (Permission.isLabel(e.getKey())) { int min = 0; @@ -565,7 +565,7 @@ public class RefControl { return rules; } - List mine = new ArrayList(rules.size()); + List mine = new ArrayList<>(rules.size()); for (PermissionRule rule : rules) { if (projectControl.match(rule, isChangeOwner)) { mine.add(rule); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/SectionSortCache.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/SectionSortCache.java index aeb92d346f..c012bd53db 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/SectionSortCache.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/SectionSortCache.java @@ -77,8 +77,7 @@ public class SectionSortCache { } else { boolean poison = false; - IdentityHashMap srcMap = - new IdentityHashMap(); + IdentityHashMap srcMap = new IdentityHashMap<>(); for (int i = 0; i < cnt; i++) { poison |= srcMap.put(sections.get(i), i) != null; } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java index f7c3c9dcb8..d79716ca76 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java @@ -134,7 +134,7 @@ public class SubmitRuleEvaluator { env.once("gerrit", "assume_range_from_label"); } - List results = new ArrayList(); + List results = new ArrayList<>(); try { for (Term[] template : env.all("gerrit", userRuleWrapperName, submitRule, new VariableTerm())) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/SuggestParentCandidates.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/SuggestParentCandidates.java index c73de60177..4a4e82ddcf 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/SuggestParentCandidates.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/SuggestParentCandidates.java @@ -45,8 +45,7 @@ public class SuggestParentCandidates { public List getNameKeys() throws OrmException, NoSuchProjectException { List pList = getProjects(); - final List nameKeys = - new ArrayList(pList.size()); + final List nameKeys = new ArrayList<>(pList.size()); for (Project p : pList) { nameKeys.add(p.getNameKey()); } @@ -55,7 +54,7 @@ public class SuggestParentCandidates { public List getProjects() throws OrmException, NoSuchProjectException { - Set projects = new TreeSet(new Comparator() { + Set projects = new TreeSet<>(new Comparator() { @Override public int compare(Project o1, Project o2) { return o1.getName().compareTo(o2.getName()); @@ -76,6 +75,6 @@ public class SuggestParentCandidates { } } projects.add(projectControlFactory.controlFor(allProject).getProject()); - return new ArrayList(projects); + return new ArrayList<>(projects); } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/AndPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/AndPredicate.java index 915a364a18..953dabfdab 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/AndPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/AndPredicate.java @@ -33,7 +33,7 @@ public class AndPredicate extends Predicate { } protected AndPredicate(final Collection> that) { - final ArrayList> t = new ArrayList>(that.size()); + List> t = new ArrayList<>(that.size()); int c = 0; for (Predicate p : that) { if (getClass() == p.getClass()) { @@ -67,7 +67,7 @@ public class AndPredicate extends Predicate { @Override public Predicate copy(final Collection> children) { - return new AndPredicate(children); + return new AndPredicate<>(children); } @Override diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/NotPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/NotPredicate.java index f94e1f6129..6a9a877bd5 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/NotPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/NotPredicate.java @@ -54,7 +54,7 @@ public class NotPredicate extends Predicate { if (children.size() != 1) { throw new IllegalArgumentException("Expected exactly one child"); } - return new NotPredicate(children.iterator().next()); + return new NotPredicate<>(children.iterator().next()); } @Override diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/OrPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/OrPredicate.java index 2c918096ff..845c805f0b 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/OrPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/OrPredicate.java @@ -33,7 +33,7 @@ public class OrPredicate extends Predicate { } protected OrPredicate(final Collection> that) { - final ArrayList> t = new ArrayList>(that.size()); + List> t = new ArrayList<>(that.size()); int c = 0; for (Predicate p : that) { if (getClass() == p.getClass()) { @@ -67,7 +67,7 @@ public class OrPredicate extends Predicate { @Override public Predicate copy(final Collection> children) { - return new OrPredicate(children); + return new OrPredicate<>(children); } @Override diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/Predicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/Predicate.java index c134458def..7b43572616 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/Predicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/Predicate.java @@ -55,7 +55,7 @@ public abstract class Predicate { if (that.length == 1) { return that[0]; } - return new AndPredicate(that); + return new AndPredicate<>(that); } /** Combine the passed predicates into a single AND node. */ @@ -64,7 +64,7 @@ public abstract class Predicate { if (that.size() == 1) { return Iterables.getOnlyElement(that); } - return new AndPredicate(that); + return new AndPredicate<>(that); } /** Combine the passed predicates into a single OR node. */ @@ -73,7 +73,7 @@ public abstract class Predicate { if (that.length == 1) { return that[0]; } - return new OrPredicate(that); + return new OrPredicate<>(that); } /** Combine the passed predicates into a single OR node. */ @@ -82,7 +82,7 @@ public abstract class Predicate { if (that.size() == 1) { return Iterables.getOnlyElement(that); } - return new OrPredicate(that); + return new OrPredicate<>(that); } /** Invert the passed node. */ @@ -130,7 +130,7 @@ public abstract class Predicate { public abstract boolean equals(Object other); private static class Any extends Predicate { - private static final Any INSTANCE = new Any(); + private static final Any INSTANCE = new Any<>(); private Any() { } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryBuilder.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryBuilder.java index a2769926d9..5be42be1bb 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryBuilder.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryBuilder.java @@ -84,7 +84,7 @@ public abstract class QueryBuilder { */ public static class Definition> { private final Map> opFactories = - new HashMap>(); + new HashMap<>(); public Definition(Class clazz) { // Guess at the supported operators by scanning methods. @@ -204,11 +204,11 @@ public abstract class QueryBuilder { final Tree val = onlyChildOf(opTree); if (val.getType() == SINGLE_WORD && "*".equals(val.getText())) { final String op = opTree.getText(); - final WildPatternPredicate pat = new WildPatternPredicate(op); - return new VariablePredicate(var, pat); + final WildPatternPredicate pat = new WildPatternPredicate<>(op); + return new VariablePredicate<>(var, pat); } } - return new VariablePredicate(var, toPredicate(opTree)); + return new VariablePredicate<>(var, toPredicate(opTree)); } default: @@ -224,7 +224,7 @@ public abstract class QueryBuilder { // case AND: case OR: { - List> p = new ArrayList>(val.getChildCount()); + List> p = new ArrayList<>(val.getChildCount()); for (int i = 0; i < val.getChildCount(); i++) { final Tree c = val.getChild(i); if (c.getType() != DEFAULT_FIELD) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryRewriter.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryRewriter.java index c0f841470d..6173fb6462 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryRewriter.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/QueryRewriter.java @@ -76,7 +76,7 @@ public abstract class QueryRewriter { if ((m.getModifiers() & Modifier.ABSTRACT) != Modifier.ABSTRACT && (m.getModifiers() & Modifier.PUBLIC) == Modifier.PUBLIC && rp != null) { - rewriteRules.add(new MethodRewrite(qb, rp.value(), m)); + rewriteRules.add(new MethodRewrite<>(qb, rp.value(), m)); } } c = c.getSuperclass(); @@ -138,7 +138,7 @@ public abstract class QueryRewriter { in = rewriteOne(in); if (old.equals(in) && in.getChildCount() > 0) { - List> n = new ArrayList>(in.getChildCount()); + List> n = new ArrayList<>(in.getChildCount()); for (Predicate p : in.getChildren()) { n.add(rewriteImpl(p)); } @@ -159,14 +159,14 @@ public abstract class QueryRewriter { return not(replaceGenericNodes(in.getChild(0))); } else if (in instanceof AndPredicate) { - List> n = new ArrayList>(in.getChildCount()); + List> n = new ArrayList<>(in.getChildCount()); for (Predicate c : in.getChildren()) { n.add(replaceGenericNodes(c)); } return and(n); } else if (in instanceof OrPredicate) { - List> n = new ArrayList>(in.getChildCount()); + List> n = new ArrayList<>(in.getChildCount()); for (Predicate c : in.getChildren()) { n.add(replaceGenericNodes(c)); } @@ -198,8 +198,8 @@ public abstract class QueryRewriter { } private static class MatchResult { - private static final MatchResult FAIL = new MatchResult(null); - private static final MatchResult OK = new MatchResult(null); + private static final MatchResult FAIL = new MatchResult<>(null); + private static final MatchResult OK = new MatchResult<>(null); @SuppressWarnings("unchecked") static MatchResult fail() { @@ -251,7 +251,7 @@ public abstract class QueryRewriter { // but in any order. // final LinkedList> have = dup(actual); - final LinkedList> extra = new LinkedList>(); + final LinkedList> extra = new LinkedList<>(); for (final Predicate pat : pattern.getChildren()) { boolean found = false; for (final Iterator> i = have.iterator(); i.hasNext();) { @@ -275,11 +275,11 @@ public abstract class QueryRewriter { return MatchResult.ok(); case 1: if (isNOT(actual)) { - return new MatchResult(actual.copy(have)); + return new MatchResult<>(actual.copy(have)); } - return new MatchResult(have.get(0)); + return new MatchResult<>(have.get(0)); default: - return new MatchResult(actual.copy(have)); + return new MatchResult<>(actual.copy(have)); } } else if (pattern.equals(actual)) { @@ -297,7 +297,7 @@ public abstract class QueryRewriter { } private static LinkedList> dup(final Predicate actual) { - return new LinkedList>(actual.getChildren()); + return new LinkedList<>(actual.getChildren()); } /** @@ -412,8 +412,7 @@ public abstract class QueryRewriter { @Override public Predicate rewrite(QueryRewriter rewriter, final Predicate input) { - final HashMap> args = - new HashMap>(); + final HashMap> args = new HashMap<>(); final MatchResult res = rewriter.match(args, pattern, input); if (!res.success()) { return null; @@ -483,7 +482,7 @@ public abstract class QueryRewriter { } private static List> removeDuplicates(List> n) { - List> r = new ArrayList>(); + List> r = new ArrayList<>(); for (Predicate p : n) { if (!r.contains(p)) { r.add(p); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/VariablePredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/VariablePredicate.java index 45b27e5494..d6d0f9c698 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/VariablePredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/VariablePredicate.java @@ -61,7 +61,7 @@ public class VariablePredicate extends Predicate { if (children.size() != 1) { throw new IllegalArgumentException("Expected exactly one child"); } - return new VariablePredicate(getName(), children.iterator().next()); + return new VariablePredicate<>(getName(), children.iterator().next()); } @Override diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/AbstractResultSet.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/AbstractResultSet.java index e07276064a..9bbc02fe4c 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/AbstractResultSet.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/AbstractResultSet.java @@ -22,7 +22,7 @@ import java.util.List; abstract class AbstractResultSet implements ResultSet { @Override public List toList() { - ArrayList r = new ArrayList(); + ArrayList r = new ArrayList<>(); for (T t : this) { r.add(t); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/AndSource.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/AndSource.java index ad0ec3ca87..55fd281ffb 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/AndSource.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/AndSource.java @@ -68,8 +68,7 @@ public class AndSource extends AndPredicate private static List> sort( Collection> that) { - ArrayList> r = - new ArrayList>(that); + List> r = new ArrayList<>(that); Collections.sort(r, CMP); return r; } @@ -158,7 +157,7 @@ public class AndSource extends AndPredicate } else if (start > 0) { r = ImmutableList.copyOf(r.subList(start, r.size())); } - return new ListResultSet(r); + return new ListResultSet<>(r); } private Iterable buffer( diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeData.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeData.java index 2f0bf33e93..3d7c7793d1 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeData.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeData.java @@ -281,7 +281,7 @@ public class ChangeData { return currentFiles; } - List r = new ArrayList(p.getPatches().size()); + List r = new ArrayList<>(p.getPatches().size()); for (PatchListEntry e : p.getPatches()) { if (Patch.COMMIT_MSG.equals(e.getNewName())) { continue; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeDataResultSet.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeDataResultSet.java index f469228c3c..52a5b7b01e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeDataResultSet.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeDataResultSet.java @@ -23,6 +23,7 @@ import com.google.inject.Provider; import java.util.HashSet; import java.util.Iterator; import java.util.NoSuchElementException; +import java.util.Set; abstract class ChangeDataResultSet extends AbstractResultSet { static ResultSet change(final ChangeData.Factory factory, @@ -78,7 +79,7 @@ abstract class ChangeDataResultSet extends AbstractResultSet { } else { return new Iterator() { private final Iterator itr = source.iterator(); - private final HashSet seen = new HashSet(); + private final Set seen = new HashSet<>(); private ChangeData next; @Override diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java index 8ffd88a733..40a23f993a 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java @@ -548,7 +548,7 @@ public class ChangeQueryBuilder extends QueryBuilder { // Collection suggestions = args.groupBackend.suggest(who, null); if (!suggestions.isEmpty()) { - HashSet ids = new HashSet(); + HashSet ids = new HashSet<>(); for (GroupReference ref : suggestions) { ids.add(ref.getUUID()); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeStatusPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeStatusPredicate.java index 9ff416f864..cea6af885e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeStatusPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeStatusPredicate.java @@ -49,7 +49,7 @@ public final class ChangeStatusPredicate extends IndexPredicate { } public static Predicate open(Provider dbProvider) { - List> r = new ArrayList>(4); + List> r = new ArrayList<>(4); for (final Change.Status e : Change.Status.values()) { if (e.isOpen()) { r.add(new ChangeStatusPredicate(e)); @@ -59,7 +59,7 @@ public final class ChangeStatusPredicate extends IndexPredicate { } public static Predicate closed(Provider dbProvider) { - List> r = new ArrayList>(4); + List> r = new ArrayList<>(4); for (final Change.Status e : Change.Status.values()) { if (e.isClosed()) { r.add(new ChangeStatusPredicate(e)); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/HasDraftByPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/HasDraftByPredicate.java index 6d44b9671b..53d2bbda2c 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/HasDraftByPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/HasDraftByPredicate.java @@ -25,6 +25,8 @@ import com.google.gwtorm.server.ResultSet; import java.util.ArrayList; import java.util.HashSet; +import java.util.List; +import java.util.Set; class HasDraftByPredicate extends OperatorPredicate implements ChangeDataSource { @@ -50,17 +52,17 @@ class HasDraftByPredicate extends OperatorPredicate implements @Override public ResultSet read() throws OrmException { - HashSet ids = new HashSet(); + Set ids = new HashSet<>(); for (PatchLineComment sc : args.db.get().patchComments() .draftByAuthor(accountId)) { ids.add(sc.getKey().getParentKey().getParentKey().getParentKey()); } - ArrayList r = new ArrayList(ids.size()); + List r = new ArrayList<>(ids.size()); for (Change.Id id : ids) { r.add(args.changeDataFactory.create(args.db.get(), id)); } - return new ListResultSet(r); + return new ListResultSet<>(r); } @Override diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/LegacyChangeIdPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/LegacyChangeIdPredicate.java index c62d7ca6a8..1cbb4998d9 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/LegacyChangeIdPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/LegacyChangeIdPredicate.java @@ -44,10 +44,10 @@ class LegacyChangeIdPredicate extends IndexPredicate implements public ResultSet read() throws OrmException { Change c = args.db.get().changes().get(id); if (c != null) { - return new ListResultSet(Collections.singletonList( + return new ListResultSet<>(Collections.singletonList( args.changeDataFactory.create(args.db.get(), c))); } else { - return new ListResultSet(Collections. emptyList()); + return new ListResultSet<>(Collections. emptyList()); } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OrSource.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OrSource.java index 4f36777401..28aef5e6bc 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OrSource.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OrSource.java @@ -24,6 +24,8 @@ import com.google.gwtorm.server.ResultSet; import java.util.ArrayList; import java.util.Collection; import java.util.HashSet; +import java.util.List; +import java.util.Set; public class OrSource extends OrPredicate implements ChangeDataSource { private int cardinality = -1; @@ -36,8 +38,8 @@ public class OrSource extends OrPredicate implements ChangeDataSourc public ResultSet read() throws OrmException { // TODO(spearce) This probably should be more lazy. // - ArrayList r = new ArrayList(); - HashSet have = new HashSet(); + List r = new ArrayList<>(); + Set have = new HashSet<>(); for (Predicate p : getChildren()) { if (p instanceof ChangeDataSource) { for (ChangeData cd : ((ChangeDataSource) p).read()) { @@ -49,7 +51,7 @@ public class OrSource extends OrPredicate implements ChangeDataSourc throw new OrmException("No ChangeDataSource: " + p); } } - return new ListResultSet(r); + return new ListResultSet<>(r); } @Override diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/QueryProcessor.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/QueryProcessor.java index 3320886342..8889f536dc 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/QueryProcessor.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/QueryProcessor.java @@ -551,7 +551,7 @@ public class QueryProcessor { } private List fieldsOf(Class type) { - List r = new ArrayList(); + List r = new ArrayList<>(); if (type.getSuperclass() != null) { r.addAll(fieldsOf(type.getSuperclass())); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/ReviewDbDatabaseProvider.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/ReviewDbDatabaseProvider.java index ed77fffed1..9ceaf1cecc 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/ReviewDbDatabaseProvider.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/ReviewDbDatabaseProvider.java @@ -36,7 +36,7 @@ final class ReviewDbDatabaseProvider implements Provider> { @Override public Database get() { try { - return new Database(datasource, ReviewDb.class); + return new Database<>(datasource, ReviewDb.class); } catch (OrmException e) { throw new ProvisionException("Cannot create ReviewDb", e); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_53.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_53.java index 16ca6645c8..697f3037a4 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_53.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_53.java @@ -123,7 +123,7 @@ class Schema_53 extends SchemaVersion { } private void assignGroupUUIDs(ReviewDb db) throws OrmException { - groupMap = new HashMap(); + groupMap = new HashMap<>(); List groups = db.accountGroups().all().toList(); for (AccountGroup g : groups) { if (g.getId().equals(systemConfig.ownerGroupId)) { @@ -244,7 +244,7 @@ class Schema_53 extends SchemaVersion { } private void readOldRefRights(ReviewDb db) throws SQLException { - rightsByProject = new HashMap>(); + rightsByProject = new HashMap<>(); Statement stmt = ((JdbcSchema) db).getConnection().createStatement(); ResultSet rs = stmt.executeQuery("SELECT * FROM ref_rights"); @@ -258,7 +258,7 @@ class Schema_53 extends SchemaVersion { list = rightsByProject.get(right.project); if (list == null) { - list = new ArrayList(); + list = new ArrayList<>(); rightsByProject.put(right.project, list); } list.add(right); @@ -268,7 +268,7 @@ class Schema_53 extends SchemaVersion { } private void readProjectParents(ReviewDb db) throws SQLException { - parentsByProject = new HashMap(); + parentsByProject = new HashMap<>(); Statement stmt = ((JdbcSchema) db).getConnection().createStatement(); ResultSet rs = stmt.executeQuery("SELECT * FROM projects"); while (rs.next()) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_56.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_56.java index bcd5f40289..852ca2aa7f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_56.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_56.java @@ -42,8 +42,8 @@ public class Schema_56 extends SchemaVersion { super(prior); this.mgr = mgr; - keysOne = new HashSet(); - keysTwo = new HashSet(); + keysOne = new HashSet<>(); + keysTwo = new HashSet<>(); keysOne.add(RefNames.REFS_CONFIG); keysTwo.add(RefNames.REFS_CONFIG); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_60.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_60.java index 3f49b0c1e5..7fe0cdede1 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_60.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_60.java @@ -40,7 +40,7 @@ public class Schema_60 extends SchemaVersion { Pattern patternA = Pattern.compile("Patch Set ([0-9]+):.*", Pattern.DOTALL); Pattern patternB = Pattern.compile("Uploaded patch set ([0-9]+)."); ResultSet results = db.changeMessages().all(); - List updates = new LinkedList(); + List updates = new LinkedList<>(); for (ChangeMessage cm : results) { Change.Id id = cm.getKey().getParentKey(); String msg = cm.getMessage(); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_74.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_74.java index 4a2c477fe9..e5480b4e75 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_74.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_74.java @@ -43,18 +43,15 @@ public class Schema_74 extends SchemaVersion { protected void migrateData(final ReviewDb db, final UpdateUI ui) throws SQLException, OrmException { // Grab all the groups since we don't have the cache available - HashMap allGroups = - new HashMap(); + HashMap allGroups = new HashMap<>(); for (AccountGroup ag : db.accountGroups().all()) { allGroups.put(ag.getId(), ag.getGroupUUID()); } // Initialize some variables Connection conn = ((JdbcSchema) db).getConnection(); - ArrayList newIncludes = - new ArrayList(); - ArrayList newIncludeAudits = - new ArrayList(); + ArrayList newIncludes = new ArrayList<>(); + ArrayList newIncludeAudits = new ArrayList<>(); // Iterate over all entries in account_group_includes Statement oldGroupIncludesStmt = conn.createStatement(); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/ScriptRunner.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/ScriptRunner.java index 12c80f4466..d03cb3e776 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/ScriptRunner.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/ScriptRunner.java @@ -78,7 +78,7 @@ class ScriptRunner { BufferedReader br = new BufferedReader(new InputStreamReader(in, "UTF-8")); try { String delimiter = ";"; - List commands = new ArrayList(); + List commands = new ArrayList<>(); StringBuilder buffer = new StringBuilder(); String line; while ((line = br.readLine()) != null) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/tools/ToolsCatalog.java b/gerrit-server/src/main/java/com/google/gerrit/server/tools/ToolsCatalog.java index a2b0ad174e..3e41858116 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/tools/ToolsCatalog.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/tools/ToolsCatalog.java @@ -69,7 +69,7 @@ public class ToolsCatalog { } private static SortedMap readToc() throws IOException { - SortedMap toc = new TreeMap(); + SortedMap toc = new TreeMap<>(); final BufferedReader br = new BufferedReader(new InputStreamReader(new ByteArrayInputStream( read("TOC")), "UTF-8")); @@ -81,7 +81,7 @@ public class ToolsCatalog { } } - final List all = new ArrayList(toc.values()); + final List all = new ArrayList<>(toc.values()); for (Entry e : all) { String path = dirOf(e.getPath()); while (path != null) { @@ -159,7 +159,7 @@ public class ToolsCatalog { if (type == Type.FILE) { this.children = Collections.emptyList(); } else { - this.children = new ArrayList(); + this.children = new ArrayList<>(); } } @@ -167,7 +167,7 @@ public class ToolsCatalog { this.type = type; this.mode = mode; this.path = path; - this.children = new ArrayList(); + this.children = new ArrayList<>(); } public Type getType() { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/util/SubmoduleSectionParser.java b/gerrit-server/src/main/java/com/google/gerrit/server/util/SubmoduleSectionParser.java index fbb3e930f4..8970425c02 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/util/SubmoduleSectionParser.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/util/SubmoduleSectionParser.java @@ -60,8 +60,7 @@ public class SubmoduleSectionParser { } public List parseAllSections() { - List parsedSubscriptions = - new ArrayList(); + List parsedSubscriptions = new ArrayList<>(); for (final String id : bbc.getSubsections("submodule")) { final SubmoduleSubscription subscription = parse(id); if (subscription != null) { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/util/ThreadLocalRequestContext.java b/gerrit-server/src/main/java/com/google/gerrit/server/util/ThreadLocalRequestContext.java index 2a67c9050d..f8bad77884 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/util/ThreadLocalRequestContext.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/util/ThreadLocalRequestContext.java @@ -72,8 +72,7 @@ public class ThreadLocalRequestContext { }; } - private static final ThreadLocal local = - new ThreadLocal(); + private static final ThreadLocal local = new ThreadLocal<>(); @Inject ThreadLocalRequestContext() { diff --git a/gerrit-server/src/test/java/com/google/gerrit/rules/PrologTestCase.java b/gerrit-server/src/test/java/com/google/gerrit/rules/PrologTestCase.java index 19edaf47b8..c6974005be 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/rules/PrologTestCase.java +++ b/gerrit-server/src/test/java/com/google/gerrit/rules/PrologTestCase.java @@ -57,7 +57,7 @@ public abstract class PrologTestCase { protected void load(String pkg, String prologResource, Module... modules) throws CompileException, IOException { - ArrayList moduleList = new ArrayList(); + ArrayList moduleList = new ArrayList<>(); moduleList.add(new PrologModule.EnvironmentModule()); moduleList.addAll(Arrays.asList(modules)); @@ -74,7 +74,7 @@ public abstract class PrologTestCase { SymbolTerm.intern(pkg), new StructureTerm(test_1, new VariableTerm())); - tests = new ArrayList(); + tests = new ArrayList<>(); for (Term[] pair : env.all(Prolog.BUILTIN, "clause", head, new VariableTerm())) { tests.add(pair[0]); } diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/change/CommentsTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/change/CommentsTest.java index 6c24f00662..8fdad6f0db 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/change/CommentsTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/change/CommentsTest.java @@ -158,7 +158,7 @@ public class CommentsTest { return new IAnswer>() { @Override public ResultSet answer() throws Throwable { - return new ListResultSet(Lists.newArrayList(comments)); + return new ListResultSet<>(Lists.newArrayList(comments)); }}; } diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/change/IncludedInResolverTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/change/IncludedInResolverTest.java index ae58819900..65eede6e75 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/change/IncludedInResolverTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/change/IncludedInResolverTest.java @@ -58,8 +58,8 @@ public class IncludedInResolverTest extends RepositoryTestCase { private RevCommit commit_v1_3; private RevCommit commit_v2_5; - private List expTags = new ArrayList(); - private List expBranches = new ArrayList(); + private List expTags = new ArrayList<>(); + private List expBranches = new ArrayList<>(); private RevWalk revWalk; diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/git/ProjectConfigTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/git/ProjectConfigTest.java index 7b3ede25bb..cc4a9e3542 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/git/ProjectConfigTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/git/ProjectConfigTest.java @@ -65,7 +65,7 @@ public class ProjectConfigTest extends LocalDiskRepositoryTestCase { public void setUp() throws Exception { super.setUp(); db = createBareRepository(); - util = new TestRepository(db); + util = new TestRepository<>(db); } @Test diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/git/SubmoduleOpTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/git/SubmoduleOpTest.java index 33ba36e4c3..f931dbfcb0 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/git/SubmoduleOpTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/git/SubmoduleOpTest.java @@ -127,7 +127,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { expect(schema.submoduleSubscriptions()).andReturn(subscriptions); final ResultSet emptySubscriptions = - new ListResultSet(new ArrayList()); + new ListResultSet<>(new ArrayList()); expect(subscriptions.bySubmodule(branchNameKey)).andReturn( emptySubscriptions); @@ -293,8 +293,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { new Branch.NameKey(new Project.NameKey("dest-project"), "refs/heads/master"); - final List subscriptionsToInsert = - new ArrayList(); + List subscriptionsToInsert = new ArrayList<>(); subscriptionsToInsert .add(new SubmoduleSubscription(mergedBranch, new Branch.NameKey( new Project.NameKey("source-a"), "refs/heads/master"), "source-a")); @@ -351,8 +350,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { new Branch.NameKey(new Project.NameKey("dest-project"), "refs/heads/master"); - final List subscriptionsToInsert = - new ArrayList(); + List subscriptionsToInsert = new ArrayList<>(); subscriptionsToInsert .add(new SubmoduleSubscription(mergedBranch, new Branch.NameKey( new Project.NameKey("source-a"), "refs/heads/master"), "source-a")); @@ -409,8 +407,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { new Branch.NameKey(new Project.NameKey("dest-project"), "refs/heads/master"); - final List subscriptionsToInsert = - new ArrayList(); + List subscriptionsToInsert = new ArrayList<>(); subscriptionsToInsert .add(new SubmoduleSubscription(mergedBranch, new Branch.NameKey( new Project.NameKey("source-a"), "refs/heads/test-a"), "source-a")); @@ -464,14 +461,12 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { new Branch.NameKey(new Project.NameKey("dest-project"), "refs/heads/master"); - final List subscriptionsToInsert = - new ArrayList(); + List subscriptionsToInsert = new ArrayList<>(); subscriptionsToInsert.add(new SubmoduleSubscription(mergedBranch, new Branch.NameKey(new Project.NameKey("source"), "refs/heads/master"), "source")); - final List oldOnesToMergedBranch = - new ArrayList(); + List oldOnesToMergedBranch = new ArrayList<>(); oldOnesToMergedBranch.add(new SubmoduleSubscription(mergedBranch, new Branch.NameKey(new Project.NameKey("old-source"), "refs/heads/master"), "old-source")); @@ -531,15 +526,13 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { new SubmoduleSubscription(mergedBranch, new Branch.NameKey(new Project.NameKey( "old"), "refs/heads/master"), "old"); - final List extractedsubscriptions = - new ArrayList(); + List extractedsubscriptions = new ArrayList<>(); extractedsubscriptions.add(new SubmoduleSubscription(mergedBranch, new Branch.NameKey(new Project.NameKey("new"), "refs/heads/master"), "new")); extractedsubscriptions.add(old); - final List oldOnesToMergedBranch = - new ArrayList(); + List oldOnesToMergedBranch = new ArrayList<>(); oldOnesToMergedBranch.add(old); doOnlySubscriptionTableOperations(sb.toString(), mergedBranch, @@ -564,11 +557,8 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { new Branch.NameKey(new Project.NameKey("dest-project"), "refs/heads/master"); - final List extractedsubscriptions = - new ArrayList(); - - final List oldOnesToMergedBranch = - new ArrayList(); + List extractedsubscriptions = new ArrayList<>(); + List oldOnesToMergedBranch = new ArrayList<>(); oldOnesToMergedBranch .add(new SubmoduleSubscription(mergedBranch, new Branch.NameKey( new Project.NameKey("source-a"), "refs/heads/master"), "source-a")); @@ -613,11 +603,10 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { new Change.Key(sourceMergeTip.toObjectId().getName()), new Change.Id(1), new Account.Id(1), sourceBranchNameKey, TimeUtil.nowTs()); - final Map mergedCommits = - new HashMap(); + final Map mergedCommits = new HashMap<>(); mergedCommits.put(submittedChange.getId(), codeReviewCommit); - final List submitted = new ArrayList(); + final List submitted = new ArrayList<>(); submitted.add(submittedChange); final Repository targetRepository = createWorkRepository(); @@ -635,7 +624,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { expect(schema.submoduleSubscriptions()).andReturn(subscriptions); final ResultSet subscribers = - new ListResultSet(Collections + new ListResultSet<>(Collections .singletonList(new SubmoduleSubscription(targetBranchNameKey, sourceBranchNameKey, "source-project"))); expect(subscriptions.bySubmodule(sourceBranchNameKey)).andReturn( @@ -644,13 +633,13 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { expect(repoManager.openRepository(targetBranchNameKey.getParentKey())) .andReturn(targetRepository).anyTimes(); - Capture ruCapture = new Capture(); + Capture ruCapture = new Capture<>(); gitRefUpdated.fire(eq(targetBranchNameKey.getParentKey()), capture(ruCapture)); expect(schema.submoduleSubscriptions()).andReturn(subscriptions); final ResultSet emptySubscriptions = - new ListResultSet(new ArrayList()); + new ListResultSet<>(new ArrayList()); expect(subscriptions.bySubmodule(targetBranchNameKey)).andReturn( emptySubscriptions); @@ -716,11 +705,10 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { new Change.Key(sourceMergeTip.toObjectId().getName()), new Change.Id(1), new Account.Id(1), sourceBranchNameKey, TimeUtil.nowTs()); - final Map mergedCommits = - new HashMap(); + final Map mergedCommits = new HashMap<>(); mergedCommits.put(submittedChange.getId(), codeReviewCommit); - final List submitted = new ArrayList(); + final List submitted = new ArrayList<>(); submitted.add(submittedChange); final Repository targetRepository = createWorkRepository(); @@ -738,7 +726,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { expect(schema.submoduleSubscriptions()).andReturn(subscriptions); final ResultSet subscribers = - new ListResultSet(Collections + new ListResultSet<>(Collections .singletonList(new SubmoduleSubscription(targetBranchNameKey, sourceBranchNameKey, "source-project"))); expect(subscriptions.bySubmodule(sourceBranchNameKey)).andReturn( @@ -747,7 +735,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { expect(repoManager.openRepository(targetBranchNameKey.getParentKey())) .andReturn(targetRepository).anyTimes(); - Capture ruCapture = new Capture(); + Capture ruCapture = new Capture<>(); gitRefUpdated.fire(eq(targetBranchNameKey.getParentKey()), capture(ruCapture)); @@ -803,8 +791,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { new Branch.NameKey(new Project.NameKey("dest-project"), "refs/heads/master"); - final List subscriptionsToInsert = - new ArrayList(); + List subscriptionsToInsert = new ArrayList<>(); subscriptionsToInsert.add(new SubmoduleSubscription(mergedBranch, new Branch.NameKey(new Project.NameKey("source"), sourceBranchName), "source")); @@ -878,10 +865,9 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { expect(schema.submoduleSubscriptions()).andReturn(subscriptions); expect(subscriptions.bySuperProject(mergedBranch)).andReturn( - new ListResultSet(previousSubscriptions)); + new ListResultSet<>(previousSubscriptions)); - SortedSet existingProjects = - new TreeSet(); + SortedSet existingProjects = new TreeSet<>(); for (SubmoduleSubscription extracted : extractedSubscriptions) { existingProjects.add(extracted.getSubmodule().getParentKey()); @@ -891,8 +877,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { expect(repoManager.list()).andReturn(existingProjects); } - final Set alreadySubscribeds = - new HashSet(); + final Set alreadySubscribeds = new HashSet<>(); for (SubmoduleSubscription s : extractedSubscriptions) { if (previousSubscriptions.contains(s)) { alreadySubscribeds.add(s); @@ -900,9 +885,9 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { } final Set subscriptionsToRemove = - new HashSet(previousSubscriptions); + new HashSet<>(previousSubscriptions); final List subscriptionsToInsert = - new ArrayList(extractedSubscriptions); + new ArrayList<>(extractedSubscriptions); subscriptionsToRemove.removeAll(subscriptionsToInsert); subscriptionsToInsert.removeAll(alreadySubscribeds); @@ -917,7 +902,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase { expect(schema.submoduleSubscriptions()).andReturn(subscriptions); expect(subscriptions.bySubmodule(mergedBranch)).andReturn( - new ListResultSet(new ArrayList())); + new ListResultSet<>(new ArrayList())); schema.close(); diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/index/FakeIndex.java b/gerrit-server/src/test/java/com/google/gerrit/server/index/FakeIndex.java index 4db3b27764..1b6ae4eb1d 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/index/FakeIndex.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/index/FakeIndex.java @@ -23,11 +23,11 @@ import com.google.gwtorm.server.OrmException; import com.google.gwtorm.server.ResultSet; class FakeIndex implements ChangeIndex { - static Schema V1 = new Schema(1, false, + static Schema V1 = new Schema<>(1, false, ImmutableList.> of( ChangeField.STATUS)); - static Schema V2 = new Schema(2, false, + static Schema V2 = new Schema<>(2, false, ImmutableList.of( ChangeField.STATUS, ChangeField.PATH, diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/index/FakeQueryBuilder.java b/gerrit-server/src/test/java/com/google/gerrit/server/index/FakeQueryBuilder.java index 2079d3d107..50e57642aa 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/index/FakeQueryBuilder.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/index/FakeQueryBuilder.java @@ -23,7 +23,7 @@ import com.google.gwtorm.server.OrmException; public class FakeQueryBuilder extends ChangeQueryBuilder { FakeQueryBuilder(IndexCollection indexes) { super( - new FakeQueryBuilder.Definition( + new FakeQueryBuilder.Definition<>( FakeQueryBuilder.class), new ChangeQueryBuilder.Arguments(null, null, null, null, null, null, null, null, null, null, null, null, null, null, indexes, null, null, diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/project/Util.java b/gerrit-server/src/test/java/com/google/gerrit/server/project/Util.java index ba33b97f0a..9ac8ba9c33 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/project/Util.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/project/Util.java @@ -140,7 +140,7 @@ public class Util { private final ProjectConfig parent = new ProjectConfig(allProjectsName); public Util() { - all = new HashMap(); + all = new HashMap<>(); repoManager = new InMemoryRepositoryManager(); try { Repository repo = repoManager.createRepository(allProjectsName); diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/util/IdGeneratorTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/util/IdGeneratorTest.java index 55464106e8..a2228d8019 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/util/IdGeneratorTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/util/IdGeneratorTest.java @@ -24,7 +24,7 @@ import static org.junit.Assert.assertTrue; public class IdGeneratorTest { @Test public void test1234() { - final HashSet seen = new HashSet(); + final HashSet seen = new HashSet<>(); for (int i = 0; i < 1 << 16; i++) { final int e = IdGenerator.mix(i); assertTrue("no duplicates", seen.add(e)); diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/util/SubmoduleSectionParserTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/util/SubmoduleSectionParserTest.java index edd7924121..d87888f212 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/util/SubmoduleSectionParserTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/util/SubmoduleSectionParserTest.java @@ -64,8 +64,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { @Test public void testSubmodulesParseWithCorrectSections() throws Exception { - final Map sectionsToReturn = - new TreeMap(); + final Map sectionsToReturn = new TreeMap<>(); sectionsToReturn.put("a", new SubmoduleSection("ssh://localhost/a", "a", ".")); sectionsToReturn.put("b", new SubmoduleSection("ssh://localhost/b", "b", @@ -77,7 +76,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { sectionsToReturn.put("e", new SubmoduleSection("ssh://localhost/e.git", "e", ".")); - final Map reposToBeFound = new HashMap(); + Map reposToBeFound = new HashMap<>(); reposToBeFound.put("a", "a"); reposToBeFound.put("b", "b"); reposToBeFound.put("c", "test/c"); @@ -88,8 +87,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { new Branch.NameKey(new Project.NameKey("super-project"), "refs/heads/master"); - final List expectedSubscriptions = - new ArrayList(); + List expectedSubscriptions = new ArrayList<>(); expectedSubscriptions .add(new SubmoduleSubscription(superBranchNameKey, new Branch.NameKey( new Project.NameKey("a"), "refs/heads/master"), "a")); @@ -112,8 +110,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { @Test public void testSubmodulesParseWithAnInvalidSection() throws Exception { - final Map sectionsToReturn = - new TreeMap(); + final Map sectionsToReturn = new TreeMap<>(); sectionsToReturn.put("a", new SubmoduleSection("ssh://localhost/a", "a", ".")); // This one is invalid since "b" is not a recognized project @@ -127,7 +124,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { ".")); // "b" will not be in this list - final Map reposToBeFound = new HashMap(); + Map reposToBeFound = new HashMap<>(); reposToBeFound.put("a", "a"); reposToBeFound.put("c", "test/c"); reposToBeFound.put("d", "d"); @@ -137,8 +134,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { new Branch.NameKey(new Project.NameKey("super-project"), "refs/heads/master"); - final List expectedSubscriptions = - new ArrayList(); + List expectedSubscriptions = new ArrayList<>(); expectedSubscriptions .add(new SubmoduleSubscription(superBranchNameKey, new Branch.NameKey( new Project.NameKey("a"), "refs/heads/master"), "a")); @@ -158,8 +154,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { @Test public void testSubmoduleSectionToOtherServer() throws Exception { - Map sectionsToReturn = - new HashMap(); + Map sectionsToReturn = new HashMap<>(); // The url is not to this server. sectionsToReturn.put("a", new SubmoduleSection("ssh://review.source.com/a", "a", ".")); @@ -171,8 +166,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { @Test public void testProjectNotFound() throws Exception { - Map sectionsToReturn = - new HashMap(); + Map sectionsToReturn = new HashMap<>(); sectionsToReturn.put("a", new SubmoduleSection("ssh://localhost/a", "a", ".")); @@ -183,8 +177,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { @Test public void testProjectWithSlashesNotFound() throws Exception { - Map sectionsToReturn = - new HashMap(); + Map sectionsToReturn = new HashMap<>(); sectionsToReturn.put("project", new SubmoduleSection( "ssh://localhost/company/tools/project", "project", ".")); @@ -222,12 +215,12 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase { } if (projectNameCandidate.equals(reposToBeFound.get(id))) { expect(repoManager.list()).andReturn( - new TreeSet(Collections - .singletonList(new Project.NameKey(projectNameCandidate)))); + new TreeSet<>(Collections.singletonList( + new Project.NameKey(projectNameCandidate)))); break; } else { expect(repoManager.list()).andReturn( - new TreeSet(Collections. emptyList())); + new TreeSet<>(Collections. emptyList())); } } } diff --git a/gerrit-server/src/test/java/com/google/gerrit/testutil/InMemoryDatabase.java b/gerrit-server/src/test/java/com/google/gerrit/testutil/InMemoryDatabase.java index bc344fa2c8..6353904681 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/testutil/InMemoryDatabase.java +++ b/gerrit-server/src/test/java/com/google/gerrit/testutil/InMemoryDatabase.java @@ -91,7 +91,7 @@ public class InMemoryDatabase implements SchemaFactory { // Build the access layer around the connection factory. // - database = new Database(dataSource, ReviewDb.class); + database = new Database<>(dataSource, ReviewDb.class); } catch (SQLException e) { throw new OrmException(e); diff --git a/gerrit-server/src/test/java/com/google/gerrit/testutil/MockingTestCase.java b/gerrit-server/src/test/java/com/google/gerrit/testutil/MockingTestCase.java index f0c7ce139e..569a57f784 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/testutil/MockingTestCase.java +++ b/gerrit-server/src/test/java/com/google/gerrit/testutil/MockingTestCase.java @@ -138,8 +138,8 @@ public abstract class MockingTestCase extends TestCase { usePowerMock = PowerMockRunner.class.isAssignableFrom(runWith.value()); } - mocks = new ArrayList(); - mockControls = new ArrayList(); + mocks = new ArrayList<>(); + mockControls = new ArrayList<>(); mocksReplayed = false; } diff --git a/gerrit-server/src/test/java/com/google/gerrit/testutil/SetMatcher.java b/gerrit-server/src/test/java/com/google/gerrit/testutil/SetMatcher.java index 2e6b68ecc3..f1e7b7bcff 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/testutil/SetMatcher.java +++ b/gerrit-server/src/test/java/com/google/gerrit/testutil/SetMatcher.java @@ -29,7 +29,7 @@ import java.util.Set; */ public class SetMatcher implements IArgumentMatcher { public static ,T> S setEq(S expected) { - EasyMock.reportMatcher(new SetMatcher(expected)); + EasyMock.reportMatcher(new SetMatcher<>(expected)); return null; } diff --git a/gerrit-server/src/test/java/com/google/gerrit/testutil/log/CollectionAppender.java b/gerrit-server/src/test/java/com/google/gerrit/testutil/log/CollectionAppender.java index 43179e33ca..05f52c0186 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/testutil/log/CollectionAppender.java +++ b/gerrit-server/src/test/java/com/google/gerrit/testutil/log/CollectionAppender.java @@ -29,7 +29,7 @@ public class CollectionAppender extends AppenderSkeleton { private Collection events; public CollectionAppender() { - events = new LinkedList(); + events = new LinkedList<>(); } public CollectionAppender(Collection events) { diff --git a/gerrit-server/src/test/java/com/google/gerrit/testutil/log/LogUtil.java b/gerrit-server/src/test/java/com/google/gerrit/testutil/log/LogUtil.java index f8b73fb6c3..e3c83ca782 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/testutil/log/LogUtil.java +++ b/gerrit-server/src/test/java/com/google/gerrit/testutil/log/LogUtil.java @@ -59,7 +59,7 @@ public class LogUtil { this.additive = logger.getAdditivity(); Enumeration appenders = logger.getAllAppenders(); - this.appenders = new ArrayList(); + this.appenders = new ArrayList<>(); while (appenders.hasMoreElements()) { Object appender = appenders.nextElement(); if (appender instanceof Appender) { diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/CommandFactoryProvider.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/CommandFactoryProvider.java index a2e65424bd..f394766b43 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/CommandFactoryProvider.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/CommandFactoryProvider.java @@ -246,7 +246,7 @@ class CommandFactoryProvider implements Provider, /** Split a command line into a string array. */ static public String[] split(String commandLine) { - final List list = new ArrayList(); + final List list = new ArrayList<>(); boolean inquote = false; boolean inDblQuote = false; StringBuilder r = new StringBuilder(); diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DatabasePubKeyAuth.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DatabasePubKeyAuth.java index 9354da367d..cc7b637321 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DatabasePubKeyAuth.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DatabasePubKeyAuth.java @@ -77,7 +77,7 @@ class DatabasePubKeyAuth implements PublickeyAuthenticator { } private static Set myHostKeys(KeyPairProvider p) { - final Set keys = new HashSet(2); + final Set keys = new HashSet<>(2); addPublicKey(keys, p, KeyPairProvider.SSH_RSA); addPublicKey(keys, p, KeyPairProvider.SSH_DSS); return keys; @@ -183,7 +183,7 @@ class DatabasePubKeyAuth implements PublickeyAuthenticator { try { final BufferedReader br = new BufferedReader(new FileReader(path)); try { - final Set keys = new HashSet(); + final Set keys = new HashSet<>(); String line; while ((line = br.readLine()) != null) { line = line.trim(); diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommand.java index fa5ab53ea7..a7748ffa99 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/DispatchCommand.java @@ -52,7 +52,7 @@ final class DispatchCommand extends BaseCommand { private String commandName; @Argument(index = 1, multiValued = true, metaVar = "ARG") - private List args = new ArrayList(); + private List args = new ArrayList<>(); @Inject DispatchCommand(final Provider cu, diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/HostKeyProvider.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/HostKeyProvider.java index f901a776ac..241f853412 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/HostKeyProvider.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/HostKeyProvider.java @@ -42,7 +42,7 @@ class HostKeyProvider implements Provider { final File rsaKey = site.ssh_rsa; final File dsaKey = site.ssh_dsa; - final List stdKeys = new ArrayList(2); + final List stdKeys = new ArrayList<>(2); if (rsaKey.exists()) { stdKeys.add(rsaKey.getAbsolutePath()); } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshDaemon.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshDaemon.java index 11c58c87d5..6f3417260c 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshDaemon.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshDaemon.java @@ -343,7 +343,7 @@ public class SshDaemon extends SshServer implements SshInfo, LifecycleListener { } final List keys = myHostKeys(); - final ArrayList r = new ArrayList(); + final List r = new ArrayList<>(); for (final PublicKey pub : keys) { final Buffer buf = new Buffer(); buf.putRawPublicKey(pub); @@ -362,7 +362,7 @@ public class SshDaemon extends SshServer implements SshInfo, LifecycleListener { private List myHostKeys() { final KeyPairProvider p = getKeyPairProvider(); - final List keys = new ArrayList(2); + final List keys = new ArrayList<>(2); addPublicKey(keys, p, KeyPairProvider.SSH_RSA); addPublicKey(keys, p, KeyPairProvider.SSH_DSS); return keys; @@ -402,7 +402,7 @@ public class SshDaemon extends SshServer implements SshInfo, LifecycleListener { @SuppressWarnings("unchecked") private void initCiphers(final Config cfg) { - final List> a = new LinkedList>(); + final List> a = new LinkedList<>(); a.add(new AES128CBC.Factory()); a.add(new TripleDESCBC.Factory()); a.add(new BlowfishCBC.Factory()); @@ -445,7 +445,7 @@ public class SshDaemon extends SshServer implements SshInfo, LifecycleListener { @SafeVarargs private static List> filter(final Config cfg, final String key, final NamedFactory... avail) { - final ArrayList> def = new ArrayList>(); + final ArrayList> def = new ArrayList<>(); for (final NamedFactory n : avail) { if (n == null) { break; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshKeyCacheImpl.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshKeyCacheImpl.java index 0a1f708b44..2ec67a44d5 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshKeyCacheImpl.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshKeyCacheImpl.java @@ -135,7 +135,7 @@ public class SshKeyCacheImpl implements SshKeyCache { return NO_SUCH_USER; } - final List kl = new ArrayList(4); + final List kl = new ArrayList<>(4); for (AccountSshKey k : db.accountSshKeys().byAccount( user.getAccountId())) { if (k.isValid()) { diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshScope.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshScope.java index 9067b9b6b1..f8b5ddb004 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshScope.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshScope.java @@ -144,8 +144,7 @@ public class SshScope { } } - private static final ThreadLocal current = - new ThreadLocal(); + private static final ThreadLocal current = new ThreadLocal<>(); private static Context requireContext() { final Context ctx = current.get(); diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshSession.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshSession.java index 04bf6038e5..2e3d1132f3 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshSession.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshSession.java @@ -26,8 +26,7 @@ import java.net.SocketAddress; /** Global data related to an active SSH connection. */ public class SshSession { /** ServerSession attribute key for this object instance. */ - public static final AttributeKey KEY = - new AttributeKey(); + public static final AttributeKey KEY = new AttributeKey<>(); private final int sessionId; private final SocketAddress remoteAddress; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SuExec.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SuExec.java index 298a0993bb..77738d07d5 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SuExec.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/SuExec.java @@ -59,7 +59,7 @@ public final class SuExec extends BaseCommand { private SocketAddress peerAddress; @Argument(index = 0, multiValued = true, metaVar = "COMMAND") - private List args = new ArrayList(); + private List args = new ArrayList<>(); private final AtomicReference atomicCmd; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/AdminSetParent.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/AdminSetParent.java index 8db6431145..d448bd2dce 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/AdminSetParent.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/AdminSetParent.java @@ -63,11 +63,11 @@ final class AdminSetParent extends SshCommand { @Option(name = "--exclude", metaVar = "NAME", usage = "child project of old parent project which should not be reparented") - private List excludedChildren = new ArrayList(); + private List excludedChildren = new ArrayList<>(); @Argument(index = 0, required = false, multiValued = true, metaVar = "NAME", usage = "projects to modify") - private List children = new ArrayList(); + private List children = new ArrayList<>(); @Inject private ProjectCache projectCache; @@ -95,7 +95,7 @@ final class AdminSetParent extends SshCommand { } final StringBuilder err = new StringBuilder(); - final Set grandParents = new HashSet(); + final Set grandParents = new HashSet<>(); grandParents.add(allProjectsName); @@ -187,12 +187,12 @@ final class AdminSetParent extends SshCommand { private List getChildrenForReparenting(final ProjectControl parent) { final List childProjects = Lists.newArrayList(); final List excluded = - new ArrayList(excludedChildren.size()); + new ArrayList<>(excludedChildren.size()); for (final ProjectControl excludedChild : excludedChildren) { excluded.add(excludedChild.getProject().getNameKey()); } final List automaticallyExcluded = - new ArrayList(excludedChildren.size()); + new ArrayList<>(excludedChildren.size()); if (newParentKey != null) { automaticallyExcluded.addAll(getAllParents(newParentKey)); } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/BanCommitCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/BanCommitCommand.java index 1d4b9000a5..da850ed0ab 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/BanCommitCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/BanCommitCommand.java @@ -47,7 +47,7 @@ public class BanCommitCommand extends SshCommand { @Argument(index = 1, required = true, multiValued = true, metaVar = "COMMIT", usage = "commit(s) that should be banned") - private List commitsToBan = new ArrayList(); + private List commitsToBan = new ArrayList<>(); @Inject private BanCommit.Factory banCommitFactory; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateAccountCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateAccountCommand.java index aef1560d01..aeb69d0c76 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateAccountCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateAccountCommand.java @@ -42,7 +42,7 @@ import java.util.List; @CommandMetaData(name = "create-account", description = "Create a new batch/role account") final class CreateAccountCommand extends SshCommand { @Option(name = "--group", aliases = {"-g"}, metaVar = "GROUP", usage = "groups to add account to") - private List groups = new ArrayList(); + private List groups = new ArrayList<>(); @Option(name = "--full-name", metaVar = "NAME", usage = "display name of the account") private String fullName; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateGroupCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateGroupCommand.java index 91996b160f..75194dcb57 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateGroupCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateGroupCommand.java @@ -53,7 +53,7 @@ final class CreateGroupCommand extends SshCommand { @Argument(index = 0, required = true, metaVar = "GROUP", usage = "name of group to be created") private String groupName; - private final Set initialMembers = new HashSet(); + private final Set initialMembers = new HashSet<>(); @Option(name = "--member", aliases = {"-m"}, metaVar = "USERNAME", usage = "initial set of users to become members of the group") void addMember(final Account.Id id) { @@ -63,7 +63,7 @@ final class CreateGroupCommand extends SshCommand { @Option(name = "--visible-to-all", usage = "to make the group visible to all registered users") private boolean visibleToAll; - private final Set initialGroups = new HashSet(); + private final Set initialGroups = new HashSet<>(); @Option(name = "--group", aliases = "-g", metaVar = "GROUP", usage = "initial set of groups to be included in the group") void addGroup(final AccountGroup.UUID id) { diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/FlushCaches.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/FlushCaches.java index 40152b0999..1de463626c 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/FlushCaches.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/FlushCaches.java @@ -39,7 +39,7 @@ final class FlushCaches extends CacheCommand { private static final String WEB_SESSIONS = "web_sessions"; @Option(name = "--cache", usage = "flush named cache", metaVar = "NAME") - private List caches = new ArrayList(); + private List caches = new ArrayList<>(); @Option(name = "--all", usage = "flush all caches") private boolean all; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/GarbageCollectionCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/GarbageCollectionCommand.java index 821701d5f6..a1099dc0bb 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/GarbageCollectionCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/GarbageCollectionCommand.java @@ -51,7 +51,7 @@ public class GarbageCollectionCommand extends BaseCommand { @Argument(index = 0, required = false, multiValued = true, metaVar = "NAME", usage = "projects for which the Git garbage collection should be run") - private List projects = new ArrayList(); + private List projects = new ArrayList<>(); @Inject private ProjectCache projectCache; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/KillCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/KillCommand.java index 83e88e55b0..d8c3403f58 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/KillCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/KillCommand.java @@ -35,7 +35,7 @@ final class KillCommand extends SshCommand { @Inject private WorkQueue workQueue; - private final Set taskIds = new HashSet(); + private final Set taskIds = new HashSet<>(); @Argument(index = 0, multiValued = true, required = true, metaVar = "ID") void addTaskId(final String taskId) { diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/QueryShell.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/QueryShell.java index 77c5df458d..39ec81f57a 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/QueryShell.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/QueryShell.java @@ -306,7 +306,7 @@ public class QueryShell { try { ResultSet rs = meta.getIndexInfo(null, null, tableName, false, true); try { - Map indexes = new TreeMap(); + Map indexes = new TreeMap<>(); while (rs.next()) { final String indexName = rs.getString("INDEX_NAME"); IndexInfo def = indexes.get(indexName); @@ -550,7 +550,7 @@ public class QueryShell { widths[c] = columnMap[c].name.length(); } - final List rows = new ArrayList(); + final List rows = new ArrayList<>(); while (alreadyOnRow || rs.next()) { final String[] row = new String[columnMap.length]; for (int c = 0; c < colCnt; c++) { @@ -759,7 +759,7 @@ public class QueryShell { private static class IndexInfo { String name; boolean unique; - final Map columns = new TreeMap(); + final Map columns = new TreeMap<>(); final StringBuilder filter = new StringBuilder(); void addColumn(int pos, String column) { diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/Receive.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/Receive.java index a3c2cf546d..abb788dee4 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/Receive.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/Receive.java @@ -70,8 +70,8 @@ final class Receive extends AbstractGitCommand { @Inject private DynamicSet postReceiveHooks; - private final Set reviewerId = new HashSet(); - private final Set ccId = new HashSet(); + private final Set reviewerId = new HashSet<>(); + private final Set ccId = new HashSet<>(); @Option(name = "--reviewer", aliases = {"--re"}, metaVar = "EMAIL", usage = "request reviewer for change(s)") void addReviewer(final Account.Id id) { @@ -158,7 +158,7 @@ final class Receive extends AbstractGitCommand { Map allRefs = rp.getRepository().getRefDatabase().getRefs(RefDatabase.ALL); - List hidden = new ArrayList(); + List hidden = new ArrayList<>(); for (Ref ref : allRefs.values()) { if (!adv.containsKey(ref.getName())) { hidden.add(ref); diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java index e30d41bece..107394b1d8 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java @@ -73,7 +73,7 @@ public class ReviewCommand extends SshCommand { return parser; } - private final Set patchSets = new HashSet(); + private final Set patchSets = new HashSet<>(); @Argument(index = 0, required = true, multiValued = true, metaVar = "{COMMIT | CHANGE,PATCHSET}", usage = "list of commits or patch sets to review") void addPatchSetId(final String token) { @@ -282,7 +282,7 @@ public class ReviewCommand extends SshCommand { patches = db.patchSets().byRevisionRange(id, id.max()); } - final Set matches = new HashSet(); + final Set matches = new HashSet<>(); for (final PatchSet ps : patches) { final Change change = db.changes().get(ps.getId().getParentKey()); if (inProject(change) && inBranch(change)) { @@ -348,7 +348,7 @@ public class ReviewCommand extends SshCommand { @Override protected void parseCommandLine() throws UnloggedFailure { - optionList = new ArrayList(); + optionList = new ArrayList<>(); customLabels = Maps.newHashMap(); ProjectControl allProjectsControl; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetAccountCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetAccountCommand.java index f3f35db4b1..5088424102 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetAccountCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetAccountCommand.java @@ -71,16 +71,16 @@ final class SetAccountCommand extends BaseCommand { private boolean inactive; @Option(name = "--add-email", metaVar = "EMAIL", usage = "email addresses to add to the account") - private List addEmails = new ArrayList(); + private List addEmails = new ArrayList<>(); @Option(name = "--delete-email", metaVar = "EMAIL", usage = "email addresses to delete from the account") - private List deleteEmails = new ArrayList(); + private List deleteEmails = new ArrayList<>(); @Option(name = "--add-ssh-key", metaVar = "-|KEY", usage = "public keys to add to the account") - private List addSshKeys = new ArrayList(); + private List addSshKeys = new ArrayList<>(); @Option(name = "--delete-ssh-key", metaVar = "-|KEY", usage = "public keys to delete from the account") - private List deleteSshKeys = new ArrayList(); + private List deleteSshKeys = new ArrayList<>(); @Option(name = "--http-password", metaVar = "PASSWORD", usage = "password for HTTP authentication for the account") private String httpPassword; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java index 41d3e97c5f..8ce935c0bd 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java @@ -56,7 +56,7 @@ public class SetReviewersCommand extends SshCommand { private ProjectControl projectControl; @Option(name = "--add", aliases = {"-a"}, metaVar = "REVIEWER", usage = "user or group that should be added as reviewer") - private List toAdd = new ArrayList(); + private List toAdd = new ArrayList<>(); @Option(name = "--remove", aliases = {"-r"}, metaVar = "REVIEWER", usage = "user that should be removed from the reviewer list") void optionRemove(Account.Id who) { @@ -92,8 +92,8 @@ public class SetReviewersCommand extends SshCommand { @Inject private ChangesCollection changesCollection; - private Set toRemove = new HashSet(); - private Set changes = new HashSet(); + private Set toRemove = new HashSet<>(); + private Set changes = new HashSet<>(); @Override protected void run() throws UnloggedFailure { @@ -161,7 +161,7 @@ public class SetReviewersCommand extends SshCommand { private Set parseChangeId(String idstr) throws UnloggedFailure, OrmException { - Set matched = new HashSet(4); + Set matched = new HashSet<>(4); boolean isCommit = idstr.matches("^([0-9a-fA-F]{4," + RevId.LEN + "})$"); // By newer style changeKey? diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ShowConnections.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ShowConnections.java index 536ad88249..3d1ed3f074 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ShowConnections.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ShowConnections.java @@ -86,7 +86,7 @@ final class ShowConnections extends SshCommand { } final List list = - new ArrayList(acceptor.getManagedSessions().values()); + new ArrayList<>(acceptor.getManagedSessions().values()); Collections.sort(list, new Comparator() { @Override public int compare(IoSession arg0, IoSession arg1) { diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StreamEvents.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StreamEvents.java index c55c7ed24a..6da858a867 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StreamEvents.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StreamEvents.java @@ -59,7 +59,7 @@ final class StreamEvents extends BaseCommand { /** Queue of events to stream to the connected user. */ private final LinkedBlockingQueue queue = - new LinkedBlockingQueue(MAX_EVENTS); + new LinkedBlockingQueue<>(MAX_EVENTS); private final Gson gson = new Gson(); diff --git a/gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/CmdLineParser.java b/gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/CmdLineParser.java index 7fc6d6f8e1..c60c0d28e0 100644 --- a/gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/CmdLineParser.java +++ b/gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/CmdLineParser.java @@ -131,7 +131,7 @@ public class CmdLineParser { out.write(name); char next = '?'; - List booleans = new ArrayList(); + List booleans = new ArrayList<>(); for (@SuppressWarnings("rawtypes") OptionHandler handler : parser.options) { if (handler.option instanceof NamedOptionDef) { NamedOptionDef n = (NamedOptionDef) handler.option; diff --git a/gerrit-war/src/main/java/com/google/gerrit/httpd/WebAppInitializer.java b/gerrit-war/src/main/java/com/google/gerrit/httpd/WebAppInitializer.java index 78d5fff682..abc5ae30ad 100644 --- a/gerrit-war/src/main/java/com/google/gerrit/httpd/WebAppInitializer.java +++ b/gerrit-war/src/main/java/com/google/gerrit/httpd/WebAppInitializer.java @@ -201,7 +201,7 @@ public class WebAppInitializer extends GuiceServletContextListener } private Injector createDbInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); if (sitePath != null) { Module sitePathModule = new AbstractModule() { @Override @@ -249,7 +249,7 @@ public class WebAppInitializer extends GuiceServletContextListener } private Injector createCfgInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); if (sitePath == null) { // If we didn't get the site path from the system property // we need to get it from the database, as that's our old @@ -272,7 +272,7 @@ public class WebAppInitializer extends GuiceServletContextListener } private Injector createSysInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); modules.add(new WorkQueue.Module()); modules.add(new ChangeHookRunner.Module()); modules.add(new ReceiveCommitsExecutorModule()); @@ -314,7 +314,7 @@ public class WebAppInitializer extends GuiceServletContextListener } private Injector createSshInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); modules.add(sysInjector.getInstance(SshModule.class)); modules.add(new SshHostKeyModule()); modules.add(new DefaultCommandModule(false)); @@ -322,7 +322,7 @@ public class WebAppInitializer extends GuiceServletContextListener } private Injector createWebInjector() { - final List modules = new ArrayList(); + final List modules = new ArrayList<>(); modules.add(RequestContextFilter.module()); modules.add(AllRequestFilter.module()); modules.add(sysInjector.getInstance(GitOverHttpModule.class)); diff --git a/lib/asciidoctor/java/AsciiDoctor.java b/lib/asciidoctor/java/AsciiDoctor.java index 933b929310..9e48641950 100644 --- a/lib/asciidoctor/java/AsciiDoctor.java +++ b/lib/asciidoctor/java/AsciiDoctor.java @@ -58,10 +58,10 @@ public class AsciiDoctor { @Option(name = "-a", usage = "a list of attributes, in the form key or key=value pair") - private List attributes = new ArrayList(); + private List attributes = new ArrayList<>(); @Argument(usage = "input files") - private List inputFiles = new ArrayList(); + private List inputFiles = new ArrayList<>(); public static String mapInFileToOutFile( String inFile, String inExt, String outExt) { @@ -97,7 +97,7 @@ public class AsciiDoctor { } private Map getAttributes() { - Map attributeValues = new HashMap(); + Map attributeValues = new HashMap<>(); for (String attribute : attributes) { int equalsIndex = attribute.indexOf('='); diff --git a/lib/asciidoctor/java/DocIndexer.java b/lib/asciidoctor/java/DocIndexer.java index cf44662ca4..4bcddbbe8c 100644 --- a/lib/asciidoctor/java/DocIndexer.java +++ b/lib/asciidoctor/java/DocIndexer.java @@ -67,7 +67,7 @@ public class DocIndexer { private String outExt = ".html"; @Argument(usage = "input files") - private List inputFiles = new ArrayList(); + private List inputFiles = new ArrayList<>(); private void invoke(String... parameters) throws IOException { CmdLineParser parser = new CmdLineParser(this);