Fix GroupListScreen to not extend AccountScreen
The only reason this extended AccountScreen was to set require signed in to true. This can be trivially done in the constructor. Although its one line of code longer, it makes more sense. A list of arbitrary internal groups does not pertain to a single user account. Change-Id: Ifc78eb10f0d0dac68df49688a21e55b9245646e2
This commit is contained in:
@@ -19,8 +19,8 @@ import static com.google.gerrit.common.PageLinks.ADMIN_GROUPS;
|
||||
import com.google.gerrit.client.Gerrit;
|
||||
import com.google.gerrit.client.groups.GroupMap;
|
||||
import com.google.gerrit.client.rpc.GerritCallback;
|
||||
import com.google.gerrit.client.ui.AccountScreen;
|
||||
import com.google.gerrit.client.ui.Hyperlink;
|
||||
import com.google.gerrit.client.ui.Screen;
|
||||
import com.google.gerrit.common.PageLinks;
|
||||
import com.google.gerrit.reviewdb.client.AccountGeneralPreferences;
|
||||
import com.google.gwt.event.dom.client.KeyCodes;
|
||||
@@ -31,7 +31,7 @@ import com.google.gwt.user.client.ui.HorizontalPanel;
|
||||
import com.google.gwt.user.client.ui.Label;
|
||||
import com.google.gwtexpui.globalkey.client.NpTextBox;
|
||||
|
||||
public class GroupListScreen extends AccountScreen {
|
||||
public class GroupListScreen extends Screen {
|
||||
private Hyperlink prev;
|
||||
private Hyperlink next;
|
||||
private GroupTable groups;
|
||||
@@ -43,10 +43,12 @@ public class GroupListScreen extends AccountScreen {
|
||||
private Query query;
|
||||
|
||||
public GroupListScreen() {
|
||||
setRequiresSignIn(true);
|
||||
configurePageSize();
|
||||
}
|
||||
|
||||
public GroupListScreen(String params) {
|
||||
this();
|
||||
for (String kvPair : params.split("[,;&]")) {
|
||||
String[] kv = kvPair.split("=", 2);
|
||||
if (kv.length != 2 || kv[0].isEmpty()) {
|
||||
@@ -61,7 +63,6 @@ public class GroupListScreen extends AccountScreen {
|
||||
start = Integer.parseInt(URL.decodeQueryString(kv[1]));
|
||||
}
|
||||
}
|
||||
configurePageSize();
|
||||
}
|
||||
|
||||
private void configurePageSize() {
|
||||
|
||||
Reference in New Issue
Block a user