opendev/gerrit
Code Issues Proposed changes

Remove redundant 'final' modifiers

Browse Source 
The 'final' modifier is redundant on private members, and
on members of 'final' classes.

Change-Id: Ib89f00f3c839cc58be26bc58a2acae8d095bcbc7
This commit is contained in:
David Pursehouse
2016-04-12 10:45:26 +09:00
parent cbc52bd366
commit e7996de77f
15 changed files with 68 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ApiGlue.java
View File

@@ -236,14 +236,14 @@ public class ApiGlue {
}
}
private static final String getPluginName() {
private static String getPluginName() {
if (pluginName != null) {
return pluginName;
}
return PluginName.fromUrl(PluginName.getCallerUrl());
}
private static final void go(String urlOrToken) {
private static void go(String urlOrToken) {
if (urlOrToken.startsWith("http:")
|| urlOrToken.startsWith("https:")
|| urlOrToken.startsWith("//")) {
@@ -253,35 +253,35 @@ public class ApiGlue {
}
}
private static final void refresh() {
private static void refresh() {
Gerrit.display(History.getToken());
}
private static final ServerInfo getServerInfo() {
private static ServerInfo getServerInfo() {
return Gerrit.info();
}
private static final AccountInfo getCurrentUser() {
private static AccountInfo getCurrentUser() {
return Gerrit.getUserAccount();
}
private static final GeneralPreferences getUserPreferences() {
private static GeneralPreferences getUserPreferences() {
return Gerrit.getUserPreferences();
}
private static final void refreshUserPreferences() {
private static void refreshUserPreferences() {
Gerrit.refreshUserPreferences();
}
private static final void refreshMenuBar() {
private static void refreshMenuBar() {
Gerrit.refreshMenuBar();
}
private static final boolean isSignedIn() {
private static boolean isSignedIn() {
return Gerrit.isSignedIn();
}
private static final void showError(String message) {
private static void showError(String message) {
new ErrorDialog(message).center();
}

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/HtmlTemplate.java
View File

@@ -62,19 +62,19 @@ final class HtmlTemplate {
};
}-*/;
private static final String css(String css) {
private static String css(String css) {
String name = DOM.createUniqueId();
StyleInjector.inject("." + name + "{" + css + "}");
return name;
}
private static final String id(IdMap idMap, String key) {
private static String id(IdMap idMap, String key) {
String id = DOM.createUniqueId();
idMap.put(id, key);
return " id='" + id + "'";
}
private static final String html(ReplacementMap opts, String id) {
private static String html(ReplacementMap opts, String id) {
int d = id.indexOf('.');
if (0 < d) {
String name = id.substring(0, d);
@@ -84,7 +84,7 @@ final class HtmlTemplate {
return new SafeHtmlBuilder().append(opts.str(id)).asString();
}
private static final Node parseHtml(
private static Node parseHtml(
String html,
IdMap ids,
ReplacementMap opts,

14
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/Plugin.java
View File

@@ -26,14 +26,14 @@ final class Plugin extends JavaScriptObject {
return create(TYPE, url, name);
}
final native String url() /*-{ return this._scriptUrl }-*/;
final native String name() /*-{ return this.name }-*/;
native String url() /*-{ return this._scriptUrl }-*/;
native String name() /*-{ return this.name }-*/;
final native boolean loaded() /*-{ return this._success || this._failure != null }-*/;
final native Exception failure() /*-{ return this._failure }-*/;
final native void failure(Exception e) /*-{ this._failure = e }-*/;
final native boolean success() /*-{ return this._success || false }-*/;
final native void _initialized() /*-{ this._success = true }-*/;
native boolean loaded() /*-{ return this._success || this._failure != null }-*/;
native Exception failure() /*-{ return this._failure }-*/;
native void failure(Exception e) /*-{ this._failure = e }-*/;
native boolean success() /*-{ return this._success || false }-*/;
native void _initialized() /*-{ this._success = true }-*/;
private static native Plugin create(JavaScriptObject T, String u, String n)
/*-{ return new T(u,n) }-*/;