Merge changes Icb5f77c9,Iae59a403

* changes:
  SideBySide2: Draw a line under the file header when "fullscreen"
  SideBySide2: Simplify logic for showing/hiding header

gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java

@@ -14,6 +14,7 @@
 
 package com.google.gerrit.client.diff;
 
+import com.google.gerrit.client.Gerrit;
 import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo;
 import com.google.gerrit.reviewdb.client.PatchSet;
 import com.google.gwt.core.client.GWT;
@@ -36,6 +37,7 @@ class DiffTable extends Composite {
   private static final Binder uiBinder = GWT.create(Binder.class);
 
   interface DiffTableStyle extends CssResource {
+    String fullscreen();
     String intralineBg();
     String diff();
     String activeLine();
@@ -100,13 +102,16 @@ class DiffTable extends Composite {
     this.host = host;
   }
 
-  void updateFileCommentVisibility(boolean forceHide) {
-    UIObject.setVisible(patchSetNavRow, !forceHide);
-    if (forceHide || (fileCommentPanelA.getBoxCount() == 0 &&
-        fileCommentPanelB.getBoxCount() == 0)) {
-      UIObject.setVisible(fileCommentRow, false);
+  void setHeaderVisible(boolean show) {
+    Gerrit.setHeaderVisible(show);
+    UIObject.setVisible(patchSetNavRow, show);
+    UIObject.setVisible(fileCommentRow, show
+        && (fileCommentPanelA.getBoxCount() > 0
+            || fileCommentPanelB.getBoxCount() > 0));
+    if (show) {
+      host.header.removeStyleName(style.fullscreen());
     } else {
-      UIObject.setVisible(fileCommentRow, true);
+      host.header.addStyleName(style.fullscreen());
     }
     host.resizeCodeMirror();
   }
@@ -117,7 +122,7 @@ class DiffTable extends Composite {
 
   void createOrEditFileComment(DisplaySide side) {
     getPanelFromSide(side).createOrEditFileComment();
-    updateFileCommentVisibility(false);
+    setHeaderVisible(true);
   }
 
   void addFileCommentBox(CommentBox box) {

gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.ui.xml

@@ -23,6 +23,10 @@ limitations under the License.
     @external .cm-keymap-fat-cursor, CodeMirror-cursor;
     @external .cm-searching, .cm-trailingspace, .cm-tab;
 
+    .fullscreen {
+      border-bottom: 1px solid #ddd;
+    }
+
     .difftable { max-width: 1484px; }
     .difftable .CodeMirror-lines { padding: 0; }
     .difftable .CodeMirror pre {

gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/FileCommentPanel.java

@@ -74,11 +74,11 @@ class FileCommentPanel extends Composite {
   void addFileComment(CommentBox box) {
     boxes.add(box);
     body.add(box);
-    table.updateFileCommentVisibility(false);
+    table.setHeaderVisible(true);
   }
 
   void onRemoveDraftBox(DraftBox box) {
     boxes.remove(box);
-    table.updateFileCommentVisibility(false);
+    table.setHeaderVisible(true);
   }
 }

gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/ScrollSynchronizer.java

@@ -39,12 +39,10 @@ class ScrollSynchronizer {
 
   private void updateScreenHeader(ScrollInfo si) {
     if (si.getTop() == 0 && !Gerrit.isHeaderVisible()) {
-      Gerrit.setHeaderVisible(true);
-      diffTable.updateFileCommentVisibility(false);
+      diffTable.setHeaderVisible(true);
     } else if (si.getTop() > 0.5 * si.getClientHeight()
         && Gerrit.isHeaderVisible()) {
-      Gerrit.setHeaderVisible(false);
-      diffTable.updateFileCommentVisibility(true);
+      diffTable.setHeaderVisible(false);
     }
   }