opendev/gerrit
Code Issues Proposed changes

js.bzl: Stop using incompatible join method

Browse Source 
Bazel 0.27 flipped incompatible Starlark flag:
--incompatible_string_join_requires_strings, see: [1] for
more details.

[1] https://github.com/bazelbuild/bazel/issues/7802

Change-Id: Id8588f65ba34a084d82f282da180fb8b35ef48ac
This commit is contained in:
David Pursehouse
2019-07-08 12:31:43 +09:00
parent 0aabad2817
commit e7f8b13ea4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/bzl/js.bzl
View File

@@ -91,7 +91,7 @@ def _bower_archive(ctx):
out = ctx.execute(cmd) out = ctx.execute(cmd)
if out.return_code: if out.return_code:
fail("failed %s: %s" % (" ".join(cmd), out.stderr)) fail("failed %s: %s" % (cmd, out.stderr))
_bash(ctx, " && ".join([ _bash(ctx, " && ".join([
"TMP=$(mktemp -d || mktemp -d -t bazel-tmp)", "TMP=$(mktemp -d || mktemp -d -t bazel-tmp)",
@@ -127,7 +127,7 @@ def _bash(ctx, cmd):
cmd_list = ["bash", "-c", cmd] cmd_list = ["bash", "-c", cmd]
out = ctx.execute(cmd_list) out = ctx.execute(cmd_list)
if out.return_code: if out.return_code:
fail("failed %s: %s" % (" ".join(cmd_list), out.stderr)) fail("failed %s: %s" % (cmd_list, out.stderr))
bower_archive = repository_rule( bower_archive = repository_rule(
_bower_archive, _bower_archive,