opendev/gerrit
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update plugins/plugin-manager from branch 'master'
  to 58ac34bfebc787219c1e13d7cdc699e918067a0d
  - PluginInfo: Make output of failing PluginsRepositoryTest more readable
    
    If you have additional plugins in your working tree the
    corePluginsRepositoryShouldReturnCorePluginsFromReleaseWar test fails
    (as expected) but it's output is rather unreadable [1]. Make it nicer
    [2].
    
    [1]
    1) corePluginsRepositoryShouldReturnCorePluginsFromReleaseWar(com.googlesource.gerrit.plugins.manager.repository.PluginsRepositoryTest)
    value of    : iterable.size()
    expected    : 11
    but was     : 12
    iterable was: [com.googlesource.gerrit.plugins.manager.repository.PluginInfo@3da6950f, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@42684d86, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@45a05350, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@7d6a9d5e, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@74ed7111, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@74691677, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@3314f179, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@1abd1a28, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@5478597, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@39a1e1e6, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@2daa5092, com.googlesource.gerrit.plugins.manager.repository.PluginInfo@5f346355]
    	at com.googlesource.gerrit.plugins.manager.repository.PluginsRepositoryTest.corePluginsRepositoryShouldReturnCorePluginsFromReleaseWar(PluginsRepositoryTest.java:60)
    
    [2]
    1) corePluginsRepositoryShouldReturnCorePluginsFromReleaseWar(com.googlesource.gerrit.plugins.manager.repository.PluginsRepositoryTest)
    unexpected (1): checks
    
    Change-Id: I520c4b918ad1b1a7bccea7e48afe1ea271aff5b5
    ---
    expected      : [codemirror-editor, commit-message-length-validator, delete-project, download-commands, gitiles, hooks, plugin-manager, replication, reviewnotes, singleusergroup, webhooks]
    but was       : [checks, codemirror-editor, commit-message-length-validator, delete-project, download-commands, gitiles, hooks, plugin-manager, replication, reviewnotes, singleusergroup, webhooks]
    	at com.googlesource.gerrit.plugins.manager.repository.PluginsRepositoryTest.corePluginsRepositoryShouldReturnCorePluginsFromReleaseWar(PluginsRepositoryTest.java:61)
    
    Change-Id: Iaac0ea0a421ba97b443ed99ba152323b77d79515
    Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2019-10-09 05:41:05 +02:00
committed by Gerrit Code Review
parent 3838a2ed11
commit e8ef51c401
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files