opendev/gerrit
Code Issues Proposed changes

Remove @@ from diff context control rows

Browse Source 
It adds clutter and does not serve any obvious purpose.

Change-Id: I3820303388e58e71bf12f742d7bc476544a27153
This commit is contained in:
Ben Rohlfs
2019-10-07 12:16:08 +02:00
parent e6ed0c4a1e
commit e9144f545b
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js
View File

@@ -316,8 +316,6 @@
return td;
} else if (line.type === GrDiffLine.Type.CONTEXT_CONTROL) {
td.classList.add('contextLineNum');
td.setAttribute('data-value', '@@');
td.textContent = '@@';
} else if (line.type === GrDiffLine.Type.BOTH || line.type === type) {
td.classList.add('lineNum');
td.setAttribute('data-value', number);

4
polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight_test.html
View File

@@ -94,7 +94,7 @@ limitations under the License.
<tbody class="section contextControl">
<tr class="diff-row side-by-side" left-type="contextControl" right-type="contextControl">
<td class="left contextLineNum" data-value="@@"></td>
<td class="left contextLineNum"></td>
<td>
<gr-button>+10↑</gr-button>
-
@@ -102,7 +102,7 @@ limitations under the License.
-
<gr-button>+10↓</gr-button>
</td>
<td class="right contextLineNum" data-value="@@"></td>
<td class="right contextLineNum"></td>
<td>
<gr-button>+10↑</gr-button>
-