opendev/gerrit
Code Issues Proposed changes

GetSummary: Group threads for H2 and sshd-SshServer

Browse Source 
There can be quite many threads running for H2 and the sshd server.  On
my test server there were around 20 H2 related threads and around 6 sshd
related threads.

Add "H2" and "sshd-SshdServer" as group prefixes, so that these threads
will be listed in the summary under specific groups rather than being
grouped under "Other".

Change-Id: I138a5cbaf787c7c524c445368e7fcf7068e44a85
This commit is contained in:
David Pursehouse 2017-02-24 12:39:36 +09:00
parent de9f76de42
commit e9ccf87816
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Documentation/rest-api-config.txt
View File

@ -1721,13 +1721,13 @@ The total number of current threads.
|`counts` |
Detailed thread counts as a map that maps a thread kind to a map that
maps a thread state to the thread count. The thread kinds group the
counts by threads that have the same name prefix (`HTTP`,
counts by threads that have the same name prefix (`H2`, `HTTP`,
`IntraLineDiff`, `ReceiveCommits`, `SSH git-receive-pack`,
`SSH git-upload-pack`, `SSH-Interactive-Worker`, `SSH-Stream-Worker`,
`SshCommandStart`). The counts for other threads are available under
the thread kind `Other`. Counts for the following thread states can be
included: `NEW`, `RUNNABLE`, `BLOCKED`, `WAITING`, `TIMED_WAITING` and
`TERMINATED`.
`SshCommandStart`, `sshd-SshServer`). The counts for other threads are
available under the thread kind `Other`. Counts for the following thread
states can be included: `NEW`, `RUNNABLE`, `BLOCKED`, `WAITING`,
`TIMED_WAITING` and `TERMINATED`.
|===========================
[[top-menu-entry-info]]

4
gerrit-server/src/main/java/com/google/gerrit/server/config/GetSummary.java
View File

@ -144,6 +144,7 @@ public class GetSummary implements RestReadView<ConfigResource> {
List<String> prefixes =
Arrays.asList(
"H2",
"HTTP",
"IntraLineDiff",
"ReceiveCommits",
@ -151,7 +152,8 @@ public class GetSummary implements RestReadView<ConfigResource> {
"SSH git-upload-pack",
"SSH-Interactive-Worker",
"SSH-Stream-Worker",
"SshCommandStart");
"SshCommandStart",
"sshd-SshServer");
String other = "Other";
ThreadMXBean threadMXBean = ManagementFactory.getThreadMXBean();