Merge branch 'stable-3.0'

* stable-3.0:
  Use dom-if instead of css when hiding gr-http-password
  MysqlAccountPatchReviewStore: Fix duplicate key detection
  Bazel: Bump minimum supported version to 0.26.1

Change-Id: Ibd894f61d0ce7d33b3024a8c0f07d322a87ffce0

WORKSPACE

@@ -66,7 +66,7 @@ http_file(
 
 load("@bazel_skylib//lib:versions.bzl", "versions")
 
-versions.check(minimum_bazel_version = "0.25.0")
+versions.check(minimum_bazel_version = "0.26.1")
 
 load("@io_bazel_rules_closure//closure:defs.bzl", "closure_repositories")
 

java/com/google/gerrit/server/schema/MysqlAccountPatchReviewStore.java

@@ -38,7 +38,7 @@ public class MysqlAccountPatchReviewStore extends JdbcAccountPatchReviewStore {
 
   @Override
   public StorageException convertError(String op, SQLException err) {
-    switch (getSQLStateInt(err)) {
+    switch (err.getErrorCode()) {
       case 1022: // ER_DUP_KEY
       case 1062: // ER_DUP_ENTRY
       case 1169: // ER_DUP_UNIQUE;

polygerrit-ui/app/elements/settings/gr-http-password/gr-http-password.js

@@ -27,6 +27,10 @@
       _passwordUrl: String,
     },
 
+    attached() {
+      this.loadData();
+    },
+
     loadData() {
       const promises = [];
 

polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.html

@@ -387,12 +387,14 @@ limitations under the License.
               disabled="[[!_computeAddEmailButtonEnabled(_newEmail, _addingEmail)]]"
               on-tap="_handleAddEmailButton">Send verification</gr-button>
         </fieldset>
-        <div hidden$="[[!_showHttpAuth(_serverConfig)]]">
+        <template is="dom-if" if="[[_showHttpAuth(_serverConfig)]]">
+          <div>
             <h2 id="HTTPCredentials">HTTP Credentials</h2>
             <fieldset>
               <gr-http-password id="httpPass"></gr-http-password>
             </fieldset>
           </div>
+        </template>
         <div hidden$="[[!_serverConfig.sshd]]">
           <h2
               id="SSHKeys"

polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.js

@@ -166,7 +166,6 @@
         this.$.accountInfo.loadData(),
         this.$.watchedProjectsEditor.loadData(),
         this.$.groupList.loadData(),
-        this.$.httpPass.loadData(),
         this.$.identities.loadData(),
         this.$.editPrefs.loadData(),
         this.$.diffPrefs.loadData(),