opendev/gerrit
Code Issues Proposed changes

CreateTag: Remove hook invocation

Browse Source 
Hooks are invoked from ChangeHooksApiListener.

Change-Id: I1dcf439cb8c70c73bb9de36fdccdd8195a9a2551
This commit is contained in:
David Pursehouse 2016-06-27 11:15:42 +09:00
parent d633834772
commit ea89a23f3a
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-server/src/main/java/com/google/gerrit/server/project/CreateTag.java
View File

@ -18,7 +18,6 @@ import static org.eclipse.jgit.lib.Constants.R_REFS;
import static org.eclipse.jgit.lib.Constants.R_TAGS;
import com.google.common.base.Strings;
import com.google.gerrit.common.ChangeHooks;
import com.google.gerrit.common.TimeUtil;
import com.google.gerrit.common.data.Permission;
import com.google.gerrit.extensions.api.projects.TagInfo;
@ -29,7 +28,6 @@ import com.google.gerrit.extensions.restapi.MethodNotAllowedException;
import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.extensions.restapi.RestModifyView;
import com.google.gerrit.reviewdb.client.Branch;
import com.google.gerrit.server.IdentifiedUser;
import com.google.gerrit.server.extensions.events.GitReferenceUpdated;
import com.google.gerrit.server.git.GitRepositoryManager;
@ -65,7 +63,6 @@ public class CreateTag implements RestModifyView<ProjectResource, TagInput> {
private final GitRepositoryManager repoManager;
private final TagCache tagCache;
private final GitReferenceUpdated referenceUpdated;
private final ChangeHooks hooks;
private String ref;
@Inject
@ -73,13 +70,11 @@ public class CreateTag implements RestModifyView<ProjectResource, TagInput> {
GitRepositoryManager repoManager,
TagCache tagCache,
GitReferenceUpdated referenceUpdated,
ChangeHooks hooks,
@Assisted String ref) {
this.identifiedUser = identifiedUser;
this.repoManager = repoManager;
this.tagCache = tagCache;
this.referenceUpdated = referenceUpdated;
this.hooks = hooks;
this.ref = ref;
}
@ -150,9 +145,6 @@ public class CreateTag implements RestModifyView<ProjectResource, TagInput> {
referenceUpdated.fire(resource.getNameKey(), ref,
ObjectId.zeroId(), result.getObjectId(),
identifiedUser.get().getAccount());
hooks.doRefUpdatedHook(new Branch.NameKey(resource.getNameKey(), ref),
ObjectId.zeroId(), result.getObjectId(),
identifiedUser.get().getAccount());
try (RevWalk w = new RevWalk(repo)) {
return ListTags.createTagInfo(result, w);
}