opendev/gerrit
Code Issues Proposed changes

NoteDbMetrics: Remove unused auto-rebuilding metrics

Browse Source 
Change-Id: I9f3b35290aed24c54bd190477f36dd8b234629fb
This commit is contained in:
Dave Borowitz
2018-12-12 14:37:13 -08:00
parent 2876b5741f
commit eaba9de8f1
2 changed files with 0 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Documentation/metrics.txt
View File

@@ -140,9 +140,6 @@ excluding reindexing
* `notedb/stage_update_latency`: Latency for staging updates to NoteDb by table. * `notedb/stage_update_latency`: Latency for staging updates to NoteDb by table.
* `notedb/read_latency`: NoteDb read latency by table. * `notedb/read_latency`: NoteDb read latency by table.
* `notedb/parse_latency`: NoteDb parse latency by table. * `notedb/parse_latency`: NoteDb parse latency by table.
* `notedb/auto_rebuild_latency`: NoteDb auto-rebuilding latency by table.
* `notedb/auto_rebuild_failure_count`: NoteDb auto-rebuilding attempts that
failed by table.
* `notedb/external_id_update_count`: Total number of external ID updates. * `notedb/external_id_update_count`: Total number of external ID updates.
* `notedb/read_all_external_ids_latency`: Latency for reading all * `notedb/read_all_external_ids_latency`: Latency for reading all
external ID's from NoteDb. external ID's from NoteDb.

25
java/com/google/gerrit/server/notedb/NoteDbMetrics.java
View File

@@ -14,7 +14,6 @@
package com.google.gerrit.server.notedb; package com.google.gerrit.server.notedb;
import com.google.gerrit.metrics.Counter1;
import com.google.gerrit.metrics.Description; import com.google.gerrit.metrics.Description;
import com.google.gerrit.metrics.Description.Units; import com.google.gerrit.metrics.Description.Units;
import com.google.gerrit.metrics.Field; import com.google.gerrit.metrics.Field;
@@ -44,16 +43,6 @@ class NoteDbMetrics {
*/ */
final Timer1<NoteDbTable> parseLatency; final Timer1<NoteDbTable> parseLatency;
/**
* Latency due to auto-rebuilding entities when out of date.
*
* <p>Excludes latency from reading ref to check whether the entity is up to date.
*/
final Timer1<NoteDbTable> autoRebuildLatency;
/** Count of auto-rebuild attempts that failed. */
final Counter1<NoteDbTable> autoRebuildFailureCount;
@Inject @Inject
NoteDbMetrics(MetricMaker metrics) { NoteDbMetrics(MetricMaker metrics) {
Field<NoteDbTable> view = Field.ofEnum(NoteDbTable.class, "table"); Field<NoteDbTable> view = Field.ofEnum(NoteDbTable.class, "table");
@@ -89,19 +78,5 @@ class NoteDbMetrics {
.setCumulative() .setCumulative()
.setUnit(Units.MICROSECONDS), .setUnit(Units.MICROSECONDS),
view); view);
autoRebuildLatency =
metrics.newTimer(
"notedb/auto_rebuild_latency",
new Description("NoteDb auto-rebuilding latency by table")
.setCumulative()
.setUnit(Units.MILLISECONDS),
view);
autoRebuildFailureCount =
metrics.newCounter(
"notedb/auto_rebuild_failure_count",
new Description("NoteDb auto-rebuilding attempts that failed by table").setCumulative(),
view);
} }
} }