opendev/gerrit
Code Issues Proposed changes

Reply dialog send only disabled if known not to be latest

Browse Source 
Formerly the Send button of gr-reply-dialog would be disabled while
checking whether there are any newer patches and was only enabled if no
newer patch was found. With this change, the Send button is not disabled
while checking, and is only disabled if a newer patch was found.

Bug: Issue 6263
Change-Id: I6ed8d3cb4e3e797155491413eb6bc0dffe31b62a
This commit is contained in:
Wyatt Allen
2017-05-31 16:21:30 -07:00
parent 4d28854369
commit eb05dbd66f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html
View File

@@ -248,13 +248,13 @@ limitations under the License.
<section>
<gr-button
primary
disabled="[[!_isState(knownLatestState, 'latest')]]"
disabled="[[_isState(knownLatestState, 'not-latest')]]"
class="action send"
on-tap="_sendTapHandler">[[_sendButtonLabel]]</gr-button>
</gr-button>
<template is="dom-if" if="[[canBeStarted]]">
<gr-button
disabled="[[!_isState(knownLatestState, 'latest')]]"
disabled="[[_isState(knownLatestState, 'not-latest')]]"
class="action save"
on-tap="_saveTapHandler">Save</gr-button>
</template>