opendev/gerrit
Code Issues Proposed changes

Buck: Cleanup dependencies in CM integration code

Browse Source 
Since [1] Buck implicitly adds :foo and :bar in $(exe :foo) and
$(location :bar) macros to the dependency list of genrule(). The
code base was adjusted to reflect this enhancement in Ie3a9de0b2.
In I996b8d2a1 the unneeded dependencies were partially re-added
in CM integration code.

Re-remove it again.

[1] https://github.com/facebook/buck/issues/128
Change-Id: I8d0aaa5c9f7586f04f169f8362709b1fc7b04dcc
This commit is contained in:
David Ostrovsky 2015-01-04 22:51:18 +01:00 committed by Shawn Pearce
parent bd70bdbd5c
commit eb430c447c
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/codemirror/closure.defs
View File

@ -3,8 +3,7 @@ def js_minify(
out, out,
compiler_args = [], compiler_args = [],
srcs = [], srcs = [],
generated = [], generated = []):
deps = []):
cmd = ['$(exe :js_minifier) --js_output_file $OUT'] + compiler_args cmd = ['$(exe :js_minifier) --js_output_file $OUT'] + compiler_args
if srcs: if srcs:
cmd.append('$SRCS') cmd.append('$SRCS')
@ -15,6 +14,5 @@ def js_minify(
name = name, name = name,
cmd = ' '.join(cmd), cmd = ' '.join(cmd),
srcs = srcs, srcs = srcs,
deps = deps + generated + [':js_minifier'],
out = out, out = out,
) )