From eb8b2699ab1ad1efbe9149a52f1837e220fda9eb Mon Sep 17 00:00:00 2001 From: Dmitrii Filippov Date: Mon, 6 Apr 2020 18:02:35 +0200 Subject: [PATCH] Get rid of global Gerrit.Nav * Replace the global Gerrit.Nav variable with named imports. * Update gr-app-global-var-init.js Note: This is not a recommended approach. The change focuses on removing global variable. See todo in gr-navigation.js Change-Id: If389574d6d3bc1d643538f6776740bca82f71049 --- .../gr-admin-nav-behavior.js | 52 +- .../gr-admin-group-list.js | 4 +- .../admin/gr-admin-view/gr-admin-view.js | 32 +- .../gr-admin-view/gr-admin-view_test.html | 36 +- .../gr-create-change-dialog.js | 4 +- .../gr-group-audit-log/gr-group-audit-log.js | 4 +- .../admin/gr-repo-access/gr-repo-access.js | 4 +- .../gr-repo-access/gr-repo-access_test.html | 10 +- .../gr-repo-commands/gr-repo-commands.js | 3 +- .../gr-repo-commands_test.html | 6 +- .../gr-repo-dashboards/gr-repo-dashboards.js | 4 +- .../gr-repo-dashboards_test.html | 4 +- .../admin/gr-repo-list/gr-repo-list.js | 3 +- .../app/elements/admin/gr-repo/gr-repo.js | 3 +- .../gr-change-list-item.js | 10 +- .../gr-change-list-item_test.html | 12 +- .../gr-change-list-view.js | 8 +- .../gr-change-list-view_test.html | 23 +- .../gr-change-list/gr-change-list.js | 6 +- .../gr-change-list/gr-change-list_test.html | 6 +- .../gr-dashboard-view/gr-dashboard-view.js | 7 +- .../gr-dashboard-view_test.html | 14 +- .../gr-repo-header/gr-repo-header.js | 4 +- .../gr-repo-header/gr-repo-header_test.html | 4 +- .../gr-user-header/gr-user-header.js | 4 +- .../gr-change-actions/gr-change-actions.js | 14 +- .../gr-change-actions_test.html | 7 +- .../gr-change-metadata/gr-change-metadata.js | 14 +- .../gr-change-metadata_test.html | 10 +- .../change/gr-change-view/gr-change-view.js | 28 +- .../gr-change-view/gr-change-view_test.html | 53 +- .../change/gr-comment-list/gr-comment-list.js | 6 +- .../gr-comment-list/gr-comment-list_test.html | 6 +- .../change/gr-commit-info/gr-commit-info.js | 3 +- .../gr-commit-info/gr-commit-info_test.html | 12 +- .../gr-confirm-cherrypick-dialog.js | 3 +- .../gr-confirm-submit-dialog.js | 1 - .../gr-file-list-header.js | 4 +- .../gr-file-list-header_test.html | 3 +- .../change/gr-file-list/gr-file-list.js | 10 +- .../gr-file-list/gr-file-list_test.html | 13 +- .../gr-related-changes-list.js | 4 +- .../gr-related-changes-list_test.html | 6 +- .../change/gr-reply-dialog/gr-reply-dialog.js | 3 +- .../core/gr-navigation/gr-navigation.js | 1346 ++++++++--------- .../gr-navigation/gr-navigation_test.html | 10 +- .../app/elements/core/gr-router/gr-router.js | 126 +- .../core/gr-router/gr-router_test.html | 164 +- .../core/gr-smart-search/gr-smart-search.js | 4 +- .../gr-apply-fix-dialog.js | 3 +- .../gr-apply-fix-dialog_test.html | 14 +- .../diff/gr-diff-host/gr-diff-host.js | 5 +- .../diff/gr-diff-host/gr-diff-host_test.html | 7 +- .../diff/gr-diff-view/gr-diff-view.js | 28 +- .../diff/gr-diff-view/gr-diff-view_test.html | 58 +- .../edit/gr-edit-controls/gr-edit-controls.js | 16 +- .../gr-edit-controls_test.html | 14 +- .../edit/gr-editor-view/gr-editor-view.js | 6 +- .../gr-editor-view/gr-editor-view_test.html | 8 +- polygerrit-ui/app/elements/gr-app-element.js | 40 +- .../app/elements/gr-app-global-var-init.js | 4 + polygerrit-ui/app/elements/gr-app_test.html | 6 +- .../settings/gr-group-list/gr-group-list.js | 4 +- .../gr-group-list/gr-group-list_test.html | 4 +- .../gr-registration-dialog.js | 1 - .../shared/gr-account-link/gr-account-link.js | 4 +- .../gr-account-link/gr-account-link_test.html | 4 +- .../gr-comment-thread/gr-comment-thread.js | 4 +- .../gr-comment-thread_test.html | 6 +- .../shared/gr-label-info/gr-label-info.js | 3 +- .../shared/gr-linked-text/gr-linked-text.js | 6 +- .../gr-linked-text/gr-linked-text_test.html | 4 +- polygerrit-ui/app/test/test-router.js | 4 +- 73 files changed, 1215 insertions(+), 1155 deletions(-) diff --git a/polygerrit-ui/app/behaviors/gr-admin-nav-behavior/gr-admin-nav-behavior.js b/polygerrit-ui/app/behaviors/gr-admin-nav-behavior/gr-admin-nav-behavior.js index b850dfed3b..3c48fbe618 100644 --- a/polygerrit-ui/app/behaviors/gr-admin-nav-behavior/gr-admin-nav-behavior.js +++ b/polygerrit-ui/app/behaviors/gr-admin-nav-behavior/gr-admin-nav-behavior.js @@ -1,3 +1,5 @@ +import {GerritNav} from '../../elements/core/gr-navigation/gr-navigation.js'; + /** * @license * Copyright (C) 2018 The Android Open Source Project @@ -136,25 +138,25 @@ export const AdminNavBehavior = { groupOwner) { const subsection = { name: groupName, - view: Gerrit.Nav.View.GROUP, - url: Gerrit.Nav.getUrlForGroup(groupId), + view: GerritNav.View.GROUP, + url: GerritNav.getUrlForGroup(groupId), children: [], }; if (groupIsInternal) { subsection.children.push({ name: 'Members', - detailType: Gerrit.Nav.GroupDetailView.MEMBERS, - view: Gerrit.Nav.View.GROUP, - url: Gerrit.Nav.getUrlForGroupMembers(groupId), + detailType: GerritNav.GroupDetailView.MEMBERS, + view: GerritNav.View.GROUP, + url: GerritNav.getUrlForGroupMembers(groupId), }); } if (groupIsInternal && (isAdmin || groupOwner)) { subsection.children.push( { name: 'Audit Log', - detailType: Gerrit.Nav.GroupDetailView.LOG, - view: Gerrit.Nav.View.GROUP, - url: Gerrit.Nav.getUrlForGroupLog(groupId), + detailType: GerritNav.GroupDetailView.LOG, + view: GerritNav.View.GROUP, + url: GerritNav.getUrlForGroupLog(groupId), } ); } @@ -164,37 +166,37 @@ export const AdminNavBehavior = { getRepoSubsections(repoName) { return { name: repoName, - view: Gerrit.Nav.View.REPO, - url: Gerrit.Nav.getUrlForRepo(repoName), + view: GerritNav.View.REPO, + url: GerritNav.getUrlForRepo(repoName), children: [{ name: 'Access', - view: Gerrit.Nav.View.REPO, - detailType: Gerrit.Nav.RepoDetailView.ACCESS, - url: Gerrit.Nav.getUrlForRepoAccess(repoName), + view: GerritNav.View.REPO, + detailType: GerritNav.RepoDetailView.ACCESS, + url: GerritNav.getUrlForRepoAccess(repoName), }, { name: 'Commands', - view: Gerrit.Nav.View.REPO, - detailType: Gerrit.Nav.RepoDetailView.COMMANDS, - url: Gerrit.Nav.getUrlForRepoCommands(repoName), + view: GerritNav.View.REPO, + detailType: GerritNav.RepoDetailView.COMMANDS, + url: GerritNav.getUrlForRepoCommands(repoName), }, { name: 'Branches', - view: Gerrit.Nav.View.REPO, - detailType: Gerrit.Nav.RepoDetailView.BRANCHES, - url: Gerrit.Nav.getUrlForRepoBranches(repoName), + view: GerritNav.View.REPO, + detailType: GerritNav.RepoDetailView.BRANCHES, + url: GerritNav.getUrlForRepoBranches(repoName), }, { name: 'Tags', - view: Gerrit.Nav.View.REPO, - detailType: Gerrit.Nav.RepoDetailView.TAGS, - url: Gerrit.Nav.getUrlForRepoTags(repoName), + view: GerritNav.View.REPO, + detailType: GerritNav.RepoDetailView.TAGS, + url: GerritNav.getUrlForRepoTags(repoName), }, { name: 'Dashboards', - view: Gerrit.Nav.View.REPO, - detailType: Gerrit.Nav.RepoDetailView.DASHBOARDS, - url: Gerrit.Nav.getUrlForRepoDashboards(repoName), + view: GerritNav.View.REPO, + detailType: GerritNav.RepoDetailView.DASHBOARDS, + url: GerritNav.getUrlForRepoDashboards(repoName), }], }; }, diff --git a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js index dbb481dcd3..d2fde51c3b 100644 --- a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js +++ b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js @@ -18,7 +18,6 @@ import '../../../scripts/bundled-polymer.js'; import '../../../styles/gr-table-styles.js'; import '../../../styles/shared-styles.js'; -import '../../core/gr-navigation/gr-navigation.js'; import '../../shared/gr-dialog/gr-dialog.js'; import '../../shared/gr-list-view/gr-list-view.js'; import '../../shared/gr-overlay/gr-overlay.js'; @@ -30,6 +29,7 @@ import {LegacyElementMixin} from '@polymer/polymer/lib/legacy/legacy-element-mix import {PolymerElement} from '@polymer/polymer/polymer-element.js'; import {htmlTemplate} from './gr-admin-group-list_html.js'; import {ListViewBehavior} from '../../../behaviors/gr-list-view-behavior/gr-list-view-behavior.js'; +import {GerritNav} from '../../core/gr-navigation/gr-navigation.js'; /** * @appliesMixin ListViewMixin @@ -124,7 +124,7 @@ class GrAdminGroupList extends mixinBehaviors( [ } _computeGroupUrl(id) { - return Gerrit.Nav.getUrlForGroup(id); + return GerritNav.getUrlForGroup(id); } _getCreateGroupCapability() { diff --git a/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.js b/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.js index d647fb65bd..a0841f805c 100644 --- a/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.js +++ b/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.js @@ -18,7 +18,6 @@ import '../../../scripts/bundled-polymer.js'; import '../../../styles/gr-menu-page-styles.js'; import '../../../styles/gr-page-nav-styles.js'; import '../../../styles/shared-styles.js'; -import '../../core/gr-navigation/gr-navigation.js'; import '../../shared/gr-dropdown-list/gr-dropdown-list.js'; import '../../shared/gr-icons/gr-icons.js'; import '../../shared/gr-js-api-interface/gr-js-api-interface.js'; @@ -43,6 +42,7 @@ import {htmlTemplate} from './gr-admin-view_html.js'; import {BaseUrlBehavior} from '../../../behaviors/base-url-behavior/base-url-behavior.js'; import {AdminNavBehavior} from '../../../behaviors/gr-admin-nav-behavior/gr-admin-nav-behavior.js'; import {URLEncodingBehavior} from '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; +import {GerritNav} from '../../core/gr-navigation/gr-navigation.js'; const INTERNAL_GROUP_REGEX = /^[\da-f]{40}$/; @@ -182,32 +182,32 @@ class GrAdminView extends mixinBehaviors( [ if (this._selectedIsCurrentPage(selected)) { return; } - Gerrit.Nav.navigateToRelativeUrl(selected.url); + GerritNav.navigateToRelativeUrl(selected.url); } _paramsChanged(params) { - const isGroupView = params.view === Gerrit.Nav.View.GROUP; - const isRepoView = params.view === Gerrit.Nav.View.REPO; - const isAdminView = params.view === Gerrit.Nav.View.ADMIN; + const isGroupView = params.view === GerritNav.View.GROUP; + const isRepoView = params.view === GerritNav.View.REPO; + const isAdminView = params.view === GerritNav.View.ADMIN; this.set('_showGroup', isGroupView && !params.detail); this.set('_showGroupAuditLog', isGroupView && - params.detail === Gerrit.Nav.GroupDetailView.LOG); + params.detail === GerritNav.GroupDetailView.LOG); this.set('_showGroupMembers', isGroupView && - params.detail === Gerrit.Nav.GroupDetailView.MEMBERS); + params.detail === GerritNav.GroupDetailView.MEMBERS); this.set('_showGroupList', isAdminView && params.adminView === 'gr-admin-group-list'); this.set('_showRepoAccess', isRepoView && - params.detail === Gerrit.Nav.RepoDetailView.ACCESS); + params.detail === GerritNav.RepoDetailView.ACCESS); this.set('_showRepoCommands', isRepoView && - params.detail === Gerrit.Nav.RepoDetailView.COMMANDS); + params.detail === GerritNav.RepoDetailView.COMMANDS); this.set('_showRepoDetailList', isRepoView && - (params.detail === Gerrit.Nav.RepoDetailView.BRANCHES || - params.detail === Gerrit.Nav.RepoDetailView.TAGS)); + (params.detail === GerritNav.RepoDetailView.BRANCHES || + params.detail === GerritNav.RepoDetailView.TAGS)); this.set('_showRepoDashboards', isRepoView && - params.detail === Gerrit.Nav.RepoDetailView.DASHBOARDS); + params.detail === GerritNav.RepoDetailView.DASHBOARDS); this.set('_showRepoMain', isRepoView && !params.detail); this.set('_showRepoList', isAdminView && @@ -264,15 +264,15 @@ class GrAdminView extends mixinBehaviors( [ // Group params are structured differently from admin params. Compute // selected differently for groups. // TODO(wyatta): Simplify this when all routes work like group params. - if (params.view === Gerrit.Nav.View.GROUP && - itemView === Gerrit.Nav.View.GROUP) { + if (params.view === GerritNav.View.GROUP && + itemView === GerritNav.View.GROUP) { if (!params.detail && !opt_detailType) { return 'selected'; } if (params.detail === opt_detailType) { return 'selected'; } return ''; } - if (params.view === Gerrit.Nav.View.REPO && - itemView === Gerrit.Nav.View.REPO) { + if (params.view === GerritNav.View.REPO && + itemView === GerritNav.View.REPO) { if (!params.detail && !opt_detailType) { return 'selected'; } if (params.detail === opt_detailType) { return 'selected'; } return ''; diff --git a/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view_test.html b/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view_test.html index 173c913aa8..cb3ec0e592 100644 --- a/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view_test.html +++ b/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view_test.html @@ -34,6 +34,8 @@ limitations under the License. import '../../../test/common-test-setup.js'; import './gr-admin-view.js'; import {dom} from '@polymer/polymer/lib/legacy/polymer.dom.js'; +import {GerritNav} from '../../core/gr-navigation/gr-navigation.js'; + suite('gr-admin-view tests', () => { let element; let sandbox; @@ -294,7 +296,7 @@ suite('gr-admin-view tests', () => { assert.isTrue(element.reload.called); done(); }); - element.params = {group: 1, view: Gerrit.Nav.View.GROUP}; + element.params = {group: 1, view: GerritNav.View.GROUP}; element._groupName = 'oldName'; flushAsynchronousOperations(); element.shadowRoot @@ -333,8 +335,8 @@ suite('gr-admin-view tests', () => { element._repoName = 'my-repo'; element.params = { repo: 'my-repo', - view: Gerrit.Nav.View.REPO, - detail: Gerrit.Nav.RepoDetailView.ACCESS, + view: GerritNav.View.REPO, + detail: GerritNav.RepoDetailView.ACCESS, }; sandbox.stub( element.$.restAPI, @@ -460,7 +462,7 @@ suite('gr-admin-view tests', () => { parent: 'my-repo', }, ]; - sandbox.stub(Gerrit.Nav, 'navigateToRelativeUrl'); + sandbox.stub(GerritNav, 'navigateToRelativeUrl'); sandbox.spy(element, '_selectedIsCurrentPage'); sandbox.spy(element, '_handleSubsectionChange'); element.reload().then(() => { @@ -472,12 +474,12 @@ suite('gr-admin-view tests', () => { ); assert.isTrue(element._selectedIsCurrentPage.calledOnce); // Doesn't trigger navigation from the page select menu. - assert.isFalse(Gerrit.Nav.navigateToRelativeUrl.called); + assert.isFalse(GerritNav.navigateToRelativeUrl.called); // When explicitly changed, navigation is called element.shadowRoot.querySelector('#pageSelect').value = 'repo'; assert.isTrue(element._selectedIsCurrentPage.calledTwice); - assert.isTrue(Gerrit.Nav.navigateToRelativeUrl.calledOnce); + assert.isTrue(GerritNav.navigateToRelativeUrl.calledOnce); done(); }); }); @@ -524,7 +526,7 @@ suite('gr-admin-view tests', () => { test('repo list', () => { element.params = { - view: Gerrit.Nav.View.ADMIN, + view: GerritNav.View.ADMIN, adminView: 'gr-repo-list', openCreateModal: false, }; @@ -537,7 +539,7 @@ suite('gr-admin-view tests', () => { test('repo', () => { element.params = { - view: Gerrit.Nav.View.REPO, + view: GerritNav.View.REPO, repoName: 'foo', }; element._repoName = 'foo'; @@ -552,8 +554,8 @@ suite('gr-admin-view tests', () => { test('repo access', () => { element.params = { - view: Gerrit.Nav.View.REPO, - detail: Gerrit.Nav.RepoDetailView.ACCESS, + view: GerritNav.View.REPO, + detail: GerritNav.RepoDetailView.ACCESS, repoName: 'foo', }; element._repoName = 'foo'; @@ -568,8 +570,8 @@ suite('gr-admin-view tests', () => { test('repo dashboards', () => { element.params = { - view: Gerrit.Nav.View.REPO, - detail: Gerrit.Nav.RepoDetailView.DASHBOARDS, + view: GerritNav.View.REPO, + detail: GerritNav.RepoDetailView.DASHBOARDS, repoName: 'foo', }; element._repoName = 'foo'; @@ -604,7 +606,7 @@ suite('gr-admin-view tests', () => { test('group list', () => { element.params = { - view: Gerrit.Nav.View.ADMIN, + view: GerritNav.View.ADMIN, adminView: 'gr-admin-group-list', openCreateModal: false, }; @@ -617,7 +619,7 @@ suite('gr-admin-view tests', () => { test('internal group', () => { element.params = { - view: Gerrit.Nav.View.GROUP, + view: GerritNav.View.GROUP, groupId: 1234, }; element._groupName = 'foo'; @@ -642,7 +644,7 @@ suite('gr-admin-view tests', () => { id: 'external-id', })); element.params = { - view: Gerrit.Nav.View.GROUP, + view: GerritNav.View.GROUP, groupId: 1234, }; element._groupName = 'foo'; @@ -661,8 +663,8 @@ suite('gr-admin-view tests', () => { test('group members', () => { element.params = { - view: Gerrit.Nav.View.GROUP, - detail: Gerrit.Nav.GroupDetailView.MEMBERS, + view: GerritNav.View.GROUP, + detail: GerritNav.GroupDetailView.MEMBERS, groupId: 1234, }; element._groupName = 'foo'; diff --git a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js index e7d0cbe234..3347655260 100644 --- a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js +++ b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js @@ -20,7 +20,6 @@ import '@polymer/iron-input/iron-input.js'; import '../../../scripts/bundled-polymer.js'; import '../../../styles/gr-form-styles.js'; import '../../../styles/shared-styles.js'; -import '../../core/gr-navigation/gr-navigation.js'; import '../../shared/gr-autocomplete/gr-autocomplete.js'; import '../../shared/gr-button/gr-button.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js'; @@ -32,6 +31,7 @@ import {PolymerElement} from '@polymer/polymer/polymer-element.js'; import {htmlTemplate} from './gr-create-change-dialog_html.js'; import {BaseUrlBehavior} from '../../../behaviors/base-url-behavior/base-url-behavior.js'; import {URLEncodingBehavior} from '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; +import {GerritNav} from '../../core/gr-navigation/gr-navigation.js'; const SUGGESTIONS_LIMIT = 15; const REF_PREFIX = 'refs/heads/'; @@ -119,7 +119,7 @@ class GrCreateChangeDialog extends mixinBehaviors( [ this.baseCommit || null) .then(changeCreated => { if (!changeCreated) { return; } - Gerrit.Nav.navigateToChange(changeCreated); + GerritNav.navigateToChange(changeCreated); }); } diff --git a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js index cf4f0fc520..a3c05cb9e9 100644 --- a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js +++ b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js @@ -18,7 +18,6 @@ import '../../../scripts/bundled-polymer.js'; import '../../../styles/gr-table-styles.js'; import '../../../styles/shared-styles.js'; -import '../../core/gr-navigation/gr-navigation.js'; import '../../shared/gr-date-formatter/gr-date-formatter.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js'; import '../../shared/gr-account-link/gr-account-link.js'; @@ -28,6 +27,7 @@ import {LegacyElementMixin} from '@polymer/polymer/lib/legacy/legacy-element-mix import {PolymerElement} from '@polymer/polymer/polymer-element.js'; import {htmlTemplate} from './gr-group-audit-log_html.js'; import {ListViewBehavior} from '../../../behaviors/gr-list-view-behavior/gr-list-view-behavior.js'; +import {GerritNav} from '../../core/gr-navigation/gr-navigation.js'; const GROUP_EVENTS = ['ADD_GROUP', 'REMOVE_GROUP']; @@ -117,7 +117,7 @@ class GrGroupAuditLog extends mixinBehaviors( [ _computeGroupUrl(group) { if (group && group.url && group.id) { - return Gerrit.Nav.getUrlForGroup(group.id); + return GerritNav.getUrlForGroup(group.id); } return ''; diff --git a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js index 6b9859f214..9aa81f813a 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js @@ -19,7 +19,6 @@ import '../../../scripts/bundled-polymer.js'; import '../../../styles/gr-menu-page-styles.js'; import '../../../styles/gr-subpage-styles.js'; import '../../../styles/shared-styles.js'; -import '../../core/gr-navigation/gr-navigation.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js'; import '../gr-access-section/gr-access-section.js'; import {flush, dom} from '@polymer/polymer/lib/legacy/polymer.dom.js'; @@ -31,6 +30,7 @@ import {htmlTemplate} from './gr-repo-access_html.js'; import {BaseUrlBehavior} from '../../../behaviors/base-url-behavior/base-url-behavior.js'; import {AccessBehavior} from '../../../behaviors/gr-access-behavior/gr-access-behavior.js'; import {URLEncodingBehavior} from '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; +import {GerritNav} from '../../core/gr-navigation/gr-navigation.js'; const Defs = {}; @@ -486,7 +486,7 @@ class GrRepoAccess extends mixinBehaviors( [ return this.$.restAPI .setRepoAccessRightsForReview(this.repo, obj) .then(change => { - Gerrit.Nav.navigateToChange(change); + GerritNav.navigateToChange(change); }) .finally(() => { this._modified = false; diff --git a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access_test.html b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access_test.html index 83da6058b5..4835dfe1a0 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access_test.html +++ b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access_test.html @@ -35,6 +35,8 @@ limitations under the License. import '../../../test/common-test-setup.js'; import './gr-repo-access.js'; import {dom} from '@polymer/polymer/lib/legacy/polymer.dom.js'; +import {GerritNav} from '../../core/gr-navigation/gr-navigation.js'; + suite('gr-repo-access tests', () => { let element; let sandbox; @@ -1179,7 +1181,7 @@ suite('gr-repo-access tests', () => { }; sandbox.stub(element.$.restAPI, 'getRepoAccessRights').returns( Promise.resolve(JSON.parse(JSON.stringify(accessRes)))); - sandbox.stub(Gerrit.Nav, 'navigateToChange'); + sandbox.stub(GerritNav, 'navigateToChange'); let resolver; const saveStub = sandbox.stub(element.$.restAPI, 'setRepoAccessRights') @@ -1194,7 +1196,7 @@ suite('gr-repo-access tests', () => { resolver({_number: 1}); flush(() => { assert.isTrue(saveStub.called); - assert.isTrue(Gerrit.Nav.navigateToChange.notCalled); + assert.isTrue(GerritNav.navigateToChange.notCalled); done(); }); }); @@ -1226,7 +1228,7 @@ suite('gr-repo-access tests', () => { }; sandbox.stub(element.$.restAPI, 'getRepoAccessRights').returns( Promise.resolve(JSON.parse(JSON.stringify(accessRes)))); - sandbox.stub(Gerrit.Nav, 'navigateToChange'); + sandbox.stub(GerritNav, 'navigateToChange'); let resolver; const saveForReviewStub = sandbox.stub(element.$.restAPI, 'setRepoAccessRightsForReview') @@ -1241,7 +1243,7 @@ suite('gr-repo-access tests', () => { resolver({_number: 1}); flush(() => { assert.isTrue(saveForReviewStub.called); - assert.isTrue(Gerrit.Nav.navigateToChange + assert.isTrue(GerritNav.navigateToChange .lastCall.calledWithExactly({_number: 1})); done(); }); diff --git a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js index cbe0d0aeb5..1f1dc5b003 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js @@ -31,6 +31,7 @@ import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-l import {LegacyElementMixin} from '@polymer/polymer/lib/legacy/legacy-element-mixin.js'; import {PolymerElement} from '@polymer/polymer/polymer-element.js'; import {htmlTemplate} from './gr-repo-commands_html.js'; +import {GerritNav} from '../../core/gr-navigation/gr-navigation.js'; const GC_MESSAGE = 'Garbage collection completed successfully.'; @@ -135,7 +136,7 @@ class GrRepoCommands extends GestureEventListeners( {detail: {message}, bubbles: true, composed: true})); if (!change) { return; } - Gerrit.Nav.navigateToRelativeUrl(Gerrit.Nav.getEditUrlForDiff( + GerritNav.navigateToRelativeUrl(GerritNav.getEditUrlForDiff( change, CONFIG_PATH, INITIAL_PATCHSET)); }); } diff --git a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands_test.html b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands_test.html index 0dad516c61..948eaa2a33 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands_test.html +++ b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands_test.html @@ -34,6 +34,8 @@ limitations under the License.