opendev/gerrit
Code Issues Proposed changes

ChangeScreen2: Show inline comments in history

Browse Source 
When a history comment is expanded include the inline comments written
on that revision by the author at the same timestamp.  This makes it
easier to follow a change's evolution over time, especially if the
reader is new to the change and does not have the entire email thread
in their inbox.

Bug: issue 93
Change-Id: I57fe29fea2b3651306ff0a58746cefcfe1669267
This commit is contained in:
Shawn Pearce
2013-11-20 01:23:20 -08:00
parent cd2fc945ae
commit eb924ff74a
11 changed files with 462 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java
View File

@@ -267,6 +267,7 @@ public class ChangeInfo extends JavaScriptObject {
public static class MessageInfo extends JavaScriptObject {
public final native AccountInfo author() /*-{ return this.author; }-*/;
public final native String message() /*-{ return this.message; }-*/;
public final native int _revisionNumber() /*-{ return this._revision_number || 0; }-*/;
private final native String dateRaw() /*-{ return this.date; }-*/;
public final Timestamp date() {

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommentInfo.java
View File

@@ -42,7 +42,7 @@ public class CommentInfo extends JavaScriptObject {
}
private final native void setId(String id) /*-{ this.id = id; }-*/;
private final native void setPath(String path) /*-{ this.path = path; }-*/;
public final native void setPath(String path) /*-{ this.path = path; }-*/;
private final void setSide(Side side) {
setSideRaw(side.toString());
@@ -68,7 +68,7 @@ public class CommentInfo extends JavaScriptObject {
}
private final native String sideRaw() /*-{ return this.side }-*/;
public final native int line() /*-{ return this.line; }-*/;
public final native int line() /*-{ return this.line || 0; }-*/;
public final native String in_reply_to() /*-{ return this.in_reply_to; }-*/;
public final native String message() /*-{ return this.message; }-*/;