opendev/gerrit
Code Issues Proposed changes

Move: Fix NPE when label doesn't exist in target branch

Browse Source 
Change-Id: I86bb6f09bc2a865b8bbf899ef32e11e9e3ac22c0
This commit is contained in:
Orgad Shaneh 2018-06-06 14:52:11 +03:00 committed by Hugo Arès
parent 877b49ae8d
commit eb9e9ca3d3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/change/Move.java
View File

@ -259,7 +259,7 @@ public class Move extends RetryingRestModifyView<ChangeResource, MoveInput, Chan
// Only keep veto votes, defined as votes where:
// 1- the label function allows minimum values to block submission.
// 2- the vote holds the minimum value.
if (type.isMaxNegative(psa) && type.getFunction().isBlock()) {
if (type == null || (type.isMaxNegative(psa) && type.getFunction().isBlock())) {
continue;
}