From ebbc55a8096cd19cf1c90ced344a0d29a2327fbb Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 26 Jul 2017 10:31:18 +0100 Subject: [PATCH] ProjectCache: Remove unused 'remove' method Change-Id: Ie6e1a21749189edb247dbcc73cf0e19006a018ef --- .../gerrit/server/project/ProjectCache.java | 6 ------ .../gerrit/server/project/ProjectCacheImpl.java | 15 --------------- .../gerrit/server/project/RefControlTest.java | 3 --- 3 files changed, 24 deletions(-) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCache.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCache.java index 65c7315fc8..f55d576dd9 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCache.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCache.java @@ -51,12 +51,6 @@ public interface ProjectCache { /** Invalidate the cached information about the given project. */ void evict(Project.NameKey p); - /** - * Remove information about the given project from the cache. It will no longer be returned from - * {@link #all()}. - */ - void remove(Project p); - /** @return sorted iteration of projects. */ Iterable all(); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCacheImpl.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCacheImpl.java index 6ee143c862..38ca8910b2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCacheImpl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCacheImpl.java @@ -165,21 +165,6 @@ public class ProjectCacheImpl implements ProjectCache { } } - @Override - public void remove(Project p) { - listLock.lock(); - try { - SortedSet n = Sets.newTreeSet(list.get(ListKey.ALL)); - n.remove(p.getNameKey()); - list.put(ListKey.ALL, Collections.unmodifiableSortedSet(n)); - } catch (ExecutionException e) { - log.warn("Cannot list available projects", e); - } finally { - listLock.unlock(); - } - evict(p); - } - @Override public void onCreateProject(Project.NameKey newProjectName) { listLock.lock(); diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java index 9b9cfff100..29f17b43cd 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java @@ -238,9 +238,6 @@ public class RefControlTest { @Override public void evict(Project p) {} - @Override - public void remove(Project p) {} - @Override public Iterable all() { return Collections.emptySet();