From 78881fc207106d4224322e0969f129c80b308320 Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Sun, 10 Dec 2017 22:12:41 +0100 Subject: [PATCH] Bazel: Update to custom rules_closure to support Java 9 We need to upgrade rules_closure tools to be able to build with Java 9. That's because rules_closure depends on dagger 2 and auto-common and auto-value, that need to be updated to not depend on legacy annotations (that are not available on Java 9). Moreover, latest rules_closure switched to building protobuf library from the sources, creating the next problem: Protobuf doesn't support Java 9 yet. That was fixed only on master, so that we need to update rules_closure to consume the protobuf dependency from HEAD. See these issues for more background: [1],[2],[3],[4]. [1] https://github.com/google/auto/issues/560 [2] https://github.com/bazelbuild/rules_closure/issues/234 [3] https://github.com/google/dagger/issues/880 [4] https://github.com/google/protobuf/issues/4256 Bug: Issue 7958 Change-Id: I56f3b6101e06bd678b4e42d3a9d52157963513aa --- WORKSPACE | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 6044953e85..e76dc8a9ea 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -11,13 +11,12 @@ http_archive( urls = ["https://github.com/bazelbuild/bazel-skylib/archive/2169ae1c374aab4a09aa90e65efe1a3aad4e279b.tar.gz"], ) -# davido's fork with https://github.com/bazelbuild/rules_closure/issues/248 included -# to avoid workspace name mismatch warning +# davido's fork with https://github.com/bazelbuild/rules_closure/pull/235 included http_archive( name = "io_bazel_rules_closure", - sha256 = "83ea206d5fb9178f5faab7ffb173018c2908df5c73bdb0327e3272442ccce661", - strip_prefix = "rules_closure-0.8.0", - url = "https://github.com/davido/rules_closure/archive/0.8.0.tar.gz", + sha256 = "314e4eb701696e267cb911609e2e333e321fe641981a33144f460068ff4e1af3", + strip_prefix = "rules_closure-0.11.0", + url = "https://github.com/davido/rules_closure/archive/0.11.0.tar.gz", ) # File is specific to Polymer and copied from the Closure Github -- should be