opendev/gerrit
Code Issues Proposed changes

TestProjectUpdate: Support granting global capabilities

Browse Source 
Change-Id: Id0735efc7ada58897ff4586986441e02027e5d3e
This commit is contained in:
Dave Borowitz
2019-05-13 14:39:13 +02:00
parent 14ea238aa7
commit ec6fbb1346
4 changed files with 168 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
javatests/com/google/gerrit/acceptance/testsuite/project/ProjectOperationsImplTest.java
View File

@@ -15,6 +15,10 @@
package com.google.gerrit.acceptance.testsuite.project;
import static com.google.common.truth.Truth.assertThat;
import static com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.allowCapability;
import static com.google.gerrit.common.data.GlobalCapability.ADMINISTRATE_SERVER;
import static com.google.gerrit.common.data.GlobalCapability.DEFAULT_MAX_QUERY_LIMIT;
import static com.google.gerrit.common.data.GlobalCapability.QUERY_LIMIT;
import static com.google.gerrit.reviewdb.client.RefNames.REFS_CONFIG;
import static com.google.gerrit.server.group.SystemGroupBackend.PROJECT_OWNERS;
import static com.google.gerrit.server.group.SystemGroupBackend.REGISTERED_USERS;
@@ -322,6 +326,58 @@ public class ProjectOperationsImplTest extends AbstractDaemonTest {
"exclusiveGroupPermissions", "label-Code-Review");
}
@Test
public void addAllowCapability() throws Exception {
Project.NameKey key = projectOperations.newProject().create();
projectOperations
.project(key)
.forUpdate()
.add(allowCapability(ADMINISTRATE_SERVER).group(REGISTERED_USERS))
.update();
Config config = projectOperations.project(key).getConfig();
assertThat(config).sections().containsExactly("capability");
assertThat(config).subsections("capability").isEmpty();
assertThat(config)
.sectionValues("capability")
.containsExactly("administrateServer", "group global:Registered-Users");
}
@Test
public void addAllowCapabilityWithRange() throws Exception {
Project.NameKey key = projectOperations.newProject().create();
projectOperations
.project(key)
.forUpdate()
.add(allowCapability(QUERY_LIMIT).group(REGISTERED_USERS).range(0, 5000))
.update();
Config config = projectOperations.project(key).getConfig();
assertThat(config).sections().containsExactly("capability");
assertThat(config).subsections("capability").isEmpty();
assertThat(config)
.sectionValues("capability")
.containsExactly("queryLimit", "+0..+5000 group global:Registered-Users");
}
@Test
public void addAllowCapabilityWithDefaultRange() throws Exception {
Project.NameKey key = projectOperations.newProject().create();
projectOperations
.project(key)
.forUpdate()
.add(allowCapability(QUERY_LIMIT).group(REGISTERED_USERS))
.update();
Config config = projectOperations.project(key).getConfig();
assertThat(config).sections().containsExactly("capability");
assertThat(config).subsections("capability").isEmpty();
assertThat(config)
.sectionValues("capability")
.containsExactly(
"queryLimit", "+0..+" + DEFAULT_MAX_QUERY_LIMIT + " group global:Registered-Users");
}
private void deleteRefsMetaConfig(Project.NameKey key) throws Exception {
try (Repository repo = repoManager.openRepository(key)) {
new TestRepository<>(repo).delete(REFS_CONFIG);