opendev/gerrit
Code Issues Proposed changes

Fix: project search link and name are underlined in change info block

Browse Source 
In the change info block, the project search link and name are
underlined.  The rest of the items in the block are not underlined,
so this looks out of place.

Fix it by replacing the HorizontalPanel with a FlowPanel, as is used
on the project list page.

Change-Id: I11f7ea6d777436acfaadaa6c6e52ed300a5b4223
This commit is contained in:
David Pursehouse 2012-12-06 19:14:41 +09:00
parent 9db5173318
commit ed6b4c5009
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfoBlock.java
View File

@ -35,7 +35,6 @@ import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Grid; import com.google.gwt.user.client.ui.Grid;
import com.google.gwt.user.client.ui.HTMLTable.CellFormatter; import com.google.gwt.user.client.ui.HTMLTable.CellFormatter;
import com.google.gwt.user.client.ui.HorizontalPanel;
import com.google.gwt.user.client.ui.Image; import com.google.gwt.user.client.ui.Image;
import com.google.gwt.user.client.ui.InlineLabel; import com.google.gwt.user.client.ui.InlineLabel;
import com.google.gwt.user.client.ui.TextBox; import com.google.gwt.user.client.ui.TextBox;
@ -104,7 +103,7 @@ public class ChangeInfoBlock extends Composite {
table.setWidget(R_OWNER, 1, AccountLink.link(acc, chg.getOwner())); table.setWidget(R_OWNER, 1, AccountLink.link(acc, chg.getOwner()));
final HorizontalPanel p = new HorizontalPanel(); final FlowPanel p = new FlowPanel();
p.add(new ProjectSearchLink(chg.getProject())); p.add(new ProjectSearchLink(chg.getProject()));
p.add(new InlineHyperlink(chg.getProject().get(), p.add(new InlineHyperlink(chg.getProject().get(),
PageLinks.toProject(chg.getProject()))); PageLinks.toProject(chg.getProject())));