opendev/gerrit
Code Issues Proposed changes

Use different NotesMigration implementation for testing

Browse Source 
This uses volatile booleans for each bit that can be changed on the
fly. This is not especially important for most AbstractDaemonTests,
since we don't use this functionality and they previously used
ConfigSuite to set the fields. But it will be necessary for testing
notedb rebuilding.

Change-Id: I55f01c873d6d1f4fb3d459799bb3933afbd0c59f
This commit is contained in:
Dave Borowitz
2016-02-11 16:57:45 -05:00
parent 8f5db32405
commit ed92a5daa9
10 changed files with 73 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gpg/src/test/java/com/google/gerrit/gpg/GerritPublicKeyCheckerTest.java
View File

@@ -46,6 +46,7 @@ import com.google.gerrit.server.util.RequestContext;
import com.google.gerrit.server.util.ThreadLocalRequestContext;
import com.google.gerrit.testutil.InMemoryDatabase;
import com.google.gerrit.testutil.InMemoryModule;
import com.google.gerrit.testutil.TestNotesMigration;
import com.google.inject.Guice;
import com.google.inject.Inject;
import com.google.inject.Injector;
@@ -107,7 +108,8 @@ public class GerritPublicKeyCheckerTest {
cfg.setStringList("receive", null, "trustedKey", ImmutableList.of(
Fingerprint.toString(keyB().getPublicKey().getFingerprint()),
Fingerprint.toString(keyD().getPublicKey().getFingerprint())));
Injector injector = Guice.createInjector(new InMemoryModule(cfg));
Injector injector = Guice.createInjector(
new InMemoryModule(cfg, new TestNotesMigration()));
lifecycle = new LifecycleManager();
lifecycle.add(injector);