opendev/gerrit
Code Issues Proposed changes

Error Prone: Enable and fix OperatorPrecedence

Browse Source 
Change-Id: I1c9e79a37cba650b1526793fc7997544bb99aafc
This commit is contained in:
Dave Borowitz 2019-05-24 10:57:09 -07:00 committed by David Pursehouse
parent 17ef12713b
commit edd57a21d6
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/submit/SubmoduleOp.java
View File

@ -656,7 +656,7 @@ public class SubmoduleOp {
int newSize = msgbuf.length() + bullet.length() + message.length(); int newSize = msgbuf.length() + bullet.length() + message.length();
if (++numMessages > maxCommitMessages if (++numMessages > maxCommitMessages
|| newSize > maxCombinedCommitMessageSize || newSize > maxCombinedCommitMessageSize
|| iter.hasNext() && (newSize + ellipsis.length()) > maxCombinedCommitMessageSize) { || (iter.hasNext() && (newSize + ellipsis.length()) > maxCombinedCommitMessageSize)) {
msgbuf.append(ellipsis); msgbuf.append(ellipsis);
break; break;
} }

2
tools/BUILD
View File

@ -65,7 +65,7 @@ java_package_configuration(
"-Xep:NullableConstructor:WARN", "-Xep:NullableConstructor:WARN",
"-Xep:NullablePrimitive:WARN", "-Xep:NullablePrimitive:WARN",
"-Xep:NullableVoid:WARN", "-Xep:NullableVoid:WARN",
"-Xep:OperatorPrecedence:WARN", "-Xep:OperatorPrecedence:ERROR",
"-Xep:OverridesGuiceInjectableMethod:WARN", "-Xep:OverridesGuiceInjectableMethod:WARN",
"-Xep:PreconditionsInvalidPlaceholder:WARN", "-Xep:PreconditionsInvalidPlaceholder:WARN",
"-Xep:ProtoFieldPreconditionsCheckNotNull:WARN", "-Xep:ProtoFieldPreconditionsCheckNotNull:WARN",