opendev/gerrit
Code Issues Proposed changes

Improve message when removing a reviewer

Browse Source 
When a reviewer is removed from a change also the votes of this
reviewer are deleted. This action is recorded as a change message:

  Removed the following approvals:

  * Code-Review-2 by John Doe <john.doe@example.com>

The term 'approval' is often associated with the highest vote in a
label which is needed to make the change submittable. When the votes
of a reviewer are removed this is mostly about negative veto votes.
This is why using 'approvals' in this context is confusing to users
and the message is now changed to say 'votes' instead.

Change-Id: I388f219d151a431ceeef497dd3d1b220f56e7b00
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2014-07-03 13:37:24 +02:00
committed by David Pursehouse
parent 7d6db3c15e
commit ee06a49d7d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/change/DeleteReviewer.java
View File

@@ -89,7 +89,7 @@ public class DeleteReviewer implements RestModifyView<ReviewerResource, Input> {
if (a.getPatchSetId().equals(control.getChange().currentPatchSetId())
&& a.getValue() != 0) {
if (msg.length() == 0) {
msg.append("Removed the following approvals:\n\n");
msg.append("Removed the following votes:\n\n");
}
msg.append("* ")
.append(a.getLabel()).append(formatLabelValue(a.getValue()))