opendev/gerrit
Code Issues Proposed changes

Adds a new pref config called lineWrapping to Edit and Diff

Browse Source 
What this config does is it either enables or disables lineWrapping,
disabling line wrapping can cause changes that have long lines to simply
be cut off.

With it enabled it will line wrap the text making it easer to read instead
of it being cutoff.

Gerrit 2.8.1 did lineWrapping so bringing this back. But it is set to the
default false so it is not enabled by default in Edit or Diff sections.

We should probaly set it as true in gerrit 2.13.

This also will partially fix bug

https://phabricator.wikimedia.org/T144565

which is filled downstream. Reason why this is partially fixed is because
the pref is not set to true by default and logged out users will still
see no line wrapping.

Bug: Issue 4292
Bug: Issue 2410
Change-Id: I8600778f1068c217e335755a3138e8cb64bc8b3e
This commit is contained in:
Paladox
2016-09-05 23:51:02 +01:00
committed by Paladox none
parent 78808c5d34
commit ee24b3c547
14 changed files with 74 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java
View File

@@ -56,6 +56,7 @@ public class DiffPreferencesInfo {
public Boolean renderEntireFile;
public Boolean hideEmptyPane;
public Boolean matchBrackets;
public Boolean lineWrapping;
public Theme theme;
public Whitespace ignoreWhitespace;
public Boolean retainHeader;
@@ -86,6 +87,7 @@ public class DiffPreferencesInfo {
i.renderEntireFile = false;
i.hideEmptyPane = false;
i.matchBrackets = false;
i.lineWrapping = false;
return i;
}
}

2
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/client/EditPreferencesInfo.java
View File

@@ -25,6 +25,7 @@ public class EditPreferencesInfo {
public Boolean syntaxHighlighting;
public Boolean hideLineNumbers;
public Boolean matchBrackets;
public Boolean lineWrapping;
public Boolean autoCloseBrackets;
public Theme theme;
public KeyMapType keyMapType;
@@ -40,6 +41,7 @@ public class EditPreferencesInfo {
i.syntaxHighlighting = true;
i.hideLineNumbers = false;
i.matchBrackets = true;
i.lineWrapping = false;
i.autoCloseBrackets = false;
i.theme = Theme.DEFAULT;
i.keyMapType = KeyMapType.DEFAULT;