opendev/gerrit
Code Issues Proposed changes

Remove bad import of JGit Constants from GWT UI

Browse Source 
This class cannot be imported into GWT UI code as it
references symbols that are not legal in GWT input.
We must inline the value of ".git".

Change-Id: Ic399bfbb49d9c01ce74cdd8b800794e79f2cbcd1
This commit is contained in:
Shawn Pearce
2013-01-09 12:42:44 -08:00
parent 52e01191d8
commit ee720b8ab7
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateProjectScreen.java
View File

@@ -46,8 +46,6 @@ import com.google.gwt.user.client.ui.VerticalPanel;
import com.google.gwtexpui.globalkey.client.NpTextBox;
import com.google.gwtjsonrpc.common.VoidResult;
import org.eclipse.jgit.lib.Constants;
public class CreateProjectScreen extends Screen {
private Grid grid;
private NpTextBox project;
@@ -238,13 +236,13 @@ public class CreateProjectScreen extends Screen {
@Override
public void onSuccess(VoidResult result) {
String nameWithoutSuffix = projectName;
if (nameWithoutSuffix.endsWith(Constants.DOT_GIT_EXT)) {
if (nameWithoutSuffix.endsWith(".git")) {
// Be nice and drop the trailing ".git" suffix, which we never
// keep in our database, but clients might mistakenly provide
// anyway.
//
nameWithoutSuffix = nameWithoutSuffix.substring(0, //
nameWithoutSuffix.length() - Constants.DOT_GIT_EXT.length());
nameWithoutSuffix.length() - 4);
while (nameWithoutSuffix.endsWith("/")) {
nameWithoutSuffix = nameWithoutSuffix.substring(//
0, nameWithoutSuffix.length() - 1);