opendev/gerrit
Code Issues Proposed changes

Move: Use BooleanCondition for #setVisible

Browse Source 
Change-Id: I95e6732d239d836f80ee26d9d036d16bb15676d7
This commit is contained in:
Patrick Hiesel
2017-08-16 17:05:08 +02:00
parent 2c76a76449
commit eea33ed68c
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gerrit-server/src/main/java/com/google/gerrit/server/change/Move.java
View File

@@ -14,6 +14,7 @@
package com.google.gerrit.server.change;
import static com.google.gerrit.extensions.conditions.BooleanCondition.and;
import static com.google.gerrit.server.permissions.ChangePermission.ABANDON;
import static com.google.gerrit.server.permissions.RefPermission.CREATE_CHANGE;
import static com.google.gerrit.server.query.change.ChangeData.asChanges;
@@ -215,11 +216,13 @@ public class Move extends RetryingRestModifyView<ChangeResource, MoveInput, Chan
.setLabel("Move Change")
.setTitle("Move change to a different branch")
.setVisible(
change.getStatus().isOpen()
&& permissionBackend
.user(rsrc.getUser())
.ref(change.getDest())
.testOrFalse(CREATE_CHANGE)
&& rsrc.permissions().database(dbProvider).testOrFalse(ABANDON));
and(
change.getStatus().isOpen(),
and(
permissionBackend
.user(rsrc.getUser())
.ref(change.getDest())
.testCond(CREATE_CHANGE),
rsrc.permissions().database(dbProvider).testCond(ABANDON))));
}
}