opendev/gerrit
Code Issues Proposed changes

Wrap util.js in an IIFE to prevent deploy error

Browse Source 
'use strict' can mess up execution of third-party scripts if
they are all concatenated to the same file. To prevent this, code
is wrapped in an immediately-invoked function expression (IIFE).
This ensures that the strict mode is only applied within the scope
of the function it’s wrapped in.

Change-Id: I59e433b419e2e7b85f87cc97d3add577e2c7590e
This commit is contained in:
Andrew Bonventre
2016-03-29 21:34:50 -04:00
parent 1360710fde
commit ef01a637a1
1 changed files with 40 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
polygerrit-ui/app/scripts/util.js
View File

@@ -11,10 +11,10 @@
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
(function(window) {
'use strict'; 'use strict';
var util = util || {}; var util = window.util || {};
util.parseDate = function(dateStr) { util.parseDate = function(dateStr) {
// Timestamps are given in UTC and have the format // Timestamps are given in UTC and have the format
@@ -54,3 +54,6 @@ util.getCookie = function(name) {
} }
return ''; return '';
}; };
window.util = util;
})(window);