opendev/gerrit
Code Issues Proposed changes

Remove GWT-specific # from change URLs formatted in Git

Browse Source 
PolyGerrit is now feature complete and present in all new Gerrit
releases. Switching the default of how a change URL in formatted in Git
actions to what PolyGerrit sees as default seems like a good choice.

Installations that want to preserve the old behavior for now can still
provide their own ChangeReportFormatter.

Change-Id: Ia5ac14d062b1a0a6ba7de11dedceebb81307fc4e
This commit is contained in:
Patrick Hiesel
2018-06-11 09:25:20 +02:00
parent 7c3eb65c1a
commit ef659e6950
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/ChangeUtil.java
View File

@@ -45,7 +45,7 @@ public class ChangeUtil {
Ordering.from(comparingInt(PatchSet::getPatchSetId));
public static String formatChangeUrl(String canonicalWebUrl, Change change) {
return canonicalWebUrl + "#/c/" + change.getProject().get() + "/+/" + change.getChangeId();
return canonicalWebUrl + "c/" + change.getProject().get() + "/+/" + change.getChangeId();
}
/** @return a new unique identifier for change message entities. */