From efe3c04eace0894ae5eb3512d6468fed91a14e8d Mon Sep 17 00:00:00 2001 From: Ben Rohlfs Date: Mon, 20 Jan 2020 10:43:26 +0100 Subject: [PATCH] Add a warning when the overlay open promise does not resolve Bug: Issue 10774 Change-Id: I18d945495204a0fb7fd53f6231223193572520c6 --- polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js b/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js index 8821bcbb34..5dee2fe422 100644 --- a/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js +++ b/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js @@ -104,6 +104,12 @@ fn.call(this); } else if (iters++ < AWAIT_MAX_ITERS) { step.call(this); + } else { + // TODO(crbug.com/gerrit/10774): Once this is confirmed as the root + // cause of the bug, fix it by either making sure to resolve the fn + // function or find a better way to listen on the overlay being + // shown. + console.warn('gr-overlay _awaitOpen failed to resolve'); } }, AWAIT_STEP); };