opendev/gerrit
Code Issues Proposed changes

Merge "ChangeScreen2: Fix click inside of messages" into stable-2.8

Browse Source
This commit is contained in:
Shawn Pearce
2013-11-22 01:58:29 +00:00
committed by Gerrit Code Review
parent ea7987ff06 b7368e94e0
commit f034e3b906
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java
View File

@@ -41,6 +41,7 @@ class Message extends Composite {
}
@UiField Style style;
@UiField HTMLPanel header;
@UiField Element name;
@UiField Element summary;
@UiField Element date;
@@ -58,7 +59,7 @@ class Message extends Composite {
}
initWidget(uiBinder.createAndBindUi(this));
addDomHandler(new ClickHandler() {
header.addDomHandler(new ClickHandler() {
@Override
public void onClick(ClickEvent event) {
setOpen(!isOpen());

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.ui.xml
View File

@@ -85,9 +85,11 @@ limitations under the License.
addStyleNames='{style.closed}'>
<c:AvatarImage ui:field='avatar' styleName='{style.avatar}'/>
<div class='{style.contents}'>
<div class='{style.name}' ui:field='name'/>
<div ui:field='summary' class='{style.summary}'/>
<div class='{style.date}' ui:field='date'/>
<g:HTMLPanel ui:field='header'>
<div class='{style.name}' ui:field='name'/>
<div ui:field='summary' class='{style.summary}'/>
<div class='{style.date}' ui:field='date'/>
</g:HTMLPanel>
<div ui:field='message'
aria-hidden='true'
style='display: NONE'/>