opendev/gerrit
Code Issues Proposed changes

Shorten column names that are longer than 30 characters

Browse Source 
Some databases can't deal with column names that are longer than 30
characters. Examples are MaxDB and Oracle [1].

Gerrit has two column names in the accounts table that exceed the 30
characters: displayPatchSetsInReverseOrder,
displayPersonNameInReviewCategory

This change renames these 2 columns so that their names fit within
the 30 character range.

[1] http://groups.google.com/group/repo-discuss/browse_thread/thread/ecb713d42c04ae8a/cc963525d8247a17?lnk=gst#cc963525d8247a17

Change-Id: Ie58fb57bea5d5ec3634ad2a73241120a0e50a466
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-04-26 13:52:25 +02:00
parent bbc9de5ac8
commit f0540100d2
8 changed files with 84 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/AccountGeneralPreferences.java
View File

@@ -118,10 +118,10 @@ public final class AccountGeneralPreferences {
* (show latest patch set on top).
*/
@Column(id = 10)
protected boolean displayPatchSetsInReverseOrder;
protected boolean reversePatchSetOrder;
@Column(id = 11)
protected boolean displayPersonNameInReviewCategory;
protected boolean showUsernameInReviewCategory;
public AccountGeneralPreferences() {
}
@@ -188,20 +188,20 @@ public final class AccountGeneralPreferences {
copySelfOnEmail = includeSelfOnEmail;
}
public boolean isDisplayPatchSetsInReverseOrder() {
return displayPatchSetsInReverseOrder;
public boolean isReversePatchSetOrder() {
return reversePatchSetOrder;
}
public void setDisplayPatchSetsInReverseOrder(final boolean displayPatchSetsInReverseOrder) {
this.displayPatchSetsInReverseOrder = displayPatchSetsInReverseOrder;
public void setReversePatchSetOrder(final boolean reversePatchSetOrder) {
this.reversePatchSetOrder = reversePatchSetOrder;
}
public boolean isDisplayPersonNameInReviewCategory() {
return displayPersonNameInReviewCategory;
public boolean isShowUsernameInReviewCategory() {
return showUsernameInReviewCategory;
}
public void setDisplayPersonNameInReviewCategory(final boolean displayPersonNameInReviewCategory) {
this.displayPersonNameInReviewCategory = displayPersonNameInReviewCategory;
public void setShowUsernameInReviewCategory(final boolean showUsernameInReviewCategory) {
this.showUsernameInReviewCategory = showUsernameInReviewCategory;
}
public DateFormat getDateFormat() {
@@ -231,8 +231,8 @@ public final class AccountGeneralPreferences {
showSiteHeader = true;
useFlashClipboard = true;
copySelfOnEmail = false;
displayPatchSetsInReverseOrder = false;
displayPersonNameInReviewCategory = false;
reversePatchSetOrder = false;
showUsernameInReviewCategory = false;
downloadUrl = null;
downloadCommand = null;
dateFormat = null;