opendev/gerrit
Code Issues Proposed changes

Add MIME type for favicons to list of allowed image types.

Browse Source 
Also added a comment with a warning about SVG

Change-Id: I226dfddbb19a0d8f2a8ea45748e6db7eff2fe6d7
(cherry picked from commit c93d71c545)
This commit is contained in:
Lars Clausen
2019-01-08 15:43:08 +01:00
committed by David Pursehouse
parent 673ead8d11
commit f070777f89
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.js
View File

@@ -20,7 +20,9 @@
// Prevent redefinition. // Prevent redefinition.
if (window.GrDiffBuilderImage) { return; } if (window.GrDiffBuilderImage) { return; }
const IMAGE_MIME_PATTERN = /^image\/(bmp|gif|jpeg|jpg|png|tiff|webp)$/; // MIME types for images we allow showing. Do not include SVG, it can contain
// arbitrary JavaScript.
const IMAGE_MIME_PATTERN = /^image\/(bmp|gif|x-icon|jpeg|jpg|png|tiff|webp)$/;
function GrDiffBuilderImage(diff, comments, createThreadGroupFn, prefs, function GrDiffBuilderImage(diff, comments, createThreadGroupFn, prefs,
outputEl, baseImage, revisionImage) { outputEl, baseImage, revisionImage) {