opendev/gerrit
Code Issues Proposed changes

Fix NPE when displaying permaLink in CommitMessageBlock if changeId is null

Browse Source 
Change-Id: I99ef67eaac9f3a17267bac0e03c0661cdc211c0d
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-06-20 20:46:35 +02:00
parent ec689b4b80
commit f073b7e2d6
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommitMessageBlock.java
View File

@@ -76,8 +76,10 @@ public class CommitMessageBlock extends Composite {
}
}
permalinkPanel.add(new ChangeLink(Util.C.changePermalink(), changeId));
permalinkPanel.add(new CopyableLabel(ChangeLink.permalink(changeId), false));
if (changeId != null) {
permalinkPanel.add(new ChangeLink(Util.C.changePermalink(), changeId));
permalinkPanel.add(new CopyableLabel(ChangeLink.permalink(changeId), false));
}
String[] splitCommitMessage = commitMessage.split("\n", 2);