opendev/gerrit
Code Issues Proposed changes

Append $assetsBundle using templates rather than +

Browse Source 
Concatenating a TrustedResourceUrl to a string using + results in an
invalid object. Appending them with normal template interpolation works
fine.

The existing expression was also missing an intervening "/".

Change-Id: Id1d629a6978abef83b2421a0f56c4a05b99a1c76
This commit is contained in:
Dave Borowitz 2018-09-27 14:24:32 -07:00
parent 63e82dbfa2
commit f0d0b1b0a0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
resources/com/google/gerrit/httpd/raw/PolyGerritIndexHtml.soy
View File

@ -65,7 +65,7 @@
//
// github.com/Polymer/polymer-resin/blob/master/getting-started.md#integrating
{if $assetsPath and $assetsBundle}
<link rel="import" href="{$assetsPath + $assetsBundle}">{\n}
<link rel="import" href="{$assetsPath}/{$assetsBundle}">{\n}
{/if}
<link rel="preload" href="{$staticResourcePath}/elements/gr-app.js" as="script" crossorigin="anonymous">{\n}